From: Daniel Vetter <daniel@ffwll.ch>
To: Nick Hoath <nicholas.hoath@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] drm/i195: Add flag to enable virtual mappings above 4Gb
Date: Thu, 19 Mar 2015 17:29:17 +0100 [thread overview]
Message-ID: <20150319162917.GA31422@phenom.ffwll.local> (raw)
In-Reply-To: <1426697873-14389-1-git-send-email-nicholas.hoath@intel.com>
On Wed, Mar 18, 2015 at 04:57:53PM +0000, Nick Hoath wrote:
> Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset hardware
> workarounds require that GeneralStateOffset & InstructionBaseOffset
> are restricted to a 32 bit address space.
>
> This is a preparatory patch prior to supporting 64bit virtual memory
> allocations.
>
> Allow the user space to flag that a mapping can occur beyond
> the 32bit limit. This allows backward compatibility and user space
> drivers that haven't been enhanced to support these workarounds to
> function.
>
> Signed-off-by: Nick Hoath <nicholas.hoath@intel.com>
Because of the libdrm buffer cache being opaque to the different users
I don't see how a flag set at create time will work.
Also on a very quick look all userspace is still nice and relocates
indirect state with I915_GEM_DOMAIN_INSTRUCTION (well except no-reloc
userspace where this is lost). Can't we just piggy-pack on top of that?
Creative abuse of established abi ;-) But that's easy to resolve with an
additional bit for no-reloc in execbuf to signal that it's indirect state
and one flag to allow it.
Upside of that approach is that we don't need to change anything in
userspace, except SNA (atm the only no-reloc user).
And yeah I think for this one here we need to have all the support rolled
out for everyone to make sure it actually works ...
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-03-19 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 16:57 [RFC] drm/i195: Add flag to enable virtual mappings above 4Gb Nick Hoath
2015-03-18 17:08 ` Tvrtko Ursulin
2015-03-19 16:29 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319162917.GA31422@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nicholas.hoath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox