From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Async eDP init
Date: Thu, 19 Mar 2015 18:42:37 +0100 [thread overview]
Message-ID: <20150319174237.GJ31422@phenom.ffwll.local> (raw)
In-Reply-To: <1426704109-5244-1-git-send-email-jbarnes@virtuousgeek.org>
On Wed, Mar 18, 2015 at 11:41:48AM -0700, Jesse Barnes wrote:
> This updates my old patch for this, but w/o fixing the locking issue
> Ville mentioned. In looking at it, it seems like the sync point should
> be at a higher level, maybe at the level of the atomic mode setting async
> serialization points? Another possibility would be to make it a lazy
> init type function, sprinkled about but only running once when we first
> need it.
>
> Any thoughts from anyone? I don't think I can just do a lock drop here,
> since other threads may jump in and mess with underlying state. That
> shouldn't affect the eDP state we fill out, but may affect the state the
> caller depended on in the first place...
Imo the real issue is that we register a connector and then throw it away
again. Not that big a problem any more since mst dp happened meanwhile but
still might result in confusion.
I think we should try to at least get the "is this an edp or not" question
right, and only postpone the other init steps. So maybe start with making
that edp failed to init issue really loud and then rip it out?
Postponing all the other init work would be comparitively a lot easier I
think.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-19 17:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 18:41 Async eDP init Jesse Barnes
2015-03-18 18:41 ` [PATCH] drm/i915/dp: move edp init to work queue Jesse Barnes
2015-03-19 13:24 ` shuang.he
2015-03-19 17:42 ` Daniel Vetter [this message]
2015-03-19 18:00 ` Async eDP init Jesse Barnes
2015-03-19 18:40 ` Jesse Barnes
2015-03-19 18:53 ` Ville Syrjälä
2015-03-19 19:13 ` Jesse Barnes
2015-03-19 19:25 ` Ville Syrjälä
2015-03-20 10:19 ` Daniel Vetter
2015-03-19 17:44 ` Daniel Vetter
2015-03-19 18:06 ` Jesse Barnes
2015-03-20 10:16 ` Daniel Vetter
2015-03-20 10:41 ` Chris Wilson
2015-03-20 15:38 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319174237.GJ31422@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox