From: Daniel Vetter <daniel@ffwll.ch>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/kms_psr_sink_crc: Make render visible to human eyes
Date: Mon, 23 Mar 2015 09:36:20 +0100 [thread overview]
Message-ID: <20150323083620.GH1349@phenom.ffwll.local> (raw)
In-Reply-To: <20150323083527.GG1349@phenom.ffwll.local>
On Mon, Mar 23, 2015 at 09:35:27AM +0100, Daniel Vetter wrote:
> On Fri, Mar 20, 2015 at 05:43:40PM +0000, Vivi, Rodrigo wrote:
> > On Fri, 2015-03-20 at 10:54 +0100, Daniel Vetter wrote:
> > > On Thu, Mar 19, 2015 at 06:24:24PM -0700, Rodrigo Vivi wrote:
> > > > This will allow manual tests when crc isn't available.
> > > >
> > > > v2: Remove unused and non-sense buf->size and decrease buf->stride a bit as suggested by Daniel.
> > >
> > > buf->size isn't nonsense really, it does seem to match what we've
> > > allocated. But it also seems unused in the rendercpy functions I've
> > > checked. Imo you should keep that line
> >
> > oh sure, bad phrase.... the value 4 was nonsense.
> > But if I increases that it fails. Without setting it works.
> > What do you think?
>
> If just keeping that line makes the test work there's something _really_
> fishy going on. If it persists after git clean -dfx and full recompile I'd
> dig into it, since this really doesn't make sense.
valgrined might be the best tool for a first attempt at figuring out
what's wrong.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-23 8:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 22:19 [PATCH i-g-t 01/10] tests/kms_psr_sink_crc: Make blt visible to human eyes Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 02/10] tests/kms_psr_sink_crc: Make render " Rodrigo Vivi
2015-03-16 8:59 ` Daniel Vetter
2015-03-16 20:23 ` Vivi, Rodrigo
2015-03-17 10:27 ` Daniel Vetter
2015-03-20 1:24 ` [PATCH] " Rodrigo Vivi
2015-03-20 9:54 ` Daniel Vetter
2015-03-20 17:43 ` Vivi, Rodrigo
2015-03-23 8:35 ` Daniel Vetter
2015-03-23 8:36 ` Daniel Vetter [this message]
2015-03-23 21:53 ` Vivi, Rodrigo
2015-03-24 9:02 ` Daniel Vetter
2015-04-15 1:08 ` Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 03/10] tests/kms_psr_sink_crc: Make mmaps " Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 04/10] tests/kms_psr_sink_crc: Make plane_move " Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 05/10] tests/kms_psr_sink_crc: Add manual mode Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 06/10] lib/igt_aux: Introduce igt_debug_warn_and_wait_for_key Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 07/10] tests/kms_psr_sink_crc: Use pressed key to pass/fail Rodrigo Vivi
2015-03-16 9:04 ` Daniel Vetter
2015-03-16 9:07 ` Daniel Vetter
2015-03-16 22:44 ` [PATCH] lib/igt_aux: Introduce igt_interactive_debug_manual_check Rodrigo Vivi
2015-03-17 10:28 ` Daniel Vetter
2015-03-20 1:11 ` Rodrigo Vivi
2015-03-20 9:55 ` Daniel Vetter
2015-03-13 22:19 ` [PATCH i-g-t 08/10] tests/kms_psr_sink_crc: remove timeout option from wait_psr_entry Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 09/10] test/kms_psr_sink_crc: Split plane setup operations Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 10/10] test/kms_psr_sink_crc: Add dpms off/on tests Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323083620.GH1349@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox