From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Keep ring->active_list and ring->requests_list consistent Date: Mon, 23 Mar 2015 09:49:15 +0100 Message-ID: <20150323084915.GJ1349@phenom.ffwll.local> References: <1426702762-6490-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 331566E4FC for ; Mon, 23 Mar 2015 01:47:32 -0700 (PDT) Received: by weop45 with SMTP id p45so131727469weo.0 for ; Mon, 23 Mar 2015 01:47:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1426702762-6490-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMTgsIDIwMTUgYXQgMDY6MTk6MjJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IElmIHdlIHJldGlyZSByZXF1ZXN0cyBsYXN0LCB3ZSBtYXkgdXNlIGEgbGF0ZXIgc2Vx bm8gYW5kIHNvIGNsZWFyCj4gdGhlIHJlcXVlc3RzIGxpc3RzIHdpdGhvdXQgY2xlYXJpbmcgdGhl IGFjdGl2ZSBsaXN0LCBsZWFkaW5nIHRvCj4gY29uZnVzaW9uLiBIZW5jZSB3ZSBzaG91bGQgcmV0 aXJlIHJlcXVlc3RzIGZpcnN0IGZvciBjb25zaXN0ZW5jeSB3aXRoCj4gdGhlIGVhcmx5IHJldHVy bi4gVGhlIG9yZGVyIHVzZWQgdG8gYmUgaW1wb3J0YW50IGFzIHRoZSBsaWZlY3ljbGUgZm9yCj4g dGhlIG9iamVjdCBvbiB0aGUgYWN0aXZlIGxpc3Qgd2FzIGRldGVybWluZWQgYnkgcmVxdWVzdC0+ c2Vxbm8uIEhvd2V2ZXIsCj4gdGhlIHJlcXVlc3RzIHRoZW1zZWx2ZXMgYXJlIG5vdyByZWZlcmVu Y2UgY291bnRlZCByZW1vdmluZyB0aGUKPiBjb25zdHJhaW50IGZyb20gdGhlIG9yZGVyIG9mIHJl dGlyZW1lbnQuCj4gCj4gRml4ZXMgcmVncmVzc2lvbiBmcm9tCj4gCj4gY29tbWl0IDFiNWE0MzNh NGRkOTY3YjEyNTEzMWRhNDJiODliNWNjMGQ1YjFmNTcKPiBBdXRob3I6IEpvaG4gSGFycmlzb24g PEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4gRGF0ZTogICBNb24gTm92IDI0IDE4OjQ5OjQy IDIwMTQgKzAwMDAKPiAKPiAgICAgZHJtL2k5MTU6IENvbnZlcnQgJ2k5MTVfc2Vxbm9fcGFzc2Vk JyBjYWxscyBpbnRvICdpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZAo+ICcKPiAKPiBhbmQgYQo+ IAo+IAlXQVJOSU5HOiBDUFU6IDAgUElEOiAxMzgzIGF0IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX2V2aWN0LmM6Mjc5IGk5MTVfZ2VtX2V2aWN0X3ZtKzB4MTBjLzB4MTQwKCkKPiAJV0FS Tl9PTighbGlzdF9lbXB0eSgmdm0tPmFjdGl2ZV9saXN0KSkKPiAKPiBJZGVudGlmaWVkIGJ5IHVw ZGF0aW5nIFdBVENIX0xJU1RTOgo+IAo+IAlbZHJtOmk5MTVfdmVyaWZ5X2xpc3RzXSAqRVJST1Iq IGJsaXR0ZXIgcmluZzogYWN0aXZlIGxpc3Qgbm90IGVtcHR5LCBidXQgbm8gcmVxdWVzdHMKPiAJ V0FSTklORzogQ1BVOiAwIFBJRDogNjgxIGF0IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmM6Mjc1MSBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHNfcmluZysweDE0OS8weDIzMCgpCj4gCVdB Uk5fT04oaTkxNV92ZXJpZnlfbGlzdHMocmluZy0+ZGV2KSkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogSm9obiBIYXJyaXNv biA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KCkluIGNhc2UgaXQncyBidXJyaWVkIHRvbyBtdWNoIGluIHRoZSB0 aHJlYWQ6CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4KCkFkZGFkZW5kdW0gZm9yIHRoZSBjb21taXQ6CgoiTm90ZSB0aGF0IHRoaXMgaXMgb25seSBh IHByb2JsZW0gaW4gZXZpY3Rfdm0gd2hlcmUgdGhlIGZvbGxvd2luZyBoYXBwZW5zCmFmdGVyIGEg cmV0aXJlX3JlcXVlc3QgaGFzIGNsZWFuZWQgb3V0IGFsbCByZXF1ZXN0cywgYnV0IG5vdCBhbGwg YWN0aXZlCmJvOgotIGludGVsX3JpbmdfaWRsZSBjYWxsZWQgZnJvbSBpOTE1X2dwdV9pZGxlIG5v dGljZXMgdGhhdCBubyByZXF1ZXN0cyBhcmUKICBvdXRzdGFuZGluZyBhbmQgaW1tZWRpYXRlbHkg cmV0dXJucy4KLSBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHNfcmluZyBjYWxsZWQgZnJvbSBpOTE1 X2dlbV9yZXRpcmVfcmVxdWVzdHMgYWxzbwogIGltbWVkaWF0ZWx5IHJldHVybnMgd2hlbiB0aGVy ZSdzIG5vIHJlcXVlc3QsIHN0aWxsIGxlYXZpbmcgdGhlIGJvIG9uIHRoZQogIGFjdGl2ZSBsaXN0 LgotIGV2aWN0X3ZtIGhpdHMgdGhlIFdBUk5fT04oIWxpc3RfZW1wdHkoJnZtLT5hY3RpdmVfbGlz dCkpIGFmdGVyIGV2aWN0aW5nCiAgYWxsIGFjdGl2ZSBvYmplY3RzIHRoYXQgdGhlcmUncyBzdGls bCBzdHVmZiBsZWZ0IHRoYXQgc2hvdWxkbid0IGJlCiAgdGhlcmUuIgoKQ2hyaXMsIGlzIHRoYXQg YW4gYWNjdXJhdGUgZW5vdWdoIGRlc2NyaXB0aW9uIGZvciBKYW5pIHRvIGFkZCB0byB0aGUKcGF0 Y2g/Ci1EYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDM4 ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAyMSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPiBpbmRleCAwOTJmMjVjZmI4ZDUuLjdhOTU4OWYzOGJiYyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+IEBAIC0yNjYwLDI0ICsyNjYwLDExIEBAIGk5MTVfZ2VtX3JldGlyZV9y ZXF1ZXN0c19yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIAo+ICAJV0FSTl9P TihpOTE1X3ZlcmlmeV9saXN0cyhyaW5nLT5kZXYpKTsKPiAgCj4gLQkvKiBNb3ZlIGFueSBidWZm ZXJzIG9uIHRoZSBhY3RpdmUgbGlzdCB0aGF0IGFyZSBubyBsb25nZXIgcmVmZXJlbmNlZAo+IC0J ICogYnkgdGhlIHJpbmdidWZmZXIgdG8gdGhlIGZsdXNoaW5nL2luYWN0aXZlIGxpc3RzIGFzIGFw cHJvcHJpYXRlLAo+IC0JICogYmVmb3JlIHdlIGZyZWUgdGhlIGNvbnRleHQgYXNzb2NpYXRlZCB3 aXRoIHRoZSByZXF1ZXN0cy4KPiArCS8qIFJldGlyZSByZXF1ZXN0cyBmaXJzdCBhcyB3ZSB1c2Ug aXQgYWJvdmUgZm9yIHRoZSBlYXJseSByZXR1cm4uCj4gKwkgKiBJZiB3ZSByZXRpcmUgcmVxdWVz dHMgbGFzdCwgd2UgbWF5IHVzZSBhIGxhdGVyIHNlcW5vIGFuZCBzbyBjbGVhcgo+ICsJICogdGhl IHJlcXVlc3RzIGxpc3RzIHdpdGhvdXQgY2xlYXJpbmcgdGhlIGFjdGl2ZSBsaXN0LCBsZWFkaW5n IHRvCj4gKwkgKiBjb25mdXNpb24uCj4gIAkgKi8KPiAtCXdoaWxlICghbGlzdF9lbXB0eSgmcmlu Zy0+YWN0aXZlX2xpc3QpKSB7Cj4gLQkJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsK PiAtCj4gLQkJb2JqID0gbGlzdF9maXJzdF9lbnRyeSgmcmluZy0+YWN0aXZlX2xpc3QsCj4gLQkJ CQkgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCwKPiAtCQkJCSAgICAgIHJpbmdfbGlz dCk7Cj4gLQo+IC0JCWlmICghaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQob2JqLT5sYXN0X3Jl YWRfcmVxLCB0cnVlKSkKPiAtCQkJYnJlYWs7Cj4gLQo+IC0JCWk5MTVfZ2VtX29iamVjdF9tb3Zl X3RvX2luYWN0aXZlKG9iaik7Cj4gLQl9Cj4gLQo+IC0KPiAgCXdoaWxlICghbGlzdF9lbXB0eSgm cmluZy0+cmVxdWVzdF9saXN0KSkgewo+ICAJCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq cmVxdWVzdDsKPiAgCj4gQEAgLTI3MDAsNiArMjY4NywyMyBAQCBpOTE1X2dlbV9yZXRpcmVfcmVx dWVzdHNfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAJCWk5MTVfZ2VtX2Zy ZWVfcmVxdWVzdChyZXF1ZXN0KTsKPiAgCX0KPiAgCj4gKwkvKiBNb3ZlIGFueSBidWZmZXJzIG9u IHRoZSBhY3RpdmUgbGlzdCB0aGF0IGFyZSBubyBsb25nZXIgcmVmZXJlbmNlZAo+ICsJICogYnkg dGhlIHJpbmdidWZmZXIgdG8gdGhlIGZsdXNoaW5nL2luYWN0aXZlIGxpc3RzIGFzIGFwcHJvcHJp YXRlLAo+ICsJICogYmVmb3JlIHdlIGZyZWUgdGhlIGNvbnRleHQgYXNzb2NpYXRlZCB3aXRoIHRo ZSByZXF1ZXN0cy4KPiArCSAqLwo+ICsJd2hpbGUgKCFsaXN0X2VtcHR5KCZyaW5nLT5hY3RpdmVf bGlzdCkpIHsKPiArCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICsKPiArCQlv YmogPSBsaXN0X2ZpcnN0X2VudHJ5KCZyaW5nLT5hY3RpdmVfbGlzdCwKPiArCQkJCSAgICAgIHN0 cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0LAo+ICsJCQkJICAgICAgcmluZ19saXN0KTsKPiArCj4g KwkJaWYgKCFpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChvYmotPmxhc3RfcmVhZF9yZXEsIHRy dWUpKQo+ICsJCQlicmVhazsKPiArCj4gKwkJaTkxNV9nZW1fb2JqZWN0X21vdmVfdG9faW5hY3Rp dmUob2JqKTsKPiArCX0KPiArCj4gIAlpZiAodW5saWtlbHkocmluZy0+dHJhY2VfaXJxX3JlcSAm Jgo+ICAJCSAgICAgaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocmluZy0+dHJhY2VfaXJxX3Jl cSwgdHJ1ZSkpKSB7Cj4gIAkJcmluZy0+aXJxX3B1dChyaW5nKTsKPiAtLSAKPiAyLjEuNAo+IAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==