Re: [PATCH 4/9] drivers/pwm: Add helper to configure pwm using clock divisor and duty percent

From: Thierry Reding <thierry.reding@gmail.com>
To: Shobhit Kumar <shobhit.kumar@intel.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Jani Nikula <jani.nikula@intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 4/9] drivers/pwm: Add helper to configure pwm using clock divisor and duty percent
Date: Tue, 24 Mar 2015 09:23:59 +0100	[thread overview]
Message-ID: <20150324082357.GA17183@ulmo.nvidia.com> (raw)
In-Reply-To: <1426255082-25002-1-git-send-email-shobhit.kumar@intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 760 bytes --]

On Fri, Mar 13, 2015 at 07:28:02PM +0530, Shobhit Kumar wrote:
> Some chips instead of using period_ns and duty_ns can be configured
> using the clock divisor and duty percent. Adds an alternative
> configuration method for such chips

I don't see a need to introduce this alternative configuration
mechanism. Most, of not all, of the other drivers program a clock
divisor and some percentage of the duty cycle as well and it should be
easy to convert to that internally from the period and duty_cycle
parameters that you get in ->config().

Adding an alternative means of configuring the PWM also means that every
user driver now potentially needs to support both the traditional and
the alternative way because PWM providers may not implement both.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx