From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 4/9] drivers/pwm: Add helper to configure pwm using clock divisor and duty percent Date: Tue, 24 Mar 2015 09:23:59 +0100 Message-ID: <20150324082357.GA17183@ulmo.nvidia.com> References: <1426177893-17945-5-git-send-email-shobhit.kumar@intel.com> <1426255082-25002-1-git-send-email-shobhit.kumar@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1537622247==" Return-path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 941096E681 for ; Tue, 24 Mar 2015 01:24:04 -0700 (PDT) Received: by pdnc3 with SMTP id c3so214488596pdn.0 for ; Tue, 24 Mar 2015 01:24:04 -0700 (PDT) In-Reply-To: <1426255082-25002-1-git-send-email-shobhit.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shobhit Kumar Cc: Alexandre Courbot , Samuel Ortiz , Jani Nikula , intel-gfx , Daniel Vetter , Linus Walleij List-Id: intel-gfx@lists.freedesktop.org --===============1537622247== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 13, 2015 at 07:28:02PM +0530, Shobhit Kumar wrote: > Some chips instead of using period_ns and duty_ns can be configured > using the clock divisor and duty percent. Adds an alternative > configuration method for such chips I don't see a need to introduce this alternative configuration mechanism. Most, of not all, of the other drivers program a clock divisor and some percentage of the duty cycle as well and it should be easy to convert to that internally from the period and duty_cycle parameters that you get in ->config(). Adding an alternative means of configuring the PWM also means that every user driver now potentially needs to support both the traditional and the alternative way because PWM providers may not implement both. Thierry --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVER8bAAoJEN0jrNd/PrOh8ckQAJyeKjU8HMiR8KJ5/TYzl70A EbuEHFtREPCVc48T0gMuNuv5xaageqeMeJGzX49/TDgHXly9aU2ANv/ESFuDHBqq 3TvsgNtnJ1H6HW3oaVmv4sqZvHTI0WcRwP2N3FfVa0iI+DB+K7n5hBfziXgYT+qR IhBrTdThJ2ER4F7qDF0c3EIMyJLVC16xB5/kMn/oWM8YTpG20Dal6IF8enZ8gvsa RPS4RgYaIPqObjh/c11Sswdmyu8aD3iCm51id5CtAv06YeaBtO+KITUglldSUl+E Fz/NHKPUTtgwh4kRmY4gnyWEwr0rAOvTuFH3brInc5ZT02w52HL8fjrrEvToFmaO s7sPH5y80Qd00DstSwt6U0pw84F8UpCFsDmi1VP/uN5gd3v/oTnujDPiUVujg8oL iV+2ZjcZdycbrbF/TfWXbc3z0nRNvMNnznDt7I2vMdA+jyxXjxUAiX71CcPM0HLr L3LALmdv7Hq7v4Dk6V3gvO/yp52KClun44pkG1u9WFQ7N7yyIUMgm59/EMsfZbUa WTjoOh5z7XpNIdLnt+H/acXuV2avWGRiAb4r+F6ccBu95FUxgA5ev9cWBFfTDlWQ PI7DgeV/QawaaaaRwrfRR3F5AQCFcYfloesPTILHPEK0ZE+uGf55WqjWWTg2qy1u pwTzmR9hayNwh0n6XBl5 =vJ6M -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g-- --===============1537622247== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1537622247==--