Re: [PATCH 2/2] drm/i915: move clearing of RPS interrupt bits from disable to reset time

Daniel Vetter
2015-03-24T09:13:15Z

On Mon, Mar 23, 2015 at 07:11:35PM +0200, Imre Deak wrote:
> The logical place for clearing the RPS latched interrupt bits is when
> resetting the RPS interrupts, so move the corresponding part from the RPS
> disable function to the reset function. During resetting we already
> cleared the IIR bits, so the only thing missing there was clearing pm_iir.
>
> Note that we call gen6_disable_rps_interrupts() also during driver load
> and resume time via intel_uncore_sanitize() when i915 interrupts are
> still not installed. If there are any pending RPS bits at this point
> (which after this patch wouldn't be cleared) they will be cleared by the
> reset code via the interrupt preinstall hooks.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Both merged to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation