From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: move clearing of RPS interrupt bits from disable to reset time
Date: Tue, 24 Mar 2015 10:14:59 +0100 [thread overview]
Message-ID: <20150324091459.GD1349@phenom.ffwll.local> (raw)
In-Reply-To: <1427130695-5705-2-git-send-email-imre.deak@intel.com>
On Mon, Mar 23, 2015 at 07:11:35PM +0200, Imre Deak wrote:
> The logical place for clearing the RPS latched interrupt bits is when
> resetting the RPS interrupts, so move the corresponding part from the RPS
> disable function to the reset function. During resetting we already
> cleared the IIR bits, so the only thing missing there was clearing pm_iir.
>
> Note that we call gen6_disable_rps_interrupts() also during driver load
> and resume time via intel_uncore_sanitize() when i915 interrupts are
> still not installed. If there are any pending RPS bits at this point
> (which after this patch wouldn't be cleared) they will be cleared by the
> reset code via the interrupt preinstall hooks.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Both merged to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-24 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 17:11 [PATCH 1/2] drm/i915: fix race when clearing RPS IIR bits Imre Deak
2015-03-23 17:11 ` [PATCH 2/2] drm/i915: move clearing of RPS interrupt bits from disable to reset time Imre Deak
2015-03-24 9:14 ` Daniel Vetter [this message]
2015-03-24 20:39 ` shuang.he
2015-03-23 21:10 ` [PATCH 1/2] drm/i915: fix race when clearing RPS IIR bits Chris Wilson
2015-03-24 9:14 ` Daniel Vetter
2015-03-24 9:24 ` Chris Wilson
2015-03-24 20:52 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324091459.GD1349@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox