public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Mark Brown <broonie@linaro.org>,
	Shobhit Kumar <shobhit.kumar@intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/9] drm/i915: Use the CRC gpio for panel enable/disable
Date: Wed, 25 Mar 2015 14:13:21 +0100	[thread overview]
Message-ID: <20150325131321.GV1349@phenom.ffwll.local> (raw)
In-Reply-To: <CACRpkdZ+KFsFsoXsJruruipvzqemQOwDNSxWBPLNmGhzO0835Q@mail.gmail.com>

On Wed, Mar 25, 2015 at 01:24:01PM +0100, Linus Walleij wrote:
> On Tue, Mar 24, 2015 at 11:53 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Mar 24, 2015 at 11:16 AM, Linus Walleij
> > <linus.walleij@linaro.org> wrote:
> 
> > So summary:
> > - Reusing the dynamic gpio lookup stuff would be nice, and might be
> > interesting as a new crazy use-case (or maybe not). But not a
> > requirement since we have the component framework to handroll
> > something.
> 
> OK I guess you have me convinced, I will apply the patch from
> Shobhit. If it turns out ugly we can always revert it. If you believe
> in it, it's worth a try.
> 
> Also as you say else it will be reinvented, let's go this way as it
> is likely the lesser of two evils.

Thanks for reconsidering.

I quickly checked out your linux-gpio and it only has patch 2 to implement
the gpio. We also need patch 1 (but with the leak Thierry spotted fixed).
Should we drop Shobit's patch until that's done?

Wrt merging the 4.1 window on the drm side is pretty much closed so I
think I'll have to postpone the i915 side to 4.2 anyway. Luckily there's
no direct depencies because we look up everything dynamically, so patches
can go in in any order.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-25 13:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 16:31 [RFC v5 0/9] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar
2015-03-12 16:31 ` [RFC v5 1/9] drivers/mfd: Add lookup table for Panel Control as GPIO signal Shobhit Kumar
2015-03-24  8:51   ` Thierry Reding
2015-03-24  9:37   ` Linus Walleij
2015-03-25 14:53   ` Linus Walleij
2015-03-12 16:31 ` [RFC v5 2/9] gpio/crystalcove: Add additional GPIO for Panel control Shobhit Kumar
2015-03-18 11:54   ` Linus Walleij
2015-03-25 14:51   ` Linus Walleij
2015-03-12 16:31 ` [RFC v5 3/9] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar
2015-03-13 14:29   ` Ville Syrjälä
2015-03-16  4:42     ` [PATCH " Shobhit Kumar
2015-03-18 12:19       ` Linus Walleij
2015-03-24  8:32         ` Daniel Vetter
2015-03-24  9:35           ` Linus Walleij
2015-03-24  9:50             ` Daniel Vetter
2015-03-24 10:16               ` Linus Walleij
2015-03-24 10:53                 ` Daniel Vetter
2015-03-25 12:24                   ` Linus Walleij
2015-03-25 13:13                     ` Daniel Vetter [this message]
2015-03-25 14:16                       ` Shobhit Kumar
2015-03-25 14:55                       ` Linus Walleij
2015-03-25 15:45                         ` Daniel Vetter
2015-03-12 16:31 ` [RFC v5 4/9] drivers/pwm: Add helper to configure pwm using clock divisor and duty percent Shobhit Kumar
2015-03-13 13:58   ` [PATCH " Shobhit Kumar
2015-03-24  8:23     ` Thierry Reding
2015-04-01  6:28       ` Shobhit Kumar
2015-04-10  8:29         ` Thierry Reding
2015-04-13  8:02           ` Shobhit Kumar
2015-03-12 16:31 ` [RFC v5 5/9] drivers/mfd: Add PWM cell device for Crystalcove PMIC Shobhit Kumar
2015-03-12 16:31 ` [RFC v5 6/9] drivers/pwm: Add Crystalcove (CRC) PWM driver Shobhit Kumar
2015-03-12 16:31 ` [RFC v5 7/9] drivers/pwm: Remove __init initializer for pwm_add_table Shobhit Kumar
2015-03-12 16:31 ` [RFC v5 8/9] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar
2015-03-12 16:31 ` [RFC v5 9/9] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar
2015-03-13 14:30   ` Ville Syrjälä
2015-03-13 17:20     ` Daniel Vetter
2015-03-16  4:23       ` Shobhit Kumar
2015-03-16  4:33     ` Shobhit Kumar
2015-03-24  8:59     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325131321.GV1349@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=broonie@linaro.org \
    --cc=daniel.vetter@intel.com \
    --cc=gnurou@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    --cc=sameo@linux.intel.com \
    --cc=shobhit.kumar@intel.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox