From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: ander.conselvan.de.oliveira@intel.com, daniel.vetter@intel.com,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 05/21 v2] drm/i915: Initialize skylake scalers
Date: Wed, 25 Mar 2015 14:24:02 +0100 [thread overview]
Message-ID: <20150325132402.GY1349@phenom.ffwll.local> (raw)
In-Reply-To: <20150325051401.GF28667@intel.com>
On Tue, Mar 24, 2015 at 10:14:01PM -0700, Matt Roper wrote:
> On Fri, Mar 20, 2015 at 05:04:26PM -0700, Chandra Konduru wrote:
> > +static void skl_init_scalers(struct drm_device *dev, int pipe,
> > + struct intel_crtc_state *crtc_state)
> > +{
> > + int i;
> > + struct intel_scaler *intel_scaler;
> > + struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
> > + if (INTEL_INFO(dev)->gen < 9)
> > + return;
>
> It's probably better to move this guard out to the callsite so that we
> can more easily extend this for future platforms. Unless you plan to
> just extend this function in the future, in which case we should
> probably drop the 'skl_' prefix.
Naming rule is that platform-specific stuff is named with the first
platform codename that uses it. So skl_ is still fine even if we extend
this for bxt or skl+1. intel_ should only be used for truly generic
driver-wide stuff.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-25 13:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 0:04 [PATCH 00/21 v2] Adding support for skylake shared scalers Chandra Konduru
2015-03-21 0:04 ` [PATCH 01/21 v2] drm/i915: Adding drm helper function drm_plane_from_index() Chandra Konduru
2015-03-23 9:32 ` Daniel Vetter
2015-03-23 16:32 ` Konduru, Chandra
2015-03-21 0:04 ` [PATCH 02/21 v2] drm/i915: Register definitions for skylake scalers Chandra Konduru
2015-03-21 0:04 ` [PATCH 03/21 v2] drm/i915: Enable get_colorkey functions for primary plane Chandra Konduru
2015-03-21 0:04 ` [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions Chandra Konduru
2015-03-25 5:13 ` Matt Roper
2015-03-25 13:22 ` Daniel Vetter
2015-03-25 16:54 ` Konduru, Chandra
2015-03-21 0:04 ` [PATCH 05/21 v2] drm/i915: Initialize skylake scalers Chandra Konduru
2015-03-25 5:14 ` Matt Roper
2015-03-25 13:24 ` Daniel Vetter [this message]
2015-03-25 16:56 ` Konduru, Chandra
2015-03-25 23:21 ` [PATCH 05/21 v3] " Chandra Konduru
2015-03-21 0:04 ` [PATCH 06/21 v2] drm/i915: Dump scaler_state too as part of dumping crtc_state Chandra Konduru
2015-03-21 0:04 ` [PATCH 07/21 v2] drm/i915: Helper function to update skylake scaling ratio Chandra Konduru
2015-03-25 5:14 ` Matt Roper
2015-03-25 17:37 ` Konduru, Chandra
2015-03-25 23:21 ` [PATCH 07/21 v3] " Chandra Konduru
2015-03-21 0:04 ` [PATCH 08/21 v2] drm/i915: Add helper function to update scaler_users in crtc_state Chandra Konduru
2015-03-25 5:15 ` Matt Roper
2015-03-25 19:20 ` Konduru, Chandra
2015-03-25 20:58 ` Matt Roper
2015-03-25 22:02 ` Konduru, Chandra
2015-03-25 23:21 ` [PATCH 08/21 v3] " Chandra Konduru
2015-03-21 0:04 ` [PATCH 09/21 v2] drm/i915: Add atomic function to setup scalers scalers for a crtc Chandra Konduru
2015-03-25 5:15 ` Matt Roper
2015-03-25 19:46 ` Konduru, Chandra
2015-03-25 23:21 ` [PATCH 09/21 v3] " Chandra Konduru
2015-03-21 0:04 ` [PATCH 10/21 v2] drm/i915: Helper function to detach a scaler from a plane or crtc Chandra Konduru
2015-03-25 5:15 ` Matt Roper
2015-03-25 20:14 ` Konduru, Chandra
2015-03-25 21:13 ` Matt Roper
2015-03-25 21:28 ` Konduru, Chandra
2015-03-28 0:21 ` Matt Roper
2015-03-30 19:06 ` Konduru, Chandra
2015-03-25 23:21 ` [PATCH 10/21 v3] " Chandra Konduru
2015-03-21 0:04 ` [PATCH 11/21 v2] drm/i915: Ensure planes begin with no scaler Chandra Konduru
2015-03-25 5:17 ` Matt Roper
2015-03-21 0:04 ` [PATCH 12/21 v2] drm/i915: Ensure colorkey and scaling aren't enabled at same time Chandra Konduru
2015-03-25 17:21 ` Matt Roper
2015-03-25 17:29 ` Konduru, Chandra
2015-03-21 0:04 ` [PATCH 13/21 v2] drm/i915: Preserve scaler state when clearing crtc_state Chandra Konduru
2015-03-21 0:04 ` [PATCH 14/21 v2] drm/i915: use current scaler state during readout_hw_state Chandra Konduru
2015-03-21 0:04 ` [PATCH 15/21 v2] drm/i915: Update scaling ratio as part of crtc_compute_config Chandra Konduru
2015-03-21 0:04 ` [PATCH 16/21 v2] drm/i915: Ensure setting up scalers into staged crtc_state Chandra Konduru
2015-03-25 17:21 ` Matt Roper
2015-03-25 17:26 ` Konduru, Chandra
2015-03-21 0:04 ` [PATCH 17/21 v2] drm/i915: copy staged scaler state from drm state to crtc->config Chandra Konduru
2015-03-21 0:04 ` [PATCH 18/21 v2] drm/i915: stage panel fitting scaler request for fixed mode panel Chandra Konduru
2015-03-21 0:04 ` [PATCH 19/21 v2] drm/i915: Enable skylake panel fitting using skylake shared scalers Chandra Konduru
2015-03-21 0:04 ` [PATCH 20/21 v2] drm/i915: Enable skylake primary plane scaling using " Chandra Konduru
2015-03-21 0:04 ` [PATCH 21/21 v2] drm/i915: Enable skylake sprite " Chandra Konduru
2015-03-25 21:29 ` Matt Roper
2015-03-25 21:55 ` Konduru, Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325132402.GY1349@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox