From: Daniel Vetter <daniel@ffwll.ch>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 05/20] drm/i915: Update dummy connector atomic state with current config
Date: Thu, 26 Mar 2015 16:27:49 +0100 [thread overview]
Message-ID: <20150326152748.GF24805@phenom.ffwll.local> (raw)
In-Reply-To: <1426861099-28445-6-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Fri, Mar 20, 2015 at 04:18:05PM +0200, Ander Conselvan de Oliveira wrote:
> @@ -10136,6 +10157,8 @@ static void intel_modeset_commit_output_state(struct drm_device *dev)
> crtc->base.state->enable = crtc->new_enabled;
> crtc->base.enabled = crtc->new_enabled;
> }
> +
> + intel_modeset_update_connector_atomic_state(dev);
Just an aside: I think we should move the crtc state update and the
updated vblank timings right before the call to intel_modeset_update_state
into that itself. I spent a bit of time looking for that logic until I
found it ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-26 15:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:18 [PATCH v3 00/20] Remove depencies on staged config for atomic transition Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 01/20] drm/i915: Add intel_atomic_get_crtc_state() helper function Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 02/20] drm/i915: Pass acquire ctx also to intel_release_load_detect_pipe() Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 03/20] drm/i915: Allocate a drm_atomic_state for the legacy modeset code Ander Conselvan de Oliveira
2015-03-27 9:01 ` Daniel Vetter
2015-03-27 9:05 ` Ander Conselvan De Oliveira
2015-03-20 14:18 ` [PATCH 04/20] drm/i915: Allocate a crtc_state also when the crtc is being disabled Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 05/20] drm/i915: Update dummy connector atomic state with current config Ander Conselvan de Oliveira
2015-03-26 15:27 ` Daniel Vetter [this message]
2015-03-20 14:18 ` [PATCH 06/20] drm/i915: Implement connector state duplication Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 07/20] drm/i915: Copy the staged connector config to the legacy atomic state Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 08/20] drm/i915: Don't use encoder->new_crtc in intel_modeset_pipe_config() Ander Conselvan de Oliveira
2015-03-26 16:44 ` Daniel Vetter
2015-03-20 14:18 ` [PATCH 09/20] drm/i915: Don't use encoder->new_crtc in compute_baseline_pipe_bpp() Ander Conselvan de Oliveira
2015-03-26 16:46 ` Daniel Vetter
2015-03-26 16:51 ` Daniel Vetter
2015-03-20 14:18 ` [PATCH 10/20] drm/i915: Don't depend on encoder->new_crtc in intel_dp_compute_config() Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 11/20] drm/i915: Don't depend on encoder->new_crtc in intel_hdmi_compute_config Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 12/20] drm/i915: Use atomic state in intel_ddi_crtc_get_new_encoder() Ander Conselvan de Oliveira
2015-03-26 16:57 ` Daniel Vetter
2015-03-20 14:18 ` [PATCH 13/20] drm/i915: Don't use staged config in intel_dp_mst_compute_config() Ander Conselvan de Oliveira
2015-03-26 17:00 ` Daniel Vetter
2015-03-20 14:18 ` [PATCH 14/20] drm/i915: Don't use encoder->new_crtc in intel_lvds_compute_config() Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 15/20] drm/i915: Pass an atomic state to modeset_global_resources() functions Ander Conselvan de Oliveira
2015-03-20 14:18 ` [PATCH 16/20] drm/i915: Check lane sharing between pipes B & C using atomic state Ander Conselvan de Oliveira
2015-03-27 9:08 ` Daniel Vetter
2015-03-27 13:00 ` [PATCH] " Ander Conselvan de Oliveira
2015-03-27 14:03 ` Daniel Vetter
2015-03-30 5:33 ` Ander Conselvan de Oliveira
2015-03-30 7:17 ` Daniel Vetter
2015-03-30 7:58 ` shuang.he
[not found] ` <28056_1427699754_5518F829_28056_1298_1_20150330071734.GH23521@phenom.ffwll.local>
2015-03-30 8:18 ` [PATCH] Enable dithering for intel VCH DVO Thomas Richter
2015-03-30 9:41 ` Daniel Vetter
2015-04-01 10:00 ` Jani Nikula
2015-03-27 20:12 ` [PATCH] drm/i915: Check lane sharing between pipes B & C using atomic state shuang.he
2015-03-20 14:18 ` [PATCH 17/20] drm/i915: Convert intel_pipe_will_have_type() to " Ander Conselvan de Oliveira
2015-03-27 9:29 ` Daniel Vetter
2015-03-20 14:18 ` [PATCH 18/20] drm/i915: Don't look at staged config crtc when changing DRRS state Ander Conselvan de Oliveira
2015-03-27 9:32 ` Daniel Vetter
2015-03-20 14:18 ` [PATCH 19/20] drm/i915: Remove usage of encoder->new_crtc from clock computations Ander Conselvan de Oliveira
2015-03-27 9:40 ` Daniel Vetter
2015-03-27 9:43 ` [PATCH v3 00/20] Remove depencies on staged config for atomic transition Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326152748.GF24805@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox