From: Dan Carpenter <dan.carpenter@oracle.com>
To: ander.conselvan.de.oliveira@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: drm/i915: Copy the staged connector config to the legacy atomic state
Date: Fri, 27 Mar 2015 16:15:14 +0300 [thread overview]
Message-ID: <20150327131514.GA9406@mwanda> (raw)
Hello Ander Conselvan de Oliveira,
The patch 944b0c765757: "drm/i915: Copy the staged connector config
to the legacy atomic state" from Mar 20, 2015, leads to the following
Smatch warning:
drivers/gpu/drm/i915/intel_display.c:11937 intel_modeset_stage_output_state()
error: 'connector_state' dereferencing possible ERR_PTR()
drivers/gpu/drm/i915/intel_display.c
11928 /* Now we've also updated encoder->new_crtc for all encoders. */
11929 for_each_intel_connector(dev, connector) {
11930 connector_state =
11931 drm_atomic_get_connector_state(state, &connector->base);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It's complaining that this can return an ERR_PTR.
11932
11933 if (connector->new_encoder) {
11934 if (connector->new_encoder != connector->encoder)
11935 connector->encoder = connector->new_encoder;
11936 } else {
11937 connector_state->crtc = NULL;
11938 }
11939 }
regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-03-27 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 13:15 Dan Carpenter [this message]
2015-03-27 13:33 ` [PATCH] drm/i915: Handle error to get connector state when staging config Ander Conselvan de Oliveira
2015-03-27 14:07 ` Daniel Vetter
2015-03-27 22:28 ` shuang.he
2015-03-27 13:35 ` drm/i915: Copy the staged connector config to the legacy atomic state Ander Conselvan De Oliveira
-- strict thread matches above, loose matches on Subject: below --
2015-03-27 14:36 Dan Carpenter
2015-03-30 7:59 ` Ander Conselvan De Oliveira
2015-03-30 10:50 ` David Weinehall
2015-03-30 11:03 ` Ander Conselvan De Oliveira
2015-03-30 12:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327131514.GA9406@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox