From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Check lane sharing between pipes B & C using atomic state Date: Fri, 27 Mar 2015 15:03:58 +0100 Message-ID: <20150327140357.GV23521@phenom.ffwll.local> References: <20150327090859.GP23521@phenom.ffwll.local> <1427461208-26204-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id B28D16EBA6 for ; Fri, 27 Mar 2015 07:02:12 -0700 (PDT) Received: by wibgn9 with SMTP id gn9so32583389wib.1 for ; Fri, 27 Mar 2015 07:02:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1427461208-26204-1-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMjcsIDIwMTUgYXQgMDM6MDA6MDhQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IE1ha2VzIHRoYXQgY29kZSBhdG9taWMgcmVhZHkuCj4gCj4g djI6IEFjcXVpcmUgY3J0Y19zdGF0ZSBmb3IgdGhlICJvdGhlciIgcGlwZSBvbmx5IHdoZW4gbmVl ZGVkLiAoRGFuaWVsKQo+IFNpZ25lZC1vZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWly YSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNjUgKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAyNiBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXgg ZGM5YTVjMS4uNjhmZThiOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiBAQCAtNTY2OSw2NSArNTY2OSw3OCBAQCBib29sIGludGVsX2Nvbm5lY3Rvcl9nZXRfaHdfc3Rh dGUoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJcmV0dXJuIGVuY29kZXIt PmdldF9od19zdGF0ZShlbmNvZGVyLCAmcGlwZSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgcGlw ZV9yZXF1aXJlZF9mZGlfbGFuZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBp cGUpCj4gK3N0YXRpYyBpbnQgcGlwZV9yZXF1aXJlZF9mZGlfbGFuZXMoc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0K PiAtCQl0b19pbnRlbF9jcnRjKGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRldiwgcGlwZSkpOwo+ IC0KPiAtCWlmIChjcnRjLT5iYXNlLnN0YXRlLT5lbmFibGUgJiYKPiAtCSAgICBjcnRjLT5jb25m aWctPmhhc19wY2hfZW5jb2RlcikKPiAtCQlyZXR1cm4gY3J0Yy0+Y29uZmlnLT5mZGlfbGFuZXM7 Cj4gKwlpZiAoY3J0Y19zdGF0ZS0+YmFzZS5lbmFibGUgJiYgY3J0Y19zdGF0ZS0+aGFzX3BjaF9l bmNvZGVyKQo+ICsJCXJldHVybiBjcnRjX3N0YXRlLT5mZGlfbGFuZXM7Cj4gIAo+ICAJcmV0dXJu IDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBib29sIGlyb25sYWtlX2NoZWNrX2ZkaV9sYW5lcyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUgcGlwZSwKPiArc3RhdGljIGludCBpcm9ubGFr ZV9jaGVja19mZGlfbGFuZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBpcGUs Cj4gIAkJCQkgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiAgewo+ ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gcGlwZV9jb25maWctPmJhc2Uuc3Rh dGU7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqb3RoZXJfY3J0YzsKPiArCXN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpvdGhlcl9jcnRjX3N0YXRlOwo+ICsKPiAgCURSTV9ERUJVR19LTVMoImNoZWNr aW5nIGZkaSBjb25maWcgb24gcGlwZSAlYywgbGFuZXMgJWlcbiIsCj4gIAkJICAgICAgcGlwZV9u YW1lKHBpcGUpLCBwaXBlX2NvbmZpZy0+ZmRpX2xhbmVzKTsKPiAgCWlmIChwaXBlX2NvbmZpZy0+ ZmRpX2xhbmVzID4gNCkgewo+ICAJCURSTV9ERUJVR19LTVMoImludmFsaWQgZmRpIGxhbmUgY29u ZmlnIG9uIHBpcGUgJWM6ICVpIGxhbmVzXG4iLAo+ICAJCQkgICAgICBwaXBlX25hbWUocGlwZSks IHBpcGVfY29uZmlnLT5mZGlfbGFuZXMpOwo+IC0JCXJldHVybiBmYWxzZTsKPiArCQlyZXR1cm4g LUVJTlZBTDsKPiAgCX0KPiAgCj4gIAlpZiAoSVNfSEFTV0VMTChkZXYpIHx8IElTX0JST0FEV0VM TChkZXYpKSB7Cj4gIAkJaWYgKHBpcGVfY29uZmlnLT5mZGlfbGFuZXMgPiAyKSB7Cj4gIAkJCURS TV9ERUJVR19LTVMoIm9ubHkgMiBsYW5lcyBvbiBoYXN3ZWxsLCByZXF1aXJlZDogJWkgbGFuZXNc biIsCj4gIAkJCQkgICAgICBwaXBlX2NvbmZpZy0+ZmRpX2xhbmVzKTsKPiAtCQkJcmV0dXJuIGZh bHNlOwo+ICsJCQlyZXR1cm4gLUVJTlZBTDsKPiAgCQl9IGVsc2Ugewo+IC0JCQlyZXR1cm4gdHJ1 ZTsKPiArCQkJcmV0dXJuIDA7Cj4gIAkJfQo+ICAJfQo+ICAKPiAgCWlmIChJTlRFTF9JTkZPKGRl diktPm51bV9waXBlcyA9PSAyKQo+IC0JCXJldHVybiB0cnVlOwo+ICsJCXJldHVybiAwOwo+ICAK PiAgCS8qIEl2eWJyaWRnZSAzIHBpcGUgaXMgcmVhbGx5IGNvbXBsaWNhdGVkICovCj4gIAlzd2l0 Y2ggKHBpcGUpIHsKPiAgCWNhc2UgUElQRV9BOgo+IC0JCXJldHVybiB0cnVlOwo+ICsJCXJldHVy biAwOwo+ICAJY2FzZSBQSVBFX0I6CgpTaW5jZSB3ZSBib3RoZXIgd2l0aCBhbGwgdGhpcyB0cm91 YmxlIEkgdGhpbmsgYQoKCQlpZiAocGlwZV9jb25maWctPmZkaV9sYW5lcyA8PSAyKQoJCQlyZXR1 cm4gMDsKCmhlcmUgYmVmb3JlIHdlIGFjcXVpcmUgdGhlIG90aGVyIGNydGMgc3RhdGUgYW5kIHRo ZW4gcmVtb3ZpbmcgdGhlIGNoZWNrCmJlbG93IHdvdWxkIGJlIHJlYWxseSBwcmV0dHkuIEp1c3Qg c28gdGhhdCB3ZSByZWFsbHkgb25seSBhY3F1aXJlIHRoZQpvdGhlciBzdGF0ZXMgd2hlbiB3ZSBu ZWVkIHRvIDstKSBsZ3RtIG90aGVyd2lzZS4KLURhbmllbAoKPiArCQlvdGhlcl9jcnRjID0gdG9f aW50ZWxfY3J0YyhpbnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXYsIFBJUEVfQykpOwo+ICsJCW90 aGVyX2NydGNfc3RhdGUgPQo+ICsJCQlpbnRlbF9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUs IG90aGVyX2NydGMpOwo+ICsJCWlmIChJU19FUlIob3RoZXJfY3J0Y19zdGF0ZSkpCj4gKwkJCXJl dHVybiBQVFJfRVJSKG90aGVyX2NydGNfc3RhdGUpOwo+ICsKPiAgCQlpZiAocGlwZV9jb25maWct PmZkaV9sYW5lcyA+IDIgJiYKPiAtCQkgICAgcGlwZV9yZXF1aXJlZF9mZGlfbGFuZXMoZGV2LCBQ SVBFX0MpID4gMCkgewo+ICsJCSAgICBwaXBlX3JlcXVpcmVkX2ZkaV9sYW5lcyhvdGhlcl9jcnRj X3N0YXRlKSA+IDApIHsKPiAgCQkJRFJNX0RFQlVHX0tNUygiaW52YWxpZCBzaGFyZWQgZmRpIGxh bmUgY29uZmlnIG9uIHBpcGUgJWM6ICVpIGxhbmVzXG4iLAo+ICAJCQkJICAgICAgcGlwZV9uYW1l KHBpcGUpLCBwaXBlX2NvbmZpZy0+ZmRpX2xhbmVzKTsKPiAtCQkJcmV0dXJuIGZhbHNlOwo+ICsJ CQlyZXR1cm4gLUVJTlZBTDsKPiAgCQl9Cj4gLQkJcmV0dXJuIHRydWU7Cj4gKwkJcmV0dXJuIDA7 Cj4gIAljYXNlIFBJUEVfQzoKPiAgCQlpZiAocGlwZV9jb25maWctPmZkaV9sYW5lcyA+IDIpIHsK PiAgCQkJRFJNX0RFQlVHX0tNUygib25seSAyIGxhbmVzIG9uIHBpcGUgJWM6IHJlcXVpcmVkICVp IGxhbmVzXG4iLAo+ICAJCQkJICAgICAgcGlwZV9uYW1lKHBpcGUpLCBwaXBlX2NvbmZpZy0+ZmRp X2xhbmVzKTsKPiAtCQkJcmV0dXJuIGZhbHNlOwo+ICsJCQlyZXR1cm4gLUVJTlZBTDsKPiAgCQl9 Cj4gLQkJaWYgKHBpcGVfcmVxdWlyZWRfZmRpX2xhbmVzKGRldiwgUElQRV9CKSA+IDIpIHsKPiAr Cj4gKwkJb3RoZXJfY3J0YyA9IHRvX2ludGVsX2NydGMoaW50ZWxfZ2V0X2NydGNfZm9yX3BpcGUo ZGV2LCBQSVBFX0IpKTsKPiArCQlvdGhlcl9jcnRjX3N0YXRlID0KPiArCQkJaW50ZWxfYXRvbWlj X2dldF9jcnRjX3N0YXRlKHN0YXRlLCBvdGhlcl9jcnRjKTsKPiArCQlpZiAoSVNfRVJSKG90aGVy X2NydGNfc3RhdGUpKQo+ICsJCQlyZXR1cm4gUFRSX0VSUihvdGhlcl9jcnRjX3N0YXRlKTsKPiAr Cj4gKwkJaWYgKHBpcGVfcmVxdWlyZWRfZmRpX2xhbmVzKG90aGVyX2NydGNfc3RhdGUpID4gMikg ewo+ICAJCQlEUk1fREVCVUdfS01TKCJmZGkgbGluayBCIHVzZXMgdG9vIG1hbnkgbGFuZXMgdG8g ZW5hYmxlIGxpbmsgQ1xuIik7Cj4gLQkJCXJldHVybiBmYWxzZTsKPiArCQkJcmV0dXJuIC1FSU5W QUw7Cj4gIAkJfQo+IC0JCXJldHVybiB0cnVlOwo+ICsJCXJldHVybiAwOwo+ICAJZGVmYXVsdDoK PiAgCQlCVUcoKTsKPiAgCX0KPiBAQCAtNTczOSw4ICs1NzUyLDggQEAgc3RhdGljIGludCBpcm9u bGFrZV9mZGlfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4g IHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5iYXNlLmRldjsKPiAg CXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlID0gJnBpcGVfY29uZmlnLT5i YXNlLmFkanVzdGVkX21vZGU7Cj4gLQlpbnQgbGFuZSwgbGlua19idywgZmRpX2RvdGNsb2NrOwo+ IC0JYm9vbCBzZXR1cF9vaywgbmVlZHNfcmVjb21wdXRlID0gZmFsc2U7Cj4gKwlpbnQgbGFuZSwg bGlua19idywgZmRpX2RvdGNsb2NrLCByZXQ7Cj4gKwlib29sIG5lZWRzX3JlY29tcHV0ZSA9IGZh bHNlOwo+ICAKPiAgcmV0cnk6Cj4gIAkvKiBGREkgaXMgYSBiaW5hcnkgc2lnbmFsIHJ1bm5pbmcg YXQgfjIuN0dIeiwgZW5jb2RpbmcKPiBAQCAtNTc2Miw5ICs1Nzc1LDkgQEAgcmV0cnk6Cj4gIAlp bnRlbF9saW5rX2NvbXB1dGVfbV9uKHBpcGVfY29uZmlnLT5waXBlX2JwcCwgbGFuZSwgZmRpX2Rv dGNsb2NrLAo+ICAJCQkgICAgICAgbGlua19idywgJnBpcGVfY29uZmlnLT5mZGlfbV9uKTsKPiAg Cj4gLQlzZXR1cF9vayA9IGlyb25sYWtlX2NoZWNrX2ZkaV9sYW5lcyhpbnRlbF9jcnRjLT5iYXNl LmRldiwKPiAtCQkJCQkgICAgaW50ZWxfY3J0Yy0+cGlwZSwgcGlwZV9jb25maWcpOwo+IC0JaWYg KCFzZXR1cF9vayAmJiBwaXBlX2NvbmZpZy0+cGlwZV9icHAgPiA2KjMpIHsKPiArCXJldCA9IGly b25sYWtlX2NoZWNrX2ZkaV9sYW5lcyhpbnRlbF9jcnRjLT5iYXNlLmRldiwKPiArCQkJCSAgICAg ICBpbnRlbF9jcnRjLT5waXBlLCBwaXBlX2NvbmZpZyk7Cj4gKwlpZiAocmV0ID09IC1FSU5WQUwg JiYgcGlwZV9jb25maWctPnBpcGVfYnBwID4gNiozKSB7Cj4gIAkJcGlwZV9jb25maWctPnBpcGVf YnBwIC09IDIqMzsKPiAgCQlEUk1fREVCVUdfS01TKCJmZGkgbGluayBidyBjb25zdHJhaW50LCBy ZWR1Y2luZyBwaXBlIGJwcCB0byAlaVxuIiwKPiAgCQkJICAgICAgcGlwZV9jb25maWctPnBpcGVf YnBwKTsKPiBAQCAtNTc3Nyw3ICs1NzkwLDcgQEAgcmV0cnk6Cj4gIAlpZiAobmVlZHNfcmVjb21w dXRlKQo+ICAJCXJldHVybiBSRVRSWTsKPiAgCj4gLQlyZXR1cm4gc2V0dXBfb2sgPyAwIDogLUVJ TlZBTDsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGhzd19jb21wdXRl X2lwc19jb25maWcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gLS0gCj4gMi4xLjAKPiAKCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=