From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/5] drm/i915: index gmbus tables using the
 pin pair number
Date: Fri, 27 Mar 2015 17:00:10 +0200
Message-ID: <20150327150010.GB17410@intel.com>
References: <cover.1427407523.git.jani.nikula@intel.com>
 <01911933a007a850dcfd2c618e5d908ba079f866.1427407523.git.jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 670976EBCD
 for <intel-gfx@lists.freedesktop.org>; Fri, 27 Mar 2015 08:00:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <01911933a007a850dcfd2c618e5d908ba079f866.1427407523.git.jani.nikula@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMjcsIDIwMTUgYXQgMTI6MjA6MjFBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gSW5kZXggdGhlIGdtYnVzIHRhYmxlcyBkaXJlY3RseSB1c2luZyB0aGUgcGluIGluc3Rl
YWQgb2YgaGF2aW5nIGEKPiBjb25mdXNpbmcgInBvcnQgPSBpICsgMSIgbWFwcGluZy4gVGhpcyBm
aW5pc2hlcyBvZmYgcmVtb3ZpbmcgdGhlICJnbWJ1cwo+IHBvcnQiIGFzIGEgbm90aW9uLCBhbmQg
bGVhdmVzIHVzIHdpdGgganVzdCB0aGUgImdtYnVzIHBpbiIuCj4gCj4gQXMgcGluIDAgaXMgaW52
YWxpZCBieSBkZWZpbml0aW9uIGFuZCB0aGUgZ21idXMgdGFibGVzIHdpbGwgaGF2ZSBhIGdhcAo+
IGF0IHRoYXQgaW5kZXgsIGFkZCBwaW4gdmFsaWRpdHkgY2hlY2sgdG8gYWxsIHRoZSBsb29wcy4g
VGhpcyB3aWxsIGJlCj4gYmVuZWZpdGlhbCBmb3Igc3VwcG9ydGluZyBwbGF0Zm9ybXMgdGhhdCBo
YXZlIGRpZmZlcmVudCBudW1iZXJzIG9mIHBpbnMsCj4gb3IgZ2Fwcy4KPiAKPiBTaWduZWQtb2Zm
LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICB8ICAzICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfcmVnLmggIHwgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMg
fCA2NSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIDMgZmlsZXMg
Y2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2Rydi5oCj4gaW5kZXggM2JhNWRlMTllMDM5Li4wYzYwMjQxMDFlYjkgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTU3NCw4ICsxNTc0LDcgQEAgc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgewo+ICAKPiAgCXN0cnVjdCBpOTE1X3ZpcnR1YWxfZ3B1IHZncHU7Cj4gIAo+
IC0Jc3RydWN0IGludGVsX2dtYnVzIGdtYnVzW0dNQlVTX05VTV9QT1JUU107Cj4gLQo+ICsJc3Ry
dWN0IGludGVsX2dtYnVzIGdtYnVzW0dNQlVTX1BJTl9NQVhdOwo+ICAKPiAgCS8qKiBnbWJ1c19t
dXRleCBwcm90ZWN0cyBhZ2FpbnN0IGNvbmN1cnJlbnQgdXNhZ2Ugb2YgdGhlIHNpbmdsZSBodyBn
bWJ1cwo+ICAJICogY29udHJvbGxlciBvbiBkaWZmZXJlbnQgaTJjIGJ1c2VzLiAqLwo+IGRpZmYg
LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IGI2MTEzYzlhODAzYi4uY2RjMDcxY2ZmMDAxIDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTE3OTcsNyArMTc5Nyw3IEBAIGVudW0gc2ts
X2Rpc3BfcG93ZXJfd2VsbHMgewo+ICAjZGVmaW5lICAgR01CVVNfUElOX0RQQgkJNSAvKiBTRFZP
LCBIRE1JQiAqLwo+ICAjZGVmaW5lICAgR01CVVNfUElOX0RQRAkJNiAvKiBIRE1JRCAqLwo+ICAj
ZGVmaW5lICAgR01CVVNfUElOX1JFU0VSVkVECTcgLyogNyByZXNlcnZlZCAqLwo+IC0jZGVmaW5l
ICAgR01CVVNfTlVNX1BPUlRTCShHTUJVU19QSU5fRFBEIC0gR01CVVNfUElOX1NTQyArIDEpCj4g
KyNkZWZpbmUgICBHTUJVU19QSU5fTUFYCQk3IC8qIG5vdCBpbmNsdXNpdmUgKi8KClBJTl9NQVgg
bWFrZXMgbWUgdGhpbmsgaXQncyBpbmNsdXNpdmUuIE5VTV9QSU5TIG1heWJlPwoKdy8gb3Igdy9v
IHRoYXQgcGFydGljdWxhciBiaWtlc2hlZCBwYXRjaGVzIDEtNCBsb29rIGZpbmUgdG8gbWUsIHNv
OgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs
LmNvbT4KCj4gICNkZWZpbmUgR01CVVMxCQkJMHg1MTA0IC8qIGNvbW1hbmQvc3RhdHVzICovCj4g
ICNkZWZpbmUgICBHTUJVU19TV19DTFJfSU5UCSgxPDwzMSkKPiAgI2RlZmluZSAgIEdNQlVTX1NX
X1JEWQkJKDE8PDMwKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9p
MmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jCj4gaW5kZXggYjAwMDNhMmJk
ODU0Li5mZjQ3YThmZGNiNmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfaTJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMuYwo+IEBAIC0z
NCwxOCArMzQsMTkgQEAKPiAgI2luY2x1ZGUgPGRybS9pOTE1X2RybS5oPgo+ICAjaW5jbHVkZSAi
aTkxNV9kcnYuaCIKPiAgCj4gLXN0cnVjdCBnbWJ1c19wb3J0IHsKPiArc3RydWN0IGdtYnVzX3Bp
biB7Cj4gIAljb25zdCBjaGFyICpuYW1lOwo+ICAJaW50IHJlZzsKPiAgfTsKPiAgCj4gLXN0YXRp
YyBjb25zdCBzdHJ1Y3QgZ21idXNfcG9ydCBnbWJ1c19wb3J0c1tdID0gewo+IC0JeyAic3NjIiwg
R1BJT0IgfSwKPiAtCXsgInZnYSIsIEdQSU9BIH0sCj4gLQl7ICJwYW5lbCIsIEdQSU9DIH0sCj4g
LQl7ICJkcGMiLCBHUElPRCB9LAo+IC0JeyAiZHBiIiwgR1BJT0UgfSwKPiAtCXsgImRwZCIsIEdQ
SU9GIH0sCj4gKy8qIE1hcCBnbWJ1cyBwaW4gcGFpcnMgdG8gbmFtZXMgYW5kIHJlZ2lzdGVycy4g
Ki8KPiArc3RhdGljIGNvbnN0IHN0cnVjdCBnbWJ1c19waW4gZ21idXNfcGluc1tdID0gewo+ICsJ
W0dNQlVTX1BJTl9TU0NdID0geyAic3NjIiwgR1BJT0IgfSwKPiArCVtHTUJVU19QSU5fVkdBRERD
XSA9IHsgInZnYSIsIEdQSU9BIH0sCj4gKwlbR01CVVNfUElOX1BBTkVMXSA9IHsgInBhbmVsIiwg
R1BJT0MgfSwKPiArCVtHTUJVU19QSU5fRFBDXSA9IHsgImRwYyIsIEdQSU9EIH0sCj4gKwlbR01C
VVNfUElOX0RQQl0gPSB7ICJkcGIiLCBHUElPRSB9LAo+ICsJW0dNQlVTX1BJTl9EUERdID0geyAi
ZHBkIiwgR1BJT0YgfSwKPiAgfTsKPiAgCj4gIC8qIEludGVsIEdQSU8gYWNjZXNzIGZ1bmN0aW9u
cyAqLwo+IEBAIC0xODIsMTUgKzE4MywxNCBAQCBpbnRlbF9ncGlvX3Bvc3RfeGZlcihzdHJ1Y3Qg
aTJjX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkCj4gLWludGVsX2dw
aW9fc2V0dXAoc3RydWN0IGludGVsX2dtYnVzICpidXMsIHUzMiBwaW4pCj4gK2ludGVsX2dwaW9f
c2V0dXAoc3RydWN0IGludGVsX2dtYnVzICpidXMsIHVuc2lnbmVkIGludCBwaW4pCj4gIHsKPiAg
CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGJ1cy0+ZGV2X3ByaXY7Cj4gIAlz
dHJ1Y3QgaTJjX2FsZ29fYml0X2RhdGEgKmFsZ287Cj4gIAo+ICAJYWxnbyA9ICZidXMtPmJpdF9h
bGdvOwo+ICAKPiAtCS8qIC0xIHRvIG1hcCBwaW4gcGFpciB0byBnbWJ1cyBpbmRleCAqLwo+IC0J
YnVzLT5ncGlvX3JlZyA9IGRldl9wcml2LT5ncGlvX21taW9fYmFzZSArIGdtYnVzX3BvcnRzW3Bp
biAtIDFdLnJlZzsKPiArCWJ1cy0+Z3Bpb19yZWcgPSBkZXZfcHJpdi0+Z3Bpb19tbWlvX2Jhc2Ug
KyBnbWJ1c19waW5zW3Bpbl0ucmVnOwo+ICAKPiAgCWJ1cy0+YWRhcHRlci5hbGdvX2RhdGEgPSBh
bGdvOwo+ICAJYWxnby0+c2V0c2RhID0gc2V0X2RhdGE7Cj4gQEAgLTUxNyw3ICs1MTcsOSBAQCBz
dGF0aWMgY29uc3Qgc3RydWN0IGkyY19hbGdvcml0aG0gZ21idXNfYWxnb3JpdGhtID0gewo+ICBp
bnQgaW50ZWxfc2V0dXBfZ21idXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+ICAJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCWlu
dCByZXQsIGk7Cj4gKwlzdHJ1Y3QgaW50ZWxfZ21idXMgKmJ1czsKPiArCXVuc2lnbmVkIGludCBw
aW47Cj4gKwlpbnQgcmV0Owo+ICAKPiAgCWlmIChIQVNfUENIX05PUChkZXYpKQo+ICAJCXJldHVy
biAwOwo+IEBAIC01MzEsMTYgKzUzMywxOCBAQCBpbnQgaW50ZWxfc2V0dXBfZ21idXMoc3RydWN0
IGRybV9kZXZpY2UgKmRldikKPiAgCW11dGV4X2luaXQoJmRldl9wcml2LT5nbWJ1c19tdXRleCk7
Cj4gIAlpbml0X3dhaXRxdWV1ZV9oZWFkKCZkZXZfcHJpdi0+Z21idXNfd2FpdF9xdWV1ZSk7Cj4g
IAo+IC0JZm9yIChpID0gMDsgaSA8IEdNQlVTX05VTV9QT1JUUzsgaSsrKSB7Cj4gLQkJc3RydWN0
IGludGVsX2dtYnVzICpidXMgPSAmZGV2X3ByaXYtPmdtYnVzW2ldOwo+IC0JCXUzMiBwb3J0ID0g
aSArIDE7IC8qICsxIHRvIG1hcCBnbWJ1cyBpbmRleCB0byBwaW4gcGFpciAqLwo+ICsJZm9yIChw
aW4gPSAwOyBwaW4gPCBBUlJBWV9TSVpFKGRldl9wcml2LT5nbWJ1cyk7IHBpbisrKSB7Cj4gKwkJ
aWYgKCFpbnRlbF9nbWJ1c19pc192YWxpZF9waW4ocGluKSkKPiArCQkJY29udGludWU7Cj4gKwo+
ICsJCWJ1cyA9ICZkZXZfcHJpdi0+Z21idXNbcGluXTsKPiAgCj4gIAkJYnVzLT5hZGFwdGVyLm93
bmVyID0gVEhJU19NT0RVTEU7Cj4gIAkJYnVzLT5hZGFwdGVyLmNsYXNzID0gSTJDX0NMQVNTX0RE
QzsKPiAgCQlzbnByaW50ZihidXMtPmFkYXB0ZXIubmFtZSwKPiAgCQkJIHNpemVvZihidXMtPmFk
YXB0ZXIubmFtZSksCj4gIAkJCSAiaTkxNSBnbWJ1cyAlcyIsCj4gLQkJCSBnbWJ1c19wb3J0c1tp
XS5uYW1lKTsKPiArCQkJIGdtYnVzX3BpbnNbcGluXS5uYW1lKTsKPiAgCj4gIAkJYnVzLT5hZGFw
dGVyLmRldi5wYXJlbnQgPSAmZGV2LT5wZGV2LT5kZXY7Cj4gIAkJYnVzLT5kZXZfcHJpdiA9IGRl
dl9wcml2Owo+IEBAIC01NDgsMTMgKzU1MiwxMyBAQCBpbnQgaW50ZWxfc2V0dXBfZ21idXMoc3Ry
dWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlidXMtPmFkYXB0ZXIuYWxnbyA9ICZnbWJ1c19hbGdv
cml0aG07Cj4gIAo+ICAJCS8qIEJ5IGRlZmF1bHQgdXNlIGEgY29uc2VydmF0aXZlIGNsb2NrIHJh
dGUgKi8KPiAtCQlidXMtPnJlZzAgPSBwb3J0IHwgR01CVVNfUkFURV8xMDBLSFo7Cj4gKwkJYnVz
LT5yZWcwID0gcGluIHwgR01CVVNfUkFURV8xMDBLSFo7Cj4gIAo+ICAJCS8qIGdtYnVzIHNlZW1z
IHRvIGJlIGJyb2tlbiBvbiBpODMwICovCj4gIAkJaWYgKElTX0k4MzAoZGV2KSkKPiAgCQkJYnVz
LT5mb3JjZV9iaXQgPSAxOwo+ICAKPiAtCQlpbnRlbF9ncGlvX3NldHVwKGJ1cywgcG9ydCk7Cj4g
KwkJaW50ZWxfZ3Bpb19zZXR1cChidXMsIHBpbik7Cj4gIAo+ICAJCXJldCA9IGkyY19hZGRfYWRh
cHRlcigmYnVzLT5hZGFwdGVyKTsKPiAgCQlpZiAocmV0KQo+IEBAIC01NjYsOCArNTcwLDExIEBA
IGludCBpbnRlbF9zZXR1cF9nbWJ1cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJcmV0dXJu
IDA7Cj4gIAo+ICBlcnI6Cj4gLQl3aGlsZSAoLS1pKSB7Cj4gLQkJc3RydWN0IGludGVsX2dtYnVz
ICpidXMgPSAmZGV2X3ByaXYtPmdtYnVzW2ldOwo+ICsJd2hpbGUgKC0tcGluKSB7Cj4gKwkJaWYg
KCFpbnRlbF9nbWJ1c19pc192YWxpZF9waW4ocGluKSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJ
CWJ1cyA9ICZkZXZfcHJpdi0+Z21idXNbcGluXTsKPiAgCQlpMmNfZGVsX2FkYXB0ZXIoJmJ1cy0+
YWRhcHRlcik7Cj4gIAl9Cj4gIAlyZXR1cm4gcmV0Owo+IEBAIC01NzYsMTAgKzU4MywxMCBAQCBl
cnI6Cj4gIHN0cnVjdCBpMmNfYWRhcHRlciAqaW50ZWxfZ21idXNfZ2V0X2FkYXB0ZXIoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJCSAgICB1bnNpZ25lZCBpbnQgcGlu
KQo+ICB7Cj4gLQlXQVJOX09OKCFpbnRlbF9nbWJ1c19pc192YWxpZF9waW4ocGluKSk7Cj4gLQkv
KiAtMSB0byBtYXAgcGluIHBhaXIgdG8gZ21idXMgaW5kZXggKi8KPiAtCXJldHVybiAoaW50ZWxf
Z21idXNfaXNfdmFsaWRfcGluKHBpbikpID8KPiAtCQkmZGV2X3ByaXYtPmdtYnVzW3BpbiAtIDFd
LmFkYXB0ZXIgOiBOVUxMOwo+ICsJaWYgKFdBUk5fT04oIWludGVsX2dtYnVzX2lzX3ZhbGlkX3Bp
bihwaW4pKSkKPiArCQlyZXR1cm4gTlVMTDsKPiArCj4gKwlyZXR1cm4gJmRldl9wcml2LT5nbWJ1
c1twaW5dLmFkYXB0ZXI7Cj4gIH0KPiAgCj4gIHZvaWQgaW50ZWxfZ21idXNfc2V0X3NwZWVkKHN0
cnVjdCBpMmNfYWRhcHRlciAqYWRhcHRlciwgaW50IHNwZWVkKQo+IEBAIC02MDIsMTAgKzYwOSwx
NCBAQCB2b2lkIGludGVsX2dtYnVzX2ZvcmNlX2JpdChzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmFkYXB0
ZXIsIGJvb2wgZm9yY2VfYml0KQo+ICB2b2lkIGludGVsX3RlYXJkb3duX2dtYnVzKHN0cnVjdCBk
cm1fZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
diA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gLQlpbnQgaTsKPiArCXN0cnVjdCBpbnRlbF9nbWJ1cyAq
YnVzOwo+ICsJdW5zaWduZWQgaW50IHBpbjsKPiArCj4gKwlmb3IgKHBpbiA9IDA7IHBpbiA8IEFS
UkFZX1NJWkUoZGV2X3ByaXYtPmdtYnVzKTsgcGluKyspIHsKPiArCQlpZiAoIWludGVsX2dtYnVz
X2lzX3ZhbGlkX3BpbihwaW4pKQo+ICsJCQljb250aW51ZTsKPiAgCj4gLQlmb3IgKGkgPSAwOyBp
IDwgR01CVVNfTlVNX1BPUlRTOyBpKyspIHsKPiAtCQlzdHJ1Y3QgaW50ZWxfZ21idXMgKmJ1cyA9
ICZkZXZfcHJpdi0+Z21idXNbaV07Cj4gKwkJYnVzID0gJmRldl9wcml2LT5nbWJ1c1twaW5dOwo+
ICAJCWkyY19kZWxfYWRhcHRlcigmYnVzLT5hZGFwdGVyKTsKPiAgCX0KPiAgfQo+IC0tIAo+IDIu
MS40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y
Zwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==