From: Gustavo Padovan <gustavo@padovan.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Thierry Reding <thierry.reding@gmail.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atomic-helpers: Properly avoid full modeset dance
Date: Fri, 27 Mar 2015 12:38:27 -0300 [thread overview]
Message-ID: <20150327153827.GA25088@joana> (raw)
In-Reply-To: <1427464031-4863-1-git-send-email-daniel.vetter@ffwll.ch>
2015-03-27 Daniel Vetter <daniel.vetter@ffwll.ch>:
> Legacy setCrtc has a nice fastpath for just updating the frontbuffer
> when the output routing doesn't change. Which I of course tried to
> keep working, except that I fumbled the job: The helpers correctly
> compute ->mode_changed, CRTC updates get correctly skipped but
> connector functions are called unconditionally.
>
> Fix this.
>
> v2: For the disable sided connector->state->crtc might be NULL.
> Instead look at the old_connector_state->crtc, but still use the new
> crtc state for that old crtc. Reported by Thierry.
>
> Reported-and-Tested-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> (v1)
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> (v1)
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
v2 still works for me. You can also add my r-b to v2.
Gustavo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-27 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 13:47 [PATCH] drm/atomic-helpers: Properly avoid full modeset dance Daniel Vetter
2015-03-27 15:38 ` Gustavo Padovan [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-26 21:48 Daniel Vetter
2015-03-27 3:59 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327153827.GA25088@joana \
--to=gustavo@padovan.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox