From: Daniel Vetter <daniel@ffwll.ch>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Set best_encoder field of connector_state also when disabling
Date: Tue, 31 Mar 2015 15:26:44 +0200 [thread overview]
Message-ID: <20150331132644.GL6354@phenom.ffwll.local> (raw)
In-Reply-To: <1427790900-11163-1-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Tue, Mar 31, 2015 at 11:35:00AM +0300, Ander Conselvan de Oliveira wrote:
> The best_encoder field of connector_state wasn't properly set when a
> connector was being disabled, leading to an incosistent atomic state.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
How does this typically blow up, i.e. commit message is a bit too terse
imo. Still, applied to dinf for now.
Thanks, Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a693129..307c43b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12009,6 +12009,7 @@ intel_modeset_stage_output_state(struct drm_device *dev,
> connector->encoder = connector->new_encoder;
> } else {
> connector_state->crtc = NULL;
> + connector_state->best_encoder = NULL;
> }
> }
> for_each_intel_crtc(dev, crtc) {
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-31 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 8:35 [PATCH] drm/i915: Set best_encoder field of connector_state also when disabling Ander Conselvan de Oliveira
2015-03-31 13:26 ` Daniel Vetter [this message]
2015-04-01 8:17 ` Ander Conselvan De Oliveira
2015-04-01 12:16 ` Daniel Vetter
2015-03-31 20:40 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331132644.GL6354@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox