From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 4/5] drm/i915: base gmbus pin validity check
 on the gmbus pin map array
Date: Wed, 1 Apr 2015 14:12:18 +0200
Message-ID: <20150401121218.GA6354@phenom.ffwll.local>
References: <cover.1427407523.git.jani.nikula@intel.com>
 <eb726b3ea13962cbe2f082f87fe05b8ed6e2fd78.1427407523.git.jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53])
 by gabe.freedesktop.org (Postfix) with ESMTP id EF43289CF9
 for <intel-gfx@lists.freedesktop.org>; Wed,  1 Apr 2015 05:10:29 -0700 (PDT)
Received: by wgra20 with SMTP id a20so50968533wgr.3
 for <intel-gfx@lists.freedesktop.org>; Wed, 01 Apr 2015 05:10:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <eb726b3ea13962cbe2f082f87fe05b8ed6e2fd78.1427407523.git.jani.nikula@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMjcsIDIwMTUgYXQgMTI6MjA6MjJBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gVGhpcyB3aWxsIGJlIGhlbHBmdWwgZm9yIGFkZGluZyBmdXR1cmUgcGxhdGZvcm1zLiBJ
dCBpcyBiZXR0ZXIgdG8ga2VlcAo+IHRoZSBpbmZvcm1hdGlvbiBpbiB0aGUgc2luZ2xlIHBvaW50
IG9mIHRydXRoICh0aGUgdGFibGUpIGluc3RlYWQgb2YKPiBkdXBsaWNhdGluZyBpdCBpbnRvIHRo
ZSB2YWxpZGl0eSBmdW5jdGlvbi4KPiAKPiBXaGlsZSBhdCBpdCwgYWRkIGRldl9wcml2IHBhcmFt
ZXRlciB0byB0aGUgZnVuY3Rpb24sIGFsc28gdG8gcHJlcGFyZSBmb3IKPiBhZGRpbmcgZnV0dXJl
IHBsYXRmb3JtIHN1cHBvcnQuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmku
bmlrdWxhQGludGVsLmNvbT4KCk1lcmdlZCB1cCB0byB0aGlzIHBhdGNoLCB0aGFua3MuCi1EYW5p
ZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICB8ICA2ICsrLS0t
LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCAgMiArLQo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8uYyAgfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9pMmMuYyAgfCAxNCArKysrKysrKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9sdmRzLmMgfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZv
LmMgfCAgMyArKy0KPiAgNiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMiBkZWxl
dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu
aCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCAwYzYwMjQxMDFlYjku
LmExYmE5YmVjOGE2YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry
di5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zMDQ4LDEw
ICszMDQ4LDggQEAgdm9pZCBpOTE1X3RlYXJkb3duX3N5c2ZzKHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXZfcHJpdik7Cj4gIC8qIGludGVsX2kyYy5jICovCj4gIGV4dGVybiBpbnQgaW50ZWxfc2V0dXBf
Z21idXMoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIGV4dGVybiB2b2lkIGludGVsX3RlYXJk
b3duX2dtYnVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+IC1zdGF0aWMgaW5saW5lIGJvb2wg
aW50ZWxfZ21idXNfaXNfdmFsaWRfcGluKHVuc2lnbmVkIGludCBwaW4pCj4gLXsKPiAtCXJldHVy
biAocGluID49IEdNQlVTX1BJTl9TU0MgJiYgcGluIDw9IEdNQlVTX1BJTl9EUEQpOwo+IC19Cj4g
K2V4dGVybiBib29sIGludGVsX2dtYnVzX2lzX3ZhbGlkX3BpbihzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgICAgIHVuc2lnbmVkIGludCBwaW4pOwo+ICAKPiAgZXh0
ZXJuIHN0cnVjdCBpMmNfYWRhcHRlciAqCj4gIGludGVsX2dtYnVzX2dldF9hZGFwdGVyKHN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdW5zaWduZWQgaW50IHBpbik7Cj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IDMzM2Y0MDc5MzQzNS4uYWQyZjNiMGQ5MjJmIDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC00MzgsNyArNDM4LDcgQEAgcGFy
c2VfZ2VuZXJhbF9kZWZpbml0aW9ucyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
Cj4gIAkJaWYgKGJsb2NrX3NpemUgPj0gc2l6ZW9mKCpnZW5lcmFsKSkgewo+ICAJCQlpbnQgYnVz
X3BpbiA9IGdlbmVyYWwtPmNydF9kZGNfZ21idXNfcGluOwo+ICAJCQlEUk1fREVCVUdfS01TKCJj
cnRfZGRjX2J1c19waW46ICVkXG4iLCBidXNfcGluKTsKPiAtCQkJaWYgKGludGVsX2dtYnVzX2lz
X3ZhbGlkX3BpbihidXNfcGluKSkKPiArCQkJaWYgKGludGVsX2dtYnVzX2lzX3ZhbGlkX3Bpbihk
ZXZfcHJpdiwgYnVzX3BpbikpCj4gIAkJCQlkZXZfcHJpdi0+dmJ0LmNydF9kZGNfcGluID0gYnVz
X3BpbjsKPiAgCQl9IGVsc2Ugewo+ICAJCQlEUk1fREVCVUdfS01TKCJCREJfR0QgdG9vIHNtYWxs
ICglZCkuIEludmFsaWQuXG4iLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kdm8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2R2by5jCj4gaW5kZXggOGQ2
MjI3MmEzNDIxLi45NjcwZTM4MDI5MzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZHZvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8uYwo+
IEBAIC01MDAsNyArNTAwLDcgQEAgdm9pZCBpbnRlbF9kdm9faW5pdChzdHJ1Y3QgZHJtX2Rldmlj
ZSAqZGV2KQo+ICAJCSAqIHNwZWNpYWwgY2FzZXMsIGJ1dCBvdGhlcndpc2UgZGVmYXVsdCB0byB3
aGF0J3MgZGVmaW5lZAo+ICAJCSAqIGluIHRoZSBzcGVjLgo+ICAJCSAqLwo+IC0JCWlmIChpbnRl
bF9nbWJ1c19pc192YWxpZF9waW4oZHZvLT5ncGlvKSkKPiArCQlpZiAoaW50ZWxfZ21idXNfaXNf
dmFsaWRfcGluKGRldl9wcml2LCBkdm8tPmdwaW8pKQo+ICAJCQlncGlvID0gZHZvLT5ncGlvOwo+
ICAJCWVsc2UgaWYgKGR2by0+dHlwZSA9PSBJTlRFTF9EVk9fQ0hJUF9MVkRTKQo+ICAJCQlncGlv
ID0gR01CVVNfUElOX1NTQzsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfaTJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMuYwo+IGluZGV4IGZmNDdh
OGZkY2I2ZC4uZWM5Y2M4Y2Y2NDJlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2kyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMKPiBA
QCAtNDksNiArNDksMTIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBnbWJ1c19waW4gZ21idXNfcGlu
c1tdID0gewo+ICAJW0dNQlVTX1BJTl9EUERdID0geyAiZHBkIiwgR1BJT0YgfSwKPiAgfTsKPiAg
Cj4gK2Jvb2wgaW50ZWxfZ21idXNfaXNfdmFsaWRfcGluKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl
ICpkZXZfcHJpdiwKPiArCQkJICAgICAgdW5zaWduZWQgaW50IHBpbikKPiArewo+ICsJcmV0dXJu
IHBpbiA8IEFSUkFZX1NJWkUoZ21idXNfcGlucykgJiYgZ21idXNfcGluc1twaW5dLnJlZzsKPiAr
fQo+ICsKPiAgLyogSW50ZWwgR1BJTyBhY2Nlc3MgZnVuY3Rpb25zICovCj4gIAo+ICAjZGVmaW5l
IEkyQ19SSVNFRkFMTF9USU1FIDEwCj4gQEAgLTUzNCw3ICs1NDAsNyBAQCBpbnQgaW50ZWxfc2V0
dXBfZ21idXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWluaXRfd2FpdHF1ZXVlX2hlYWQo
JmRldl9wcml2LT5nbWJ1c193YWl0X3F1ZXVlKTsKPiAgCj4gIAlmb3IgKHBpbiA9IDA7IHBpbiA8
IEFSUkFZX1NJWkUoZGV2X3ByaXYtPmdtYnVzKTsgcGluKyspIHsKPiAtCQlpZiAoIWludGVsX2dt
YnVzX2lzX3ZhbGlkX3BpbihwaW4pKQo+ICsJCWlmICghaW50ZWxfZ21idXNfaXNfdmFsaWRfcGlu
KGRldl9wcml2LCBwaW4pKQo+ICAJCQljb250aW51ZTsKPiAgCj4gIAkJYnVzID0gJmRldl9wcml2
LT5nbWJ1c1twaW5dOwo+IEBAIC01NzEsNyArNTc3LDcgQEAgaW50IGludGVsX3NldHVwX2dtYnVz
KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAo+ICBlcnI6Cj4gIAl3aGlsZSAoLS1waW4pIHsK
PiAtCQlpZiAoIWludGVsX2dtYnVzX2lzX3ZhbGlkX3BpbihwaW4pKQo+ICsJCWlmICghaW50ZWxf
Z21idXNfaXNfdmFsaWRfcGluKGRldl9wcml2LCBwaW4pKQo+ICAJCQljb250aW51ZTsKPiAgCj4g
IAkJYnVzID0gJmRldl9wcml2LT5nbWJ1c1twaW5dOwo+IEBAIC01ODMsNyArNTg5LDcgQEAgZXJy
Ogo+ICBzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmludGVsX2dtYnVzX2dldF9hZGFwdGVyKHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCQkgICAgdW5zaWduZWQgaW50IHBpbikK
PiAgewo+IC0JaWYgKFdBUk5fT04oIWludGVsX2dtYnVzX2lzX3ZhbGlkX3BpbihwaW4pKSkKPiAr
CWlmIChXQVJOX09OKCFpbnRlbF9nbWJ1c19pc192YWxpZF9waW4oZGV2X3ByaXYsIHBpbikpKQo+
ICAJCXJldHVybiBOVUxMOwo+ICAKPiAgCXJldHVybiAmZGV2X3ByaXYtPmdtYnVzW3Bpbl0uYWRh
cHRlcjsKPiBAQCAtNjEzLDcgKzYxOSw3IEBAIHZvaWQgaW50ZWxfdGVhcmRvd25fZ21idXMoc3Ry
dWN0IGRybV9kZXZpY2UgKmRldikKPiAgCXVuc2lnbmVkIGludCBwaW47Cj4gIAo+ICAJZm9yIChw
aW4gPSAwOyBwaW4gPCBBUlJBWV9TSVpFKGRldl9wcml2LT5nbWJ1cyk7IHBpbisrKSB7Cj4gLQkJ
aWYgKCFpbnRlbF9nbWJ1c19pc192YWxpZF9waW4ocGluKSkKPiArCQlpZiAoIWludGVsX2dtYnVz
X2lzX3ZhbGlkX3BpbihkZXZfcHJpdiwgcGluKSkKPiAgCQkJY29udGludWU7Cj4gIAo+ICAJCWJ1
cyA9ICZkZXZfcHJpdi0+Z21idXNbcGluXTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfbHZkcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4g
aW5kZXggZDYxYWE3OGVkN2UzLi4zMTRhNWQ1NmFjZTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfbHZkcy5jCj4gQEAgLTc4MSw3ICs3ODEsNyBAQCBzdGF0aWMgYm9vbCBsdmRzX2lzX3ByZXNl
bnRfaW5fdmJ0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJICAgIGNoaWxkLT5kZXZpY2Vf
dHlwZSAhPSBERVZJQ0VfVFlQRV9MRlApCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAtCQlpZiAoaW50
ZWxfZ21idXNfaXNfdmFsaWRfcGluKGNoaWxkLT5pMmNfcGluKSkKPiArCQlpZiAoaW50ZWxfZ21i
dXNfaXNfdmFsaWRfcGluKGRldl9wcml2LCBjaGlsZC0+aTJjX3BpbikpCj4gIAkJCSppMmNfcGlu
ID0gY2hpbGQtPmkyY19waW47Cj4gIAo+ICAJCS8qIEhvd2V2ZXIsIHdlIGNhbm5vdCB0cnVzdCB0
aGUgQklPUyB3cml0ZXJzIHRvIHBvcHVsYXRlCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3Nkdm8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+
IGluZGV4IDEyNDk5MmU0OGFiZC4uYjEyMTc5NmM4NmFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3Nkdm8uYwo+IEBAIC0yMjkxLDcgKzIyOTEsOCBAQCBpbnRlbF9zZHZvX3NlbGVjdF9pMmNf
YnVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWVsc2UKPiAgCQltYXBw
aW5nID0gJmRldl9wcml2LT5zZHZvX21hcHBpbmdzWzFdOwo+ICAKPiAtCWlmIChtYXBwaW5nLT5p
bml0aWFsaXplZCAmJiBpbnRlbF9nbWJ1c19pc192YWxpZF9waW4obWFwcGluZy0+aTJjX3Bpbikp
Cj4gKwlpZiAobWFwcGluZy0+aW5pdGlhbGl6ZWQgJiYKPiArCSAgICBpbnRlbF9nbWJ1c19pc192
YWxpZF9waW4oZGV2X3ByaXYsIG1hcHBpbmctPmkyY19waW4pKQo+ICAJCXBpbiA9IG1hcHBpbmct
PmkyY19waW47Cj4gIAllbHNlCj4gIAkJcGluID0gR01CVVNfUElOX0RQQjsKPiAtLSAKPiAyLjEu
NAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K
aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
bnRlbC1nZngK