From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "liu,lei" <lei.a.liu@intel.com>
Cc: intel-gfx@lists.freedesktop.org, gordon.jin@intel.com
Subject: Re: [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode
Date: Thu, 2 Apr 2015 16:37:26 +0300 [thread overview]
Message-ID: <20150402133726.GA17410@intel.com> (raw)
In-Reply-To: <1427972074-17438-1-git-send-email-lei.a.liu@intel.com>
On Thu, Apr 02, 2015 at 06:54:34PM +0800, liu,lei wrote:
> From: "liu,lei" <lei.a.liu@intel.com>
>
> According DMT spec, vss of this mode should be 1393, vse should
> be 1396.
>
> VESA MONITOR TIMING STANDARD:
>
> Timing Name = 1856 x 1392 @ 75Hz
> Hor Total Time = 8.889; (usec) = 320 chars = 2560 Pixels
> Hor Sync Start = 6.889; (usec) = 248 chars = 1984 Pixels
> H Back Porch = 1.222; (usec) = 44 chars = 352 Pixels
>
> Ver Total Time = 13.333; (msec) = 1500 lines HT – (1.06xHA)
> Ver Sync Start = 12.382; (msec) = 1393 lines
> V Back Porch = 0.924; (msec) = 104 lines
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 53bc7a6..16991ea 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
> DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
> /* 1856x1392@75Hz */
> { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
> - 2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
> + 2208, 2560, 0, 1392, 1393, 1396, 1500, 0,
That is indeed what the spec says. However to review this I wrote a
quick awk script to parse the spec, and that shows a few more
differences. I'll toss out a patch with the results of my script...
> DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
> /* 1856x1392@120Hz RB */
> { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-02 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 10:54 [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode liu,lei
2015-04-02 12:11 ` Jani Nikula
2015-04-02 13:37 ` Ville Syrjälä [this message]
2015-04-03 7:30 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402133726.GA17410@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=gordon.jin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lei.a.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox