From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/6] drm/i915: Don't use intel_crtc->new_config in pll calculation code Date: Tue, 7 Apr 2015 11:22:25 +0200 Message-ID: <20150407092225.GC6354@phenom.ffwll.local> References: <1427975281-7688-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1427975281-7688-3-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by gabe.freedesktop.org (Postfix) with ESMTP id D9BBA6E544 for ; Tue, 7 Apr 2015 02:20:28 -0700 (PDT) Received: by wgsk9 with SMTP id k9so26811446wgs.3 for ; Tue, 07 Apr 2015 02:20:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1427975281-7688-3-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDIsIDIwMTUgYXQgMDI6NDc6NTdQTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IE1vdmUgdG93YXJkcyBhdG9taWMgYnkgdXNpbmcgdGhlIGF0 b21pYyBzdGF0ZSBpbnN0ZWFkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBk ZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTUgKysrKysrKysrKyst LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBhNmNkOGM3Li4wYjdk ZGVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMTU4MSwx MCArMTE1ODEsMTEgQEAgaW50ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gIAlyZXR1cm4gaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCB0 b19pbnRlbF9jcnRjKGNydGMpKTs7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgX19pbnRlbF9zZXRf bW9kZV9zZXR1cF9wbGxzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gK3N0YXRpYyBpbnQgX19p bnRlbF9zZXRfbW9kZV9zZXR1cF9wbGxzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwK PiAgCQkJCSAgICAgICB1bnNpZ25lZCBtb2Rlc2V0X3BpcGVzLAo+ICAJCQkJICAgICAgIHVuc2ln bmVkIGRpc2FibGVfcGlwZXMpCgpCaWtlc2hlZDogVGhlIG5hbWUgb2YgdGhpcyBmdW5jdGlvbiBp cyBhIGJpdCBjb25mdXNpb24gLSBpdCdzIHBhcnQgb2YgdGhlCmNvbXB1dGVfY29uZmlnIHBoYXNl IG9mIG1vZGVzZXRzIHN0aWxsLCBidXQgbm90IHJlYWxseSBuYW1lZCBsaWtlIHRoYXQuClNhbWUg d2l0aCB0aGUgY2FsbCB0byB2YWxsZXl2aWV3X21vZGVzZXRfZ2xvYmFsX3BpcGVzIHJpZ2h0IGFi b3ZlIGl0LgoKVGhlIHByb2JsZW0gaXMgYWxzbyB0aGF0IHRoaXMgaXMgc2VwYXJhdGVkIGZyb20g dGhlIG90aGVyIGNvbXB1dGVfY29uZmlnCmNvZGUuIEhlbmNlIEkgdGhpbmsgd2UgY2FuIG9ubHkg YXBwbHkgc29tZSBwb2xpc2ggaGVyZSBvbmNlIHRoYXQncyBhbGwKdW5pZmllZCBhZ2FpbiBhbmQg bWVyZ2VkIGludG8gdGhlIG92ZXJhbGwgYXRvbWljX2NoZWNrIGZ1bmN0aW9uLgotRGFuaWVsCgo+ ICB7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gc3RhdGUtPmRldjsKPiAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCXVuc2lnbmVkIGNs ZWFyX3BpcGVzID0gbW9kZXNldF9waXBlcyB8IGRpc2FibGVfcGlwZXM7Cj4gIAlzdHJ1Y3QgaW50 ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiBAQCAtMTE1OTgsOSArMTE1OTksMTUgQEAgc3RhdGljIGlu dCBfX2ludGVsX3NldF9tb2RlX3NldHVwX3BsbHMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAg CQlnb3RvIGRvbmU7Cj4gIAo+ICAJZm9yX2VhY2hfaW50ZWxfY3J0Y19tYXNrZWQoZGV2LCBtb2Rl c2V0X3BpcGVzLCBpbnRlbF9jcnRjKSB7Cj4gLQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnN0 YXRlID0gaW50ZWxfY3J0Yy0+bmV3X2NvbmZpZzsKPiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqY3J0Y19zdGF0ZSA9Cj4gKwkJCWludGVsX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwg aW50ZWxfY3J0Yyk7Cj4gKwo+ICsJCS8qIE1vZGVzZXQgcGlwZXMgc2hvdWxkIGhhdmUgYSBuZXcg c3RhdGUgYnkgbm93ICovCj4gKwkJaWYgKFdBUk5fT04oSVNfRVJSKGNydGNfc3RhdGUpKSkKPiAr CQkJY29udGludWU7Cj4gKwo+ICAJCXJldCA9IGRldl9wcml2LT5kaXNwbGF5LmNydGNfY29tcHV0 ZV9jbG9jayhpbnRlbF9jcnRjLAo+IC0JCQkJCQkJICAgc3RhdGUpOwo+ICsJCQkJCQkJICAgY3J0 Y19zdGF0ZSk7Cj4gIAkJaWYgKHJldCkgewo+ICAJCQlpbnRlbF9zaGFyZWRfZHBsbF9hYm9ydF9j b25maWcoZGV2X3ByaXYpOwo+ICAJCQlnb3RvIGRvbmU7Cj4gQEAgLTExNjU4LDcgKzExNjY1LDcg QEAgc3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAg CQlwcmVwYXJlX3BpcGVzICY9IH5kaXNhYmxlX3BpcGVzOwo+ICAJfQo+ICAKPiAtCXJldCA9IF9f aW50ZWxfc2V0X21vZGVfc2V0dXBfcGxscyhkZXYsIG1vZGVzZXRfcGlwZXMsIGRpc2FibGVfcGlw ZXMpOwo+ICsJcmV0ID0gX19pbnRlbF9zZXRfbW9kZV9zZXR1cF9wbGxzKHN0YXRlLCBtb2Rlc2V0 X3BpcGVzLCBkaXNhYmxlX3BpcGVzKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBkb25lOwo+ICAK PiAtLSAKPiAyLjEuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK