From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915/skl: Fix stepping check for a couple of W/As
Date: Wed, 8 Apr 2015 10:15:30 +0200 [thread overview]
Message-ID: <20150408081530.GP6354@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+tuOP34vHcAWBzN=FvNgYLiC9g85yHCfmCw4bYVuo0WYw@mail.gmail.com>
On Tue, Apr 07, 2015 at 03:45:22PM -0700, Rodrigo Vivi wrote:
> (ops, had forgotten to cc mailing list)
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Both patches merged, thanks.
-Daniel
>
> On Thu, Feb 26, 2015 at 10:20 AM, Damien Lespiau
> <damien.lespiau@intel.com> wrote:
> > Both WaDisableSDEUnitClockGating and WaSetGAPSunitClckGateDisable are
> > needed on B0 as well.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 7dcb5b6..f11e487 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -67,7 +67,7 @@ static void skl_init_clock_gating(struct drm_device *dev)
> >
> > gen9_init_clock_gating(dev);
> >
> > - if (INTEL_REVID(dev) == SKL_REVID_A0) {
> > + if (INTEL_REVID(dev) <= SKL_REVID_B0) {
> > /*
> > * WaDisableSDEUnitClockGating:skl
> > * WaSetGAPSunitClckGateDisable:skl
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-08 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 18:20 [PATCH 0/2] A couple of follow up W/A patches Damien Lespiau
2015-02-26 18:20 ` [PATCH 1/2] drm/i915/skl: Fix stepping check for a couple of W/As Damien Lespiau
2015-04-07 22:45 ` Rodrigo Vivi
2015-04-08 8:15 ` Daniel Vetter [this message]
2015-02-26 18:20 ` [PATCH 2/2] drm/i915/skl: Implement WaDisableVFUnitClockGating Damien Lespiau
2015-03-01 1:04 ` shuang.he
2015-04-07 22:44 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408081530.GP6354@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox