Re: [PATCH 00/14] skylake display scalers

[Matt Roper <matthew.d.roper@intel.com>]

On Tue, Apr 07, 2015 at 03:28:33PM -0700, Chandra Konduru wrote:
> Primary changes in this version are:
> 1) Moved num_scalers to crtc
> 2) Changed src/dst rect ranges to #defines
> 3) Dropped scaling ratios from state instead calculating when needed
> 4) Dropped filter from scaler
> 5) Squashed helper functions from standalone patches into patch where 1st used
> 6) Kept sprite src tect in 16.16 format
> 
> Though changes are minor but they got sprinkled into multiple patches.
> 
> Sending full patch series for completeness. Individual patch headers
> have additional details on changes. This series should cleanly
> merge to latest drm-intel-nighly.

Okay, this is looking pretty good now.  I only spotted a single issue
(which affects patches #6 and #13); all of the other patches are

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

I also requested an update to the commit message of patch #9, but the
code itself looks fine and still has my r-b.


Matt

> 
> Chandra Konduru (14):
>   drm: Adding drm helper function drm_plane_from_index().
>   drm/i915: Register definitions for skylake scalers
>   drm/i915: skylake scaler structure definitions
>   drm/i915: Initialize plane colorkey to NONE
>   drm/i915: Initialize skylake scalers
>   drm/i915: Keep sprite plane src rect in 16.16 format
>   drm/i915: Dump scaler_state too as part of dumping crtc_state
>   drm/i915: Preserve scaler state when clearing crtc_state
>   drm/i915: setup scalers for crtc_compute_config
>   drm/i915: Ensure setting up scalers into staged crtc_state
>   drm/i915: copy staged scaler state from drm state to crtc->config.
>   drm/i915: skylake panel fitting using shared scalers
>   drm/i915: skylake primary plane scaling using shared scalers
>   drm/i915: skylake sprite plane scaling using shared scalers
> 
>  drivers/gpu/drm/drm_crtc.c           |   22 ++
>  drivers/gpu/drm/i915/i915_reg.h      |  115 +++++++++
>  drivers/gpu/drm/i915/intel_atomic.c  |  163 +++++++++++++
>  drivers/gpu/drm/i915/intel_display.c |  441 +++++++++++++++++++++++++++++++---
>  drivers/gpu/drm/i915/intel_dp.c      |    8 +
>  drivers/gpu/drm/i915/intel_drv.h     |   76 ++++++
>  drivers/gpu/drm/i915/intel_sprite.c  |   83 +++++--
>  include/drm/drm_crtc.h               |    1 +
>  8 files changed, 855 insertions(+), 54 deletions(-)
> 
> -- 
> 1.7.9.5
> 

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx