From: Daniel Vetter <daniel@ffwll.ch>
To: Chandra Konduru <chandra.konduru@intel.com>
Cc: ander.conselvan.de.oliveira@intel.com,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
daniel.vetter@intel.com
Subject: Re: [PATCH 01/14] drm: Adding drm helper function drm_plane_from_index().
Date: Fri, 10 Apr 2015 08:59:34 +0200 [thread overview]
Message-ID: <20150410065933.GU12038@phenom.ffwll.local> (raw)
In-Reply-To: <1428626181-32351-1-git-send-email-chandra.konduru@intel.com>
On Thu, Apr 09, 2015 at 05:36:21PM -0700, Chandra Konduru wrote:
> Adding drm helper function to return plane pointer from index where
> index is a returned by drm_plane_index.
>
> v2:
> -avoided nested loop by adding loop count (Daniel)
>
> v3:
> -updated patch header prefix to 'drm' (Matt)
>
> v4:
> -fixed a kerneldoc issue (kbuild-internal)
>
> Cc: dri-devel@lists.freedesktop.org
>
> Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
Applied with Dave's irc-ack. btw when resending patches please pick up r-b
tags so I don't have to hunt around on the m-l to find them.
Thanks, Daniel
> ---
> drivers/gpu/drm/drm_crtc.c | 23 +++++++++++++++++++++++
> include/drm/drm_crtc.h | 1 +
> 2 files changed, 24 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index d576a4d..ad4d9ae 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -1289,6 +1289,29 @@ unsigned int drm_plane_index(struct drm_plane *plane)
> EXPORT_SYMBOL(drm_plane_index);
>
> /**
> + * drm_plane_from_index - find the registered plane at an index
> + * @dev: DRM device
> + * @idx: index of registered plane to find for
> + *
> + * Given a plane index, return the registered plane from DRM device's
> + * list of planes with matching index.
> + */
> +struct drm_plane *
> +drm_plane_from_index(struct drm_device *dev, int idx)
> +{
> + struct drm_plane *plane;
> + unsigned int i = 0;
> +
> + list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
> + if (i == idx)
> + return plane;
> + i++;
> + }
> + return NULL;
> +}
> +EXPORT_SYMBOL(drm_plane_from_index);
> +
> +/**
> * drm_plane_force_disable - Forcibly disable a plane
> * @plane: plane to disable
> *
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 7b5c661..6b30036 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -1264,6 +1264,7 @@ extern int drm_plane_init(struct drm_device *dev,
> bool is_primary);
> extern void drm_plane_cleanup(struct drm_plane *plane);
> extern unsigned int drm_plane_index(struct drm_plane *plane);
> +extern struct drm_plane * drm_plane_from_index(struct drm_device *dev, int idx);
> extern void drm_plane_force_disable(struct drm_plane *plane);
> extern int drm_plane_check_pixel_format(const struct drm_plane *plane,
> u32 format);
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-10 6:57 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 22:28 [PATCH 00/14] skylake display scalers Chandra Konduru
2015-04-07 22:28 ` [PATCH 01/14] drm: Adding drm helper function drm_plane_from_index() Chandra Konduru
2015-04-10 0:36 ` Chandra Konduru
2015-04-10 6:59 ` Daniel Vetter [this message]
2015-04-10 16:30 ` Konduru, Chandra
2015-04-07 22:28 ` [PATCH 02/14] drm/i915: Register definitions for skylake scalers Chandra Konduru
2015-04-07 22:28 ` [PATCH 03/14] drm/i915: skylake scaler structure definitions Chandra Konduru
2015-04-07 22:28 ` [PATCH 04/14] drm/i915: Initialize plane colorkey to NONE Chandra Konduru
2015-04-07 22:28 ` [PATCH 05/14] drm/i915: Initialize skylake scalers Chandra Konduru
2015-04-07 22:28 ` [PATCH 06/14] drm/i915: Keep sprite plane src rect in 16.16 format Chandra Konduru
2015-04-09 21:50 ` Matt Roper
2015-04-09 22:08 ` Konduru, Chandra
2015-04-09 22:22 ` Matt Roper
2015-04-09 22:27 ` Konduru, Chandra
2015-04-09 23:41 ` Chandra Konduru
2015-04-09 23:57 ` Matt Roper
2015-04-07 22:28 ` [PATCH 07/14] drm/i915: Dump scaler_state too as part of dumping crtc_state Chandra Konduru
2015-04-07 22:28 ` [PATCH 08/14] drm/i915: Preserve scaler state when clearing crtc_state Chandra Konduru
2015-04-07 22:28 ` [PATCH 09/14] drm/i915: setup scalers for crtc_compute_config Chandra Konduru
2015-04-09 21:51 ` Matt Roper
2015-04-09 22:07 ` Konduru, Chandra
2015-04-09 23:42 ` Chandra Konduru
2015-04-07 22:28 ` [PATCH 10/14] drm/i915: Ensure setting up scalers into staged crtc_state Chandra Konduru
2015-04-07 22:28 ` [PATCH 11/14] drm/i915: copy staged scaler state from drm state to crtc->config Chandra Konduru
2015-04-07 22:28 ` [PATCH 12/14] drm/i915: skylake panel fitting using shared scalers Chandra Konduru
2015-04-07 22:28 ` [PATCH 13/14] drm/i915: skylake primary plane scaling " Chandra Konduru
2015-04-09 21:51 ` Matt Roper
2015-04-09 22:14 ` Konduru, Chandra
2015-04-13 9:46 ` Daniel Vetter
2015-04-13 18:12 ` Daniel Vetter
2015-04-13 18:18 ` Konduru, Chandra
2015-04-14 7:00 ` Daniel Vetter
2015-04-15 22:14 ` Chandra Konduru
2015-04-15 23:08 ` Konduru, Chandra
2015-04-16 7:36 ` Daniel Vetter
2015-04-16 8:17 ` Jindal, Sonika
2015-04-23 20:20 ` Daniel Vetter
2015-04-27 5:13 ` Konduru, Chandra
2015-05-04 8:16 ` Daniel Vetter
2015-04-27 20:48 ` Chandra Konduru
2015-04-29 12:12 ` Jani Nikula
2015-04-29 16:26 ` Konduru, Chandra
2015-05-01 16:47 ` Matt Roper
2015-04-07 22:28 ` [PATCH 14/14] drm/i915: skylake sprite " Chandra Konduru
2015-04-09 23:43 ` Chandra Konduru
2015-04-10 0:01 ` Matt Roper
2015-04-15 22:15 ` Chandra Konduru
2015-04-16 7:42 ` Daniel Vetter
2015-04-16 8:18 ` Jindal, Sonika
2015-04-09 21:53 ` [PATCH 00/14] skylake display scalers Matt Roper
2015-04-09 22:12 ` Matt Roper
2015-04-09 22:22 ` Konduru, Chandra
2015-04-10 9:34 ` Daniel Vetter
2015-04-10 16:29 ` Konduru, Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410065933.GU12038@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=chandra.konduru@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox