From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/11] drm/i915: Extract mode_changed computation out of stage_output_config() Date: Fri, 10 Apr 2015 12:07:06 +0200 Message-ID: <20150410100706.GI6092@phenom.ffwll.local> References: <1428655120-22494-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1428655120-22494-6-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTP id D2B446E0D0 for ; Fri, 10 Apr 2015 03:05:08 -0700 (PDT) Received: by wiaa2 with SMTP id a2so20489562wia.0 for ; Fri, 10 Apr 2015 03:05:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1428655120-22494-6-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMTAsIDIwMTUgYXQgMTE6Mzg6MzRBTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoaXMgc2hvdWxkIG1ha2UgdGhlIGNvbnZlcnNpb24gdG8g YXRvbWljIGVhc2llciwgYnkgc3BsaXR0aW5nIHRoZQo+IGluaXRpYWxpemF0aW9uIG9mIHRoZSBh dG9taWMgc3RhdGUgZnJvbSB0aGUgbG9naWMgdGhhdCBkZWNpZGVzIGlmIGEKPiBtb2Rlc2V0IGlz IG5lZWRlZC4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwg NzMgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0MSBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gaW5kZXggMzAzNWEzZC4uNzJjZWI2ZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTE5NTgsNiArMTE5NTgsMTAgQEAgc3RhdGlj IHZvaWQKPiAgaW50ZWxfc2V0X2NvbmZpZ19jb21wdXRlX21vZGVfY2hhbmdlcyhzdHJ1Y3QgZHJt X21vZGVfc2V0ICpzZXQsCj4gIAkJCQkgICAgICBzdHJ1Y3QgaW50ZWxfc2V0X2NvbmZpZyAqY29u ZmlnKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gc2V0LT5jcnRjLT5kZXY7Cj4g KwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5j b2RlciAqZW5jb2RlcjsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ICAKPiAgCS8qIFdl IHNob3VsZCBiZSBhYmxlIHRvIGNoZWNrIGhlcmUgaWYgdGhlIGZiIGhhcyB0aGUgc2FtZSBwcm9w ZXJ0aWVzCj4gIAkgKiBhbmQgdGhlbiBqdXN0IGZsaXBfb3JfbW92ZSBpdCAqLwo+IEBAIC0xMjAw MSw2ICsxMjAwNSwzNiBAQCBpbnRlbF9zZXRfY29uZmlnX2NvbXB1dGVfbW9kZV9jaGFuZ2VzKHN0 cnVjdCBkcm1fbW9kZV9zZXQgKnNldCwKPiAgCQljb25maWctPm1vZGVfY2hhbmdlZCA9IHRydWU7 Cj4gIAl9Cj4gIAo+ICsJZm9yX2VhY2hfaW50ZWxfY29ubmVjdG9yKGRldiwgY29ubmVjdG9yKSB7 Cj4gKwkJaWYgKCZjb25uZWN0b3ItPm5ld19lbmNvZGVyLT5iYXNlID09IGNvbm5lY3Rvci0+YmFz ZS5lbmNvZGVyKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJY29uZmlnLT5tb2RlX2NoYW5nZWQg PSB0cnVlOwo+ICsJCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIGVuY29kZXIgY2hh bmdlZCwgZnVsbCBtb2RlIHN3aXRjaFxuIiwKPiArCQkJICAgICAgY29ubmVjdG9yLT5iYXNlLmJh c2UuaWQsCj4gKwkJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiArCX0KPiArCj4gKwlm b3JfZWFjaF9pbnRlbF9lbmNvZGVyKGRldiwgZW5jb2Rlcikgewo+ICsJCWlmICgmZW5jb2Rlci0+ bmV3X2NydGMtPmJhc2UgPT0gZW5jb2Rlci0+YmFzZS5jcnRjKQo+ICsJCQljb250aW51ZTsKPiAr Cj4gKwkJRFJNX0RFQlVHX0tNUygiW0VOQ09ERVI6JWQ6JXNdIGNydGMgY2hhbmdlZCwgZnVsbCBt b2RlIHN3aXRjaFxuIiwKPiArCQkJICAgICAgZW5jb2Rlci0+YmFzZS5iYXNlLmlkLAo+ICsJCQkg ICAgICBlbmNvZGVyLT5iYXNlLm5hbWUpOwo+ICsJCWNvbmZpZy0+bW9kZV9jaGFuZ2VkID0gdHJ1 ZTsKPiArCX0KPiArCj4gKwlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+ICsJCWlm IChjcnRjLT5uZXdfZW5hYmxlZCA9PSBjcnRjLT5iYXNlLnN0YXRlLT5lbmFibGUpCj4gKwkJCWNv bnRpbnVlOwo+ICsKPiArCQlEUk1fREVCVUdfS01TKCJbQ1JUQzolZF0gJXNhYmxlZCwgZnVsbCBt b2RlIHN3aXRjaFxuIiwKPiArCQkJICAgICAgY3J0Yy0+YmFzZS5iYXNlLmlkLAo+ICsJCQkgICAg ICBjcnRjLT5uZXdfZW5hYmxlZCA/ICJlbiIgOiAiZGlzIik7Cj4gKwkJY29uZmlnLT5tb2RlX2No YW5nZWQgPSB0cnVlOwo+ICsJfQo+ICsKPiAgCURSTV9ERUJVR19LTVMoImNvbXB1dGVkIGNoYW5n ZXMgZm9yIFtDUlRDOiVkXSwgbW9kZV9jaGFuZ2VkPSVkLCBmYl9jaGFuZ2VkPSVkXG4iLAo+ICAJ CQlzZXQtPmNydGMtPmJhc2UuaWQsIGNvbmZpZy0+bW9kZV9jaGFuZ2VkLCBjb25maWctPmZiX2No YW5nZWQpOwo+ICB9CgpBbnkgY2hhbmNlIHdlIGNvdWxkIHJldXNlIHNvbWUgcGFydHMgb2YgdGhl IGxvZ2ljIGluIGRybV9hdG9taWNfaGVscGVyLmM/CkNvcHlwYXN0aW5nIHRoYXQgdG8gaGF2ZSBz b21ldGhpbmcgd2hpY2ggdXNlcyBzdGF0ZSBvYmplY3RzIGluc3RlYWQgb2Ygb3VyCm5ld18gcG9p bnRlcnMgZmVlbHMgbGFtZS4KCj4gQEAgLTEyMDA4LDcgKzEyMDQyLDYgQEAgaW50ZWxfc2V0X2Nv bmZpZ19jb21wdXRlX21vZGVfY2hhbmdlcyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQsCj4gIHN0 YXRpYyBpbnQKPiAgaW50ZWxfbW9kZXNldF9zdGFnZV9vdXRwdXRfc3RhdGUoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAgCQkJCSBzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQsCj4gLQkJCQkgc3Ry dWN0IGludGVsX3NldF9jb25maWcgKmNvbmZpZywKPiAgCQkJCSBzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcjsK PiBAQCAtMTIwNDQsMTQgKzEyMDc3LDYgQEAgaW50ZWxfbW9kZXNldF9zdGFnZV9vdXRwdXRfc3Rh dGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCWNvbm5lY3Rvci0+YmFzZS5iYXNlLmlk LAo+ICAJCQkJY29ubmVjdG9yLT5iYXNlLm5hbWUpOwo+ICAJCX0KPiAtCj4gLQo+IC0JCWlmICgm Y29ubmVjdG9yLT5uZXdfZW5jb2Rlci0+YmFzZSAhPSBjb25uZWN0b3ItPmJhc2UuZW5jb2Rlcikg ewo+IC0JCQlEUk1fREVCVUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBlbmNvZGVyIGNoYW5nZWQs IGZ1bGwgbW9kZSBzd2l0Y2hcbiIsCj4gLQkJCQkgICAgICBjb25uZWN0b3ItPmJhc2UuYmFzZS5p ZCwKPiAtCQkJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiAtCQkJY29uZmlnLT5tb2Rl X2NoYW5nZWQgPSB0cnVlOwo+IC0JCX0KPiAgCX0KPiAgCS8qIGNvbm5lY3Rvci0+bmV3X2VuY29k ZXIgaXMgbm93IHVwZGF0ZWQgZm9yIGFsbCBjb25uZWN0b3JzLiAqLwo+ICAKPiBAQCAtMTIxMDQs MTUgKzEyMTI5LDYgQEAgaW50ZWxfbW9kZXNldF9zdGFnZV9vdXRwdXRfc3RhdGUoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwKPiAgCQkJZW5jb2Rlci0+bmV3X2NydGMgPSBOVUxMOwo+ICAJCWVsc2Ug aWYgKG51bV9jb25uZWN0b3JzID4gMSkKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQo+IC0JCS8q IE9ubHkgbm93IGNoZWNrIGZvciBjcnRjIGNoYW5nZXMgc28gd2UgZG9uJ3QgbWlzcyBlbmNvZGVy cwo+IC0JCSAqIHRoYXQgd2lsbCBiZSBkaXNhYmxlZC4gKi8KPiAtCQlpZiAoJmVuY29kZXItPm5l d19jcnRjLT5iYXNlICE9IGVuY29kZXItPmJhc2UuY3J0Yykgewo+IC0JCQlEUk1fREVCVUdfS01T KCJbRU5DT0RFUjolZDolc10gY3J0YyBjaGFuZ2VkLCBmdWxsIG1vZGUgc3dpdGNoXG4iLAo+IC0J CQkJICAgICAgZW5jb2Rlci0+YmFzZS5iYXNlLmlkLAo+IC0JCQkJICAgICAgZW5jb2Rlci0+YmFz ZS5uYW1lKTsKPiAtCQkJY29uZmlnLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+IC0JCX0KPiAgCX0K PiAgCS8qIE5vdyB3ZSd2ZSBhbHNvIHVwZGF0ZWQgZW5jb2Rlci0+bmV3X2NydGMgZm9yIGFsbCBl bmNvZGVycy4gKi8KPiAgCWZvcl9lYWNoX2ludGVsX2Nvbm5lY3RvcihkZXYsIGNvbm5lY3Rvcikg ewo+IEBAIC0xMjEzOCwxMyArMTIxNTQsNiBAQCBpbnRlbF9tb2Rlc2V0X3N0YWdlX291dHB1dF9z dGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJYnJlYWs7Cj4gIAkJCX0KPiAgCQl9 Cj4gLQo+IC0JCWlmIChjcnRjLT5uZXdfZW5hYmxlZCAhPSBjcnRjLT5iYXNlLnN0YXRlLT5lbmFi bGUpIHsKPiAtCQkJRFJNX0RFQlVHX0tNUygiW0NSVEM6JWRdICVzYWJsZWQsIGZ1bGwgbW9kZSBz d2l0Y2hcbiIsCj4gLQkJCQkgICAgICBjcnRjLT5iYXNlLmJhc2UuaWQsCj4gLQkJCQkgICAgICBj cnRjLT5uZXdfZW5hYmxlZCA/ICJlbiIgOiAiZGlzIik7Cj4gLQkJCWNvbmZpZy0+bW9kZV9jaGFu Z2VkID0gdHJ1ZTsKPiAtCQl9Cj4gIAl9Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gQEAgLTEyMjE2LDEy ICsxMjIyNSw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19zZXRfY29uZmlnKHN0cnVjdCBkcm1f bW9kZV9zZXQgKnNldCkKPiAgCXNhdmVfc2V0LnkgPSBzZXQtPmNydGMtPnk7Cj4gIAlzYXZlX3Nl dC5mYiA9IHNldC0+Y3J0Yy0+cHJpbWFyeS0+ZmI7Cj4gIAo+IC0JLyogQ29tcHV0ZSB3aGV0aGVy IHdlIG5lZWQgYSBmdWxsIG1vZGVzZXQsIG9ubHkgYW4gZmIgYmFzZSB1cGRhdGUgb3Igbm8KPiAt CSAqIGNoYW5nZSBhdCBhbGwuIEluIHRoZSBmdXR1cmUgd2UgbWlnaHQgYWxzbyBjaGVjayB3aGV0 aGVyIG9ubHkgdGhlCj4gLQkgKiBtb2RlIGNoYW5nZWQsIGUuZy4gZm9yIExWRFMgd2hlcmUgd2Ug b25seSBjaGFuZ2UgdGhlIHBhbmVsIGZpdHRlciBpbgo+IC0JICogc3VjaCBjYXNlcy4gKi8KPiAt CWludGVsX3NldF9jb25maWdfY29tcHV0ZV9tb2RlX2NoYW5nZXMoc2V0LCBjb25maWcpOwo+IC0K PiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+ICAJaWYgKCFzdGF0ZSkg ewo+ICAJCXJldCA9IC1FTk9NRU07Cj4gQEAgLTEyMjMwLDEwICsxMjIzMywxNiBAQCBzdGF0aWMg aW50IGludGVsX2NydGNfc2V0X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQpCj4gIAo+ ICAJc3RhdGUtPmFjcXVpcmVfY3R4ID0gZGV2LT5tb2RlX2NvbmZpZy5hY3F1aXJlX2N0eDsKPiAg Cj4gLQlyZXQgPSBpbnRlbF9tb2Rlc2V0X3N0YWdlX291dHB1dF9zdGF0ZShkZXYsIHNldCwgY29u ZmlnLCBzdGF0ZSk7Cj4gKwlyZXQgPSBpbnRlbF9tb2Rlc2V0X3N0YWdlX291dHB1dF9zdGF0ZShk ZXYsIHNldCwgc3RhdGUpOwo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGZhaWw7Cj4gIAo+ICsJLyog Q29tcHV0ZSB3aGV0aGVyIHdlIG5lZWQgYSBmdWxsIG1vZGVzZXQsIG9ubHkgYW4gZmIgYmFzZSB1 cGRhdGUgb3Igbm8KPiArCSAqIGNoYW5nZSBhdCBhbGwuIEluIHRoZSBmdXR1cmUgd2UgbWlnaHQg YWxzbyBjaGVjayB3aGV0aGVyIG9ubHkgdGhlCj4gKwkgKiBtb2RlIGNoYW5nZWQsIGUuZy4gZm9y IExWRFMgd2hlcmUgd2Ugb25seSBjaGFuZ2UgdGhlIHBhbmVsIGZpdHRlciBpbgo+ICsJICogc3Vj aCBjYXNlcy4gKi8KPiArCWludGVsX3NldF9jb25maWdfY29tcHV0ZV9tb2RlX2NoYW5nZXMoc2V0 LCBjb25maWcpOwoKSW1vIHJlbmFtZSB0aGlzIHRvIGludGVsX2NvbXB1dGVfbW9kZV9jaGFuZ2Vz IG9yIHNpbWlsYXIsIHRoZSBzZXRfY29uZmlnCmlzIGJlY2F1c2Ugb2YgdGhlIC0+c2V0X2NvbmZp ZyBob29rLgotRGFuaWVsCgo+ICsKPiAgCXBpcGVfY29uZmlnID0gaW50ZWxfbW9kZXNldF9jb21w dXRlX2NvbmZpZyhzZXQtPmNydGMsIHNldC0+bW9kZSwKPiAgCQkJCQkJICAgc2V0LT5mYiwgc3Rh dGUsCj4gIAkJCQkJCSAgICZtb2Rlc2V0X3BpcGVzLAo+IC0tIAo+IDIuMS4wCj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=