public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/i915/skl: Implement enable/disable for Display C5 sttate.
Date: Mon, 13 Apr 2015 14:17:14 +0100	[thread overview]
Message-ID: <20150413131714.GC23484@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1427990302.22984.0.camel@intel.com>

On Thu, Apr 02, 2015 at 06:58:22PM +0300, Imre Deak wrote:
> On ke, 2015-04-01 at 16:22 +0530, Animesh Manna wrote:
> > From: "A.Sunil Kamath" <sunil.kamath@intel.com>
> > 
> > This patch just implements the basic enable and disable
> > functions of DC5 state which is needed for both SKL and BXT.
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>

For the record, this patch generates compilation warnings when applied
on its own:

drivers/gpu/drm/i915/intel_runtime_pm.c:368:13: warning: ‘gen9_enable_dc5’ defined but not used [-Wunused-function]
 static void gen9_enable_dc5(struct drm_i915_private *dev_priv)
             ^
drivers/gpu/drm/i915/intel_runtime_pm.c:386:13: warning: ‘gen9_disable_dc5’ defined but not used [-Wunused-function]
 static void gen9_disable_dc5(struct drm_i915_private *dev_priv)
             ^

Generally speaking, in a series, each step should compile without warning and
result in a working driver (for bisectability).

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-04-13 13:17 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 10:49 [PATCH 0/8] Enable DC states for skl Animesh Manna
2015-04-01 10:52 ` [PATCH 1/8] drm/i915/skl: Add support to load SKL CSR firmware Animesh Manna
2015-04-01 10:52   ` [PATCH 2/8] drm/i915/skl: Implement enable/disable for Display C5 sttate Animesh Manna
2015-04-02 15:58     ` Imre Deak
2015-04-13 13:17       ` Damien Lespiau [this message]
2015-04-13 13:51         ` Imre Deak
2015-04-14 11:50           ` Daniel Vetter
2015-04-01 10:52   ` [PATCH 3/8] drm/i915/skl: Add DC5 Trigger Sequence Animesh Manna
2015-04-02 19:33     ` Imre Deak
2015-04-10 15:11       ` [PATCH v2 " Animesh Manna
2015-04-13 10:26         ` [PATCH v3 " Animesh Manna
2015-04-13 11:33           ` Imre Deak
2015-04-13 17:41             ` Damien Lespiau
2015-04-13 15:25           ` Damien Lespiau
2015-04-13 17:49           ` Damien Lespiau
2015-04-01 10:52   ` [PATCH 4/8] drm/i915/skl: Assert the requirements to enter or exit DC5 Animesh Manna
2015-04-02 20:17     ` Imre Deak
2015-04-10 15:11       ` [PATCH v2 " Animesh Manna
2015-04-13 12:46         ` Imre Deak
2015-04-01 10:52   ` [PATCH 5/8] drm/i915/skl: Implement enable/disable for Display C6 state Animesh Manna
2015-04-02 20:20     ` Imre Deak
2015-04-01 10:52   ` [PATCH 6/8] drm/i915/skl: Add DC6 Trigger sequence Animesh Manna
2015-04-02 20:42     ` Imre Deak
2015-04-10 15:11       ` [PATCH v2 " Animesh Manna
2015-04-13 12:50         ` Imre Deak
2015-04-01 10:52   ` [PATCH 7/8] drm/i915/skl: Assert the requirements to enter or exit DC6 Animesh Manna
2015-04-02 20:49     ` Imre Deak
2015-04-10 15:12       ` [PATCH v2 " Animesh Manna
2015-04-01 10:52   ` [PATCH 8/8] drm/i915/skl: Enable runtime PM Animesh Manna
2015-04-02 20:49     ` Imre Deak
2015-04-02 15:21   ` [PATCH 1/8] drm/i915/skl: Add support to load SKL CSR firmware Imre Deak
2015-04-10 15:11     ` [PATCH v2 " Animesh Manna
2015-04-13 10:24       ` [PATCH v3 " Animesh Manna
2015-04-13 11:03         ` Imre Deak
2015-04-13 13:07           ` Animesh Manna
2015-04-13 12:37             ` Imre Deak
2015-04-13 16:34         ` Damien Lespiau
2015-04-13 16:52           ` Imre Deak
2015-04-13 17:02             ` Damien Lespiau
2015-04-13 17:15               ` Imre Deak
2015-04-13 17:22                 ` Damien Lespiau
2015-04-14  9:16                   ` Animesh Manna
2015-04-14 10:07                     ` Damien Lespiau
     [not found]           ` <20804_1428943986_552BF472_20804_13643_1_1428943974.12269.9.camel@ideak-mobl>
2015-04-13 19:00             ` ns2501 DVO - success at last Thomas Richter
2015-04-14 17:21               ` Daniel Vetter
2015-04-10 15:10 ` [PATCH v2 0/8] Enable DC states for skl Animesh Manna
  -- strict thread matches above, loose matches on Subject: below --
2015-04-01  7:48 [PATCH 2/8] drm/i915/skl: Implement enable/disable for Display C5 sttate Animesh Manna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413131714.GC23484@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox