Re: [PATCH 2/8] drm/i915/skl: Implement enable/disable for Display C5 sttate.

Damien Lespiau
2015-04-13T13:17:38Z

On Thu, Apr 02, 2015 at 06:58:22PM +0300, Imre Deak wrote:
> On ke, 2015-04-01 at 16:22 +0530, Animesh Manna wrote:
> > From: "A.Sunil Kamath" <sunil.kamath@intel.com>
> >
> > This patch just implements the basic enable and disable
> > functions of DC5 state which is needed for both SKL and BXT.
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>

For the record, this patch generates compilation warnings when applied
on its own:

drivers/gpu/drm/i915/intel_runtime_pm.c:368:13: warning: ‘gen9_enable_dc5’ defined but not used [-Wunused-function]
static void gen9_enable_dc5(struct drm_i915_private *dev_priv)
^
drivers/gpu/drm/i915/intel_runtime_pm.c:386:13: warning: ‘gen9_disable_dc5’ defined but not used [-Wunused-function]
static void gen9_disable_dc5(struct drm_i915_private *dev_priv)
^

Generally speaking, in a series, each step should compile without warning and
result in a working driver (for bisectability).

--
Damien