Re: [PATCH 2/8] drm/i915/skl: Implement enable/disable for Display C5 sttate.

Imre Deak
2015-04-13T13:51:39Z

On ma, 2015-04-13 at 14:17 +0100, Damien Lespiau wrote:
> On Thu, Apr 02, 2015 at 06:58:22PM +0300, Imre Deak wrote:
> > On ke, 2015-04-01 at 16:22 +0530, Animesh Manna wrote:
> > > From: "A.Sunil Kamath" <sunil.kamath@intel.com>
> > >
> > > This patch just implements the basic enable and disable
> > > functions of DC5 state which is needed for both SKL and BXT.
> >
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> For the record, this patch generates compilation warnings when applied
> on its own:
>
> drivers/gpu/drm/i915/intel_runtime_pm.c:368:13: warning: ‘gen9_enable_dc5’ defined but not used [-Wunused-function]
> static void gen9_enable_dc5(struct drm_i915_private *dev_priv)
> ^
> drivers/gpu/drm/i915/intel_runtime_pm.c:386:13: warning: ‘gen9_disable_dc5’ defined but not used [-Wunused-function]
> static void gen9_disable_dc5(struct drm_i915_private *dev_priv)
> ^
>
> Generally speaking, in a series, each step should compile without warning and
> result in a working driver (for bisectability).

Yes, agreed. Splitting the changes into patches could've been done in
better a way. I also commented on a related topic of adding something in
the patchset and removing it later. We'll try to pay more attention to
this in the future.

Animesh, if you resend this patchset anyway I think you could switch the
order of 2/8 and 3/8 and add the calls to the above functions in this
patch to get rid of the warnings. Also please make sure that things
compile without a warning after each patch as Damien suggested.

--Imre