From: Daniel Vetter <daniel@ffwll.ch>
To: "Jindal, Sonika" <sonika.jindal@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] Documentation/drm: Update rotation property with 90/270 and description
Date: Wed, 15 Apr 2015 12:42:36 +0200 [thread overview]
Message-ID: <20150415104236.GY6092@phenom.ffwll.local> (raw)
In-Reply-To: <552E3D9F.9050102@intel.com>
On Wed, Apr 15, 2015 at 03:59:51PM +0530, Jindal, Sonika wrote:
>
>
> On 4/15/2015 3:57 PM, Daniel Vetter wrote:
> >On Wed, Apr 15, 2015 at 03:35:08PM +0530, Sonika Jindal wrote:
> >>Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> >>---
> >> Documentation/DocBook/drm.tmpl | 7 +++++--
> >> 1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> >>index f4976cd..266d50a 100644
> >>--- a/Documentation/DocBook/drm.tmpl
> >>+++ b/Documentation/DocBook/drm.tmpl
> >>@@ -2853,9 +2853,12 @@ void intel_crt_init(struct drm_device *dev)
> >> <td rowspan="1" valign="top" >Plane</td>
> >> <td valign="top" >“rotation”</td>
> >> <td valign="top" >BITMASK</td>
> >>- <td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
> >>+ <td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
> >>+ { 2, "rotate-180" }, { 3, "rotate-270" }</td>
> >> <td valign="top" >Plane</td>
> >>- <td valign="top" >TBD</td>
> >>+ <td valign="top" >To set plane HW rotation. This rotation property does
> >>+ the plane rotation in counter clockwise direction which is
> >>+ inline with the way XRandr works.</td>
> >
> >Since this touches shared code can you please resend this patch with
> >dri-devel added to cc? BKM is to add a Cc: dri-devel ... line to the sob
> >section of the patch, then git send-email will automatically pick it up.
> >-Daniel
> >
> But I am changing the description for only the rotation property for i915.
Property names are supposed to be somewhat standardized across all
drivers, and omapdrm already supports rotation. This is way we have this
shared table, so that other driver authors know what's going on. Please
resend.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-15 10:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 9:07 [PATCH 1/2] drm/i915/skl: Allow universal planes to position Sonika Jindal
2015-04-10 9:07 ` [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation Sonika Jindal
2015-04-10 14:17 ` Daniel Vetter
2015-04-10 14:44 ` Ville Syrjälä
2015-04-13 4:06 ` Jindal, Sonika
2015-04-13 10:10 ` Ville Syrjälä
2015-04-13 10:23 ` Jindal, Sonika
2015-04-13 10:49 ` Ville Syrjälä
2015-04-13 23:39 ` Matt Roper
2015-04-14 12:19 ` Jindal, Sonika
2015-04-14 17:27 ` Daniel Vetter
2015-04-15 10:05 ` [PATCH 1/2] drm/i915: Swapping 90 and 270 to be compliant with Xrandr Sonika Jindal
2015-04-15 10:05 ` [PATCH 2/2] Documentation/drm: Update rotation property with 90/270 and description Sonika Jindal
2015-04-15 10:27 ` Daniel Vetter
2015-04-15 10:29 ` Jindal, Sonika
2015-04-15 10:42 ` Daniel Vetter [this message]
2015-04-15 10:35 ` [PATCH] " Sonika Jindal
2015-05-12 12:50 ` [Intel-gfx] " Ville Syrjälä
2015-05-13 4:27 ` Jindal, Sonika
2015-05-20 6:39 ` Jindal, Sonika
2015-05-20 7:49 ` Jindal, Sonika
2015-05-20 14:03 ` Ville Syrjälä
2015-05-28 11:05 ` [PATCH] Documentation/drm: Update rotation property Sonika Jindal
2015-05-28 11:19 ` [Intel-gfx] " Daniel Vetter
2015-05-12 12:35 ` [PATCH 1/2] drm/i915: Swapping 90 and 270 to be compliant with Xrandr Ville Syrjälä
2015-05-20 8:10 ` [PATCH] " Sonika Jindal
2015-05-20 9:15 ` Daniel Vetter
2015-04-13 11:10 ` [PATCH 2/2] drm/i915/skl: Support for 90/270 rotation Damien Lespiau
2015-04-13 4:02 ` Jindal, Sonika
2015-04-14 3:56 ` shuang.he
2015-10-06 13:32 ` [PATCH 1/2] drm/i915/skl: Allow universal planes to position Tvrtko Ursulin
2015-10-06 14:29 ` Matt Roper
2015-10-06 14:42 ` Ville Syrjälä
2015-10-06 15:16 ` Matt Roper
2015-10-06 16:28 ` Ville Syrjälä
2015-10-07 14:19 ` Daniel Vetter
2015-10-08 8:58 ` Tvrtko Ursulin
2015-10-16 12:23 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415104236.GY6092@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox