public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Antoine, Peter" <peter.antoine@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm: Kernel Crash in drm_unlock
Date: Thu, 16 Apr 2015 09:30:02 +0200	[thread overview]
Message-ID: <20150416073002.GC6092@phenom.ffwll.local> (raw)
In-Reply-To: <1429107766.2105.16.camel@peterant-linux>

On Wed, Apr 15, 2015 at 02:22:54PM +0000, Antoine, Peter wrote:
> Hi Daniel,
> 
> I am having a look at this now, as have some time.
> 
> So, to sum up what I think you want.
> 1. Re-base and apply the patches (so that the known holes are closed in
> the Nouveau driver).
> 2. Add DRIVER_KMS_LEGACY_CONTEXT to include/drm/drmP.h
> 3. Add DRIVER_KMS_LEGACY_CONTEXT to .driver_features in file
> drivers/gpu/drm/nouveau/nouveau_drm.h.
> 4. Change all the hw_lock IOCTL functions to have:
>    +       if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT))
>    +               return -EINVAL;
>    +
> 5. Add an igt test, that would induce the crash on platforms that are
> not patched and have DRIVER_KMS_LEGACY_CONTEXT enabled?
> 
> Is this about right?

Sounds like a solid plan. When you send out the patch please also cc
dri-devel since this will all touch code outside of i915.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-04-16  7:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31  8:09 [PATCH] drm: Kernel Crash in drm_unlock Peter Antoine
2015-03-31  8:09 ` [PATCH] drm: Possible lock priority escalation Peter Antoine
2015-03-31 15:53   ` shuang.he
2015-03-31  8:09 ` [PATCH] drm: Fixes unsafe deference in locks Peter Antoine
2015-03-31 18:20   ` shuang.he
2015-03-31 13:24 ` [PATCH] drm: Kernel Crash in drm_unlock shuang.he
2015-03-31 13:25 ` Daniel Vetter
2015-03-31 13:28   ` Damien Lespiau
2015-03-31 13:34   ` Antoine, Peter
2015-03-31 14:00     ` Daniel Vetter
2015-03-31 14:21       ` Antoine, Peter
2015-04-15 14:22       ` Antoine, Peter
2015-04-16  7:30         ` Daniel Vetter [this message]
2015-03-31 13:35   ` Damien Lespiau
2015-03-31 13:38     ` Antoine, Peter
2015-03-31 13:44       ` Damien Lespiau
2015-03-31 13:47         ` Antoine, Peter
2015-03-31 13:53         ` He, Shuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150416073002.GC6092@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=peter.antoine@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox