Re: [PATCH] drm/i915: Simplify i915_gem_obj_is_pinned() test for set-tiling

Daniel Vetter
2015-04-16T14:06:06Z

On Thu, Apr 16, 2015 at 11:50:04AM +0100, Chris Wilson wrote:
> On Thu, Apr 16, 2015 at 11:03:20AM +0200, Daniel Vetter wrote:
> > On Wed, Apr 15, 2015 at 04:39:59PM +0100, Chris Wilson wrote:
> > > Since the removal of the user pin_ioctl, the only means for pinning an
> > > object is either through binding to the scanout or during execbuf
> > > reservation. As the later prevents a call to set-tiling, we need only
> > > check if the obj is pinned into the display plane to see if we need
> > > reject the set-tiling ioctl.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Queued for -next, thanks for the patch.
>
> I was wondering if I could get away with framebuffer_references now that
> we do allocate fb for everything, but was too lazy to actually check.
>
> Gut feeling?

legacy overlay is still using plain buffers unfortunately :(
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation