From: Daniel Vetter <daniel@ffwll.ch>
To: Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 10/10] drm: Fix the 'native defer' message in drm_dp_i2c_do_msg()
Date: Thu, 16 Apr 2015 14:44:15 +0200 [thread overview]
Message-ID: <20150416124415.GF5082@phenom.ffwll.local> (raw)
In-Reply-To: <1429112327-7695-11-git-send-email-tprevite@gmail.com>
On Wed, Apr 15, 2015 at 08:38:47AM -0700, Todd Previte wrote:
> The debug message is missing a newline at the end and it makes the
> logs hard to read when a device defers a lot. Simple 2-character fix
> adds the newline at the end.
>
> Signed-off-by: Todd Previte <tprevite@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Applied to topic/drm-misc.
-Daniel
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 7f0356e..80a02a4 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -466,7 +466,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
> return -EREMOTEIO;
>
> case DP_AUX_NATIVE_REPLY_DEFER:
> - DRM_DEBUG_KMS("native defer");
> + DRM_DEBUG_KMS("native defer\n");
> /*
> * We could check for I2C bit rate capabilities and if
> * available adjust this interval. We could also be
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-04-16 12:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 15:38 [PATCH V6] Displayport compliance testing V6 Todd Previte
2015-04-15 15:38 ` [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing Todd Previte
2015-04-16 11:32 ` Daniel Vetter
2015-04-15 15:38 ` [PATCH 02/10] drm/i915: Update intel_dp_check_link_status() " Todd Previte
2015-04-15 19:28 ` [PATCH 02/12] " Todd Previte
2015-04-15 19:45 ` Paulo Zanoni
2015-04-15 15:38 ` [PATCH 03/10] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1 Todd Previte
2015-04-15 17:15 ` [PATCH 03/12] " Todd Previte
2015-04-15 19:29 ` Todd Previte
2015-04-15 15:38 ` [PATCH 04/10] drm/i915: Add a delay in Displayport AUX transactions for compliance testing Todd Previte
2015-04-16 12:37 ` Daniel Vetter
2015-04-15 15:38 ` [PATCH 05/10] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6 Todd Previte
2015-04-15 17:15 ` [PATCH 05/12] " Todd Previte
2015-04-15 20:25 ` [Intel-gfx] " Paulo Zanoni
2015-04-15 21:59 ` Todd Previte
2015-04-15 22:03 ` Todd Previte
2015-04-16 13:34 ` Paulo Zanoni
2015-04-16 14:02 ` Todd Previte
2015-04-16 15:47 ` Todd Previte
2015-04-15 15:38 ` [PATCH 06/10] drm/i915: Update intel_dp_hpd_pulse() for non-MST operation Todd Previte
2015-04-15 17:15 ` [PATCH 06/12] " Todd Previte
2015-04-16 7:22 ` Todd Previte
2015-04-15 15:38 ` [PATCH 07/10] drm/i915: Support EDID compliance tests with the intel_dp_autotest_edid() function Todd Previte
2015-04-15 17:16 ` [PATCH 07/12] " Todd Previte
2015-04-15 15:38 ` [PATCH 08/10] drm: Fix for DP CTS test 4.2.2.5 - I2C DEFER handling Todd Previte
2015-04-16 20:23 ` Paulo Zanoni
2015-04-15 15:38 ` [PATCH 09/10] drm/i915: Add debugfs test control files for Displayport compliance testing Todd Previte
2015-04-16 21:25 ` Paulo Zanoni
2015-04-15 15:38 ` [PATCH 10/10] drm: Fix the 'native defer' message in drm_dp_i2c_do_msg() Todd Previte
2015-04-16 12:42 ` Daniel Vetter
2015-04-16 12:44 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416124415.GF5082@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tprevite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox