From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: vinit.azad@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: Intel-gfx Digest, Vol 86, Issue 409
Date: Mon, 20 Apr 2015 09:16:20 -0700 [thread overview]
Message-ID: <20150420161620.GE14565@bremse> (raw)
In-Reply-To: <20150418050108.GA32701@mail.bwidawsk.net>
On Fri, Apr 17, 2015 at 10:01:11PM -0700, Ben Widawsky wrote:
> On Thu, Mar 26, 2015 at 12:44:19PM -0700, intel-gfx-request@lists.freedesktop.org wrote:
> > Send Intel-gfx mailing list submissions to
> > intel-gfx@lists.freedesktop.org
> >
> > To subscribe or unsubscribe via the World Wide Web, visit
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > or, via email, send a message with subject or body 'help' to
> > intel-gfx-request@lists.freedesktop.org
> >
> > You can reach the person managing the list at
> > intel-gfx-owner@lists.freedesktop.org
> >
> > When replying, please edit your Subject line so it is more specific
> > than "Re: Contents of Intel-gfx digest..."
> >
> >
> > Today's Topics:
> >
> > 1. [PATCH 04/18] drm/i915: GuC firmware loader (yu.dai@intel.com)
> > 2. [PATCH 05/18] drm/i915: Add firmware version check
> > (yu.dai@intel.com)
> > 3. [PATCH 06/18] drm/i915: Defer default hardware context
> > initialisation until first open (yu.dai@intel.com)
>
> There is a lot of work here from both Vinit and myself in these patches, and
> removing my authorship and the notes I made about Vinit's important
> contributions are not appropriate in all the cases. Our SOBs should be retained
> on several of the GuC patches, and authorship should be retained where
> appropriate.
>
> If you've written a majority of the patch, or vastly changed how the code works,
> then you should change authorship.
And even when the patches are completely rewritten please retain a note
along the lines of "based upon patches from $original_author". Yes I've
recently complained about retaining the original authorship when the patch
is completely rewritten, but removing all trails of the patch's history
isn't the right thing either. Acknowledging other people's contributions
is important.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-20 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.6618.1427399059.3171.intel-gfx@lists.freedesktop.org>
2015-04-18 5:01 ` Intel-gfx Digest, Vol 86, Issue 409 Ben Widawsky
2015-04-20 16:16 ` Daniel Vetter [this message]
2015-04-20 16:29 ` Yu Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420161620.GE14565@bremse \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vinit.azad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox