From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Support Y tiling in MMIO flips
Date: Mon, 20 Apr 2015 09:22:49 -0700 [thread overview]
Message-ID: <20150420162249.GG14565@bremse> (raw)
In-Reply-To: <1429543368-5279-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Mon, Apr 20, 2015 at 04:22:48PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Add Y tiling support to skl_do_mmio_flip.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Sonika Jindal <sonika.jindal@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> Looks like we completely missed this completely parallel instance of plane
> programming code when working on Y tiling support!
>
> Will rotation need supporting here as well?
Oh dear this is a bit ugly. We definitely need either this for 4.1 or take
out the Y-tiling support for 4.1. Rotation only made 4.2, so I think
we're good, but we do indeed need to take rotation into account here too.
And it seems like we also need a pile of igt testcases to make sure
Y-tiling, rotation (even 180 probably) works correctly with pageflips. Yay
for kms_flip growing even more.
> And what about the comment at intel_do_mmio_flip saying this was only
> temporary code?
Well once we have atomic this code will disappear, but it sounds like
that's still a bit off unfortunately.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-20 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 15:22 [PATCH] drm/i915/skl: Support Y tiling in MMIO flips Tvrtko Ursulin
2015-04-20 16:22 ` Daniel Vetter [this message]
2015-04-20 16:38 ` Tvrtko Ursulin
2015-04-20 17:24 ` Daniel Vetter
2015-04-20 17:44 ` Daniel Vetter
2015-04-21 4:55 ` Jindal, Sonika
2015-04-21 9:05 ` Tvrtko Ursulin
2015-04-23 19:12 ` Daniel Vetter
2015-04-20 19:17 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420162249.GG14565@bremse \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox