Re: [PATCH 00/14] skylake display scalers

Konduru, Chandra
2015-04-10T16:29:20Z

> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
> Sent: Friday, April 10, 2015 2:34 AM
> To: Konduru, Chandra
> Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, Daniel
> Subject: Re: [Intel-gfx] [PATCH 00/14] skylake display scalers
>
> On Tue, Apr 07, 2015 at 03:28:33PM -0700, Chandra Konduru wrote:
> > Primary changes in this version are:
> > 1) Moved num_scalers to crtc
> > 2) Changed src/dst rect ranges to #defines
> > 3) Dropped scaling ratios from state instead calculating when needed
> > 4) Dropped filter from scaler
> > 5) Squashed helper functions from standalone patches into patch where
> > 1st used
> > 6) Kept sprite src tect in 16.16 format
> >
> > Though changes are minor but they got sprinkled into multiple patches.
> >
> > Sending full patch series for completeness. Individual patch headers
> > have additional details on changes. This series should cleanly merge
> > to latest drm-intel-nighly.
> >
> > Chandra Konduru (14):
> > drm: Adding drm helper function drm_plane_from_index().
> > drm/i915: Register definitions for skylake scalers
> > drm/i915: skylake scaler structure definitions
> > drm/i915: Initialize plane colorkey to NONE
> > drm/i915: Initialize skylake scalers
> > drm/i915: Keep sprite plane src rect in 16.16 format
> > drm/i915: Dump scaler_state too as part of dumping crtc_state
> > drm/i915: Preserve scaler state when clearing crtc_state
> > drm/i915: setup scalers for crtc_compute_config
> > drm/i915: Ensure setting up scalers into staged crtc_state
> > drm/i915: copy staged scaler state from drm state to crtc->config.
> > drm/i915: skylake panel fitting using shared scalers
> > drm/i915: skylake primary plane scaling using shared scalers
> > drm/i915: skylake sprite plane scaling using shared scalers
>
> Which igt do cover plane scaling? Do we have enough test coverage already or
> have a missed the igt patch series for this feature work?
> -Daniel
Earlier I submitted igt patch (2 patches) series with two kms tests:
kms_plane_scaling - to cover various plane scaling scaling
kms_panel_fitting - to cover panel fitting and also panel fitting along with plane scaling
>
> >
> > drivers/gpu/drm/drm_crtc.c | 22 ++
> > drivers/gpu/drm/i915/i915_reg.h | 115 +++++++++
> > drivers/gpu/drm/i915/intel_atomic.c | 163 +++++++++++++
> > drivers/gpu/drm/i915/intel_display.c | 441
> +++++++++++++++++++++++++++++++---
> > drivers/gpu/drm/i915/intel_dp.c | 8 +
> > drivers/gpu/drm/i915/intel_drv.h | 76 ++++++
> > drivers/gpu/drm/i915/intel_sprite.c | 83 +++++--
> > include/drm/drm_crtc.h | 1 +
> > 8 files changed, 855 insertions(+), 54 deletions(-)
> >
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch