Re: [PATCH 00/14] skylake display scalers

Konduru, Chandra
2015-04-09T22:22:20Z

> -----Original Message-----
> From: Roper, Matthew D
> Sent: Thursday, April 09, 2015 3:12 PM
> To: Konduru, Chandra
> Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, Ander
> Subject: Re: [PATCH 00/14] skylake display scalers
>
> On Thu, Apr 09, 2015 at 02:53:38PM -0700, Matt Roper wrote:
> > On Tue, Apr 07, 2015 at 03:28:33PM -0700, Chandra Konduru wrote:
> > > Primary changes in this version are:
> > > 1) Moved num_scalers to crtc
> > > 2) Changed src/dst rect ranges to #defines
> > > 3) Dropped scaling ratios from state instead calculating when needed
> > > 4) Dropped filter from scaler
> > > 5) Squashed helper functions from standalone patches into patch
> > > where 1st used
> > > 6) Kept sprite src tect in 16.16 format
> > >
> > > Though changes are minor but they got sprinkled into multiple patches.
> > >
> > > Sending full patch series for completeness. Individual patch headers
> > > have additional details on changes. This series should cleanly merge
> > > to latest drm-intel-nighly.
> >
> > Okay, this is looking pretty good now. I only spotted a single issue
> > (which affects patches #6 and #13); all of the other patches are
> >
> > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> >
> > I also requested an update to the commit message of patch #9, but the
> > code itself looks fine and still has my r-b.
>
> Oh, one thing I forgot to mention. My understanding is that while we're on
> transitional plane helpers, your scaler setup code still isn't going to get run
> properly for legacy SetPlane ioctl calls (correct me if I'm wrong and overlooked
> a change related to that). I know Maarten is working on addressing the issues
> with the full atomic helpers properly, but I also have a bit of a workaround patch
> that might be useful in the time being here:
>
> http://patchwork.freedesktop.org/patch/46773/
>
> Do you think we need to make sure we're switched back to the full atomic
> helpers via one of those solutions before merging your series here?
This isn't really needed because I did run all my tests with both current transitional helpers
and switch to full atomic helpers and made sure test run properly in both cases.
Only diff is with transitional helpers scaling feature isn't available with full atomic
helpers scaling is available. This series can be merged into current nightly.

>
>
> Matt
>
> >
> >
> > Matt
> >
> > >
> > > Chandra Konduru (14):
> > > drm: Adding drm helper function drm_plane_from_index().
> > > drm/i915: Register definitions for skylake scalers
> > > drm/i915: skylake scaler structure definitions
> > > drm/i915: Initialize plane colorkey to NONE
> > > drm/i915: Initialize skylake scalers
> > > drm/i915: Keep sprite plane src rect in 16.16 format
> > > drm/i915: Dump scaler_state too as part of dumping crtc_state
> > > drm/i915: Preserve scaler state when clearing crtc_state
> > > drm/i915: setup scalers for crtc_compute_config
> > > drm/i915: Ensure setting up scalers into staged crtc_state
> > > drm/i915: copy staged scaler state from drm state to crtc->config.
> > > drm/i915: skylake panel fitting using shared scalers
> > > drm/i915: skylake primary plane scaling using shared scalers
> > > drm/i915: skylake sprite plane scaling using shared scalers
> > >
> > > drivers/gpu/drm/drm_crtc.c | 22 ++
> > > drivers/gpu/drm/i915/i915_reg.h | 115 +++++++++
> > > drivers/gpu/drm/i915/intel_atomic.c | 163 +++++++++++++
> > > drivers/gpu/drm/i915/intel_display.c | 441
> +++++++++++++++++++++++++++++++---
> > > drivers/gpu/drm/i915/intel_dp.c | 8 +
> > > drivers/gpu/drm/i915/intel_drv.h | 76 ++++++
> > > drivers/gpu/drm/i915/intel_sprite.c | 83 +++++--
> > > include/drm/drm_crtc.h | 1 +
> > > 8 files changed, 855 insertions(+), 54 deletions(-)
> > >
> > > --
> > > 1.7.9.5
> > >
> >
> > --
> > Matt Roper
> > Graphics Software Engineer
> > IoTG Platform Enabling & Development
> > Intel Corporation
> > (916) 356-2795
>
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> (916) 356-2795