From: Damien Lespiau <damien.lespiau@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix for_each_digital_port
Date: Mon, 27 Apr 2015 18:18:42 +0100 [thread overview]
Message-ID: <20150427171842.GA3503@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150427171545.GJ16354@strange.amr.corp.intel.com>
On Mon, Apr 27, 2015 at 06:15:45PM +0100, Damien Lespiau wrote:
> On Mon, Apr 27, 2015 at 06:05:31PM +0100, Damien Lespiau wrote:
> > On Fri, Apr 17, 2015 at 02:58:10PM +0300, Imre Deak wrote:
> > > We should check if a given encoder is of a digital type before casting
> > > it to a digital port object. This broke on HSW when iterating the VGA
> > > encoder.
> > >
> > > Introduced in
> > > commit b403745c84592b26a0713e6944c2b109f6df5c82
> > > Author: Damien Lespiau <damien.lespiau@intel.com>
> > > Date: Mon Aug 4 22:01:33 2014 +0100
> > >
> > > drm/i915: Iterate through the initialized DDIs to prepare their buffers
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90067
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> >
> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Huuum, scrap that r-b, I think we're missing PORT_E initialization on
> HSW, because that's the one driver the CRT encoder through FDI.
Which is exactly what Paulo found as well... Did we already mentionned
how hard is was to follow reviews :)
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-04-27 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 11:58 [PATCH] drm/i915: fix for_each_digital_port Imre Deak
2015-04-17 12:27 ` Imre Deak
2015-04-17 12:36 ` Paulo Zanoni
2015-04-17 16:29 ` Imre Deak
2015-04-17 16:31 ` [PATCH v2 1/2] drm/i915: factor out ddi_get_encoder_port Imre Deak
2015-04-27 17:24 ` Damien Lespiau
2015-04-17 16:31 ` [PATCH v2 2/2] drm/i915: fix intel_prepare_ddi Imre Deak
2015-04-23 21:37 ` shuang.he
2015-04-27 17:29 ` Damien Lespiau
2015-04-30 9:37 ` Jani Nikula
2015-04-23 21:39 ` [PATCH] drm/i915: fix for_each_digital_port shuang.he
2015-04-27 17:05 ` Damien Lespiau
2015-04-27 17:15 ` Damien Lespiau
2015-04-27 17:18 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427171842.GA3503@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox