From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories Date: Thu, 30 Apr 2015 17:58:47 +0300 Message-ID: <20150430145847.GA18908@intel.com> References: <20150430104745.GA25329@mwanda> <1430402374-16855-1-git-send-email-michel.thierry@intel.com> <20150430142211.GZ18908@intel.com> <55423D51.5060205@intel.com> <554241E9.1020400@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 685FC6E83E for ; Thu, 30 Apr 2015 07:58:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <554241E9.1020400@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMzAsIDIwMTUgYXQgMDM6NTM6MjlQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMzAvMDQvMTUgMTU6MzMsIE1pY2hlbCBUaGllcnJ5IHdyb3RlOgo+ID4gT24gNC8z MC8yMDE1IDM6MjIgUE0sIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+PiBPbiBUaHUsIEFwciAz MCwgMjAxNSBhdCAwMjo1OTozNFBNICswMTAwLCBNaWNoZWwgVGhpZXJyeSB3cm90ZToKPiA+Pj4g VGhlIHBhdGNoIDY5ODc2YmVkN2UwMDhmNWZlMDE1MzhhMmQ0N2MwOWYyODYyMTI5ZDA6ICJkcm0v aTkxNS9nZW44Ogo+ID4+PiBwYWdlIGRpcmVjdG9yaWVzIHJld29yayBhbGxvY2F0aW9uIiBhZGRl ZCBhbiBvdmVyZmxvdyB3YXJuaW5nLCBidXQgdGhlCj4gPj4+IG1hc2sgaGFkIGFuIGV4dHJhIDAu IFVzZSB0eXBvLXByb25lIG9wdGlvbiBzdWdnZXN0ZWQgYnkgRGF2ZSBpbnN0ZWFkLgo+ID4+Pgo+ ID4+PiBUaGlzIGNoZWNrIHdpbGwgYmUgdW5uZWNlc3NhcnkgYWZ0ZXIgZ2VuOF9hbGxvY192YV9y YW5nZSBoYW5kbGVzIG1vcmUKPiA+Pj4gdGhhbiA0IFBEUHMgKDQ4YiBhZGRyZXNzaW5nKS4KPiA+ Pj4KPiA+Pj4gUmVwb3J0ZWQtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xl LmNvbT4KPiA+Pj4gQ2M6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4g Pj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5j b20+Cj4gPj4+IC0tLQo+ID4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5j IHwgNCArKy0tCj4gPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPiA+Pj4KPiA+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX2d0dC5jCj4gPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMK PiA+Pj4gaW5kZXggNmZhZTZiZC4uNmQ4OTRmYyAxMDA2NDQKPiA+Pj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiA+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmMKPiA+Pj4gQEAgLTc1Niw4ICs3NTYsOCBAQCBzdGF0aWMgaW50Cj4g Pj4+IGdlbjhfcHBndHRfYWxsb2NfcGFnZV9kaXJlY3RvcmllcyhzdHJ1Y3QgaTkxNV9od19wcGd0 dCAqcHBndHQsCj4gPj4+Cj4gPj4+ICAgICAgIFdBUk5fT04oIWJpdG1hcF9lbXB0eShuZXdfcGRz LCBHRU44X0xFR0FDWV9QRFBFUykpOwo+ID4+Pgo+ID4+PiAtICAgIC8qIEZJWE1FOiBQUEdUVCBj b250YWluZXJfb2Ygd29uJ3Qgd29yayBmb3IgNjRiICovCj4gPj4+IC0gICAgV0FSTl9PTigoc3Rh cnQgKyBsZW5ndGgpID4gMHg4MDAwMDAwMDBVTEwpOwo+ID4+PiArICAgIC8qIEZJWE1FOiB1cHBl ciBib3VuZCBtdXN0IG5vdCBvdmVyZmxvdyAzMSBiaXRzICAqLwo+ID4+PiArICAgIFdBUk5fT04o KHN0YXJ0ICsgbGVuZ3RoKSAmICh+MFVMTCA8PCAzMSkpOwo+ID4+Cj4gPj4gV2h5IGlzIGl0IDMx IGFuZCBub3QgMzI/Cj4gPiAKPiA+IFJpZ2h0LCB0aGUgY2hlY2sgcmVhbGx5IHNob3VsZCBiZSAo c3RhcnQgKyBsZW5ndGgpID49IDB4MTAwMDAwMDAwVUxMLgo+IAo+IFNvbWV0aGluZyB3aXRoICcz MicgaW4gaXQgbWlnaHQgYmUgbW9yZSBvYnZpb3VzIGFuZCBzYXZlIGFueW9uZSBoYXZpbmcKPiB0 byBjb3VudCB0aGUgemVyb2VzIC4uLiBhbmQgYSBjb21tZW50IHRoYXQgYWxzbyBtZW50aW9uZWQg dGhlIGxpbWl0Ogo+IAo+IAkvKiBGSVhNRTogZm9yIG5vdywgdXBwZXIgYm91bmQgbXVzdCBmaXQg aW4gMzIgYml0cyAgKi8KPiAKPiAJV0FSTl9PTigoc3RhcnQgKyBsZW5ndGgpID49ICgxVUxMIDw8 IDMyKSkKClRoaXMgd291bGQgbWF0Y2ggdGhlICcxVUxMPDwzMicgdXNlZCBpbiB0aGUgcHBndHQg aW5pdC4KCj4gCVdBUk5fT04oKHN0YXJ0ICsgbGVuZ3RoKSAmICh+MFVMTCA8PCAzMikpCj4gCVdB Uk5fT04oKHN0YXJ0ICsgbGVuZ3RoKSA+PiAzMikgIT0gMCkKPiAKPiAuRGF2ZS4KCi0tIApWaWxs ZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==