Re: [PATCH] drm/i915: Simplify cmd-parser DISPATCH_SECURE check

From: Daniel Vetter <daniel@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	"Reviewed-by: Mika Kuoppala" <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Simplify cmd-parser DISPATCH_SECURE check
Date: Mon, 4 May 2015 11:23:04 +0200	[thread overview]
Message-ID: <20150504092303.GR30184@phenom.ffwll.local> (raw)
In-Reply-To: <1430729654-19192-1-git-send-email-daniel.vetter@ffwll.ch>

On Mon, May 04, 2015 at 10:54:14AM +0200, Daniel Vetter wrote:
> i915_needs_cmd_parser already checks that for us.
> 
> Suggested-by: Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

Oops, r-b obviously shouldn't be here, copypasta-fail.
-Daniel

> Cc: Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index d2e21c549756..7ab63d9d7dc5 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -1559,8 +1559,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
>  		 * don't want that set when the command parser is
>  		 * enabled.
>  		 */
> -		if (USES_PPGTT(dev))
> -			dispatch_flags |= I915_DISPATCH_SECURE;
> +		dispatch_flags |= I915_DISPATCH_SECURE;
>  
>  		exec_start = 0;
>  	}
> -- 
> 2.1.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx