From: Daniel Vetter <daniel@ffwll.ch>
To: Chandra Konduru <chandra.konduru@intel.com>
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org,
ville.syrjala@intel.com
Subject: Re: [PATCH] drm/i915: Adding dbuf support for skl nv12 format.
Date: Mon, 4 May 2015 17:01:21 +0200 [thread overview]
Message-ID: <20150504150121.GR30184@phenom.ffwll.local> (raw)
In-Reply-To: <1430174857-19204-1-git-send-email-chandra.konduru@intel.com>
On Mon, Apr 27, 2015 at 03:47:37PM -0700, Chandra Konduru wrote:
> Skylake nv12 format requires dbuf (aka. ddb) calculations
> and programming for each of y and uv sub-planes. Made minor
> changes to reuse current dbuf calculations and programming
> for uv plane. i.e., with this change, existing computation
> is used for either packed format or uv portion of nv12
> depending on incoming format. Added new code for dbuf
> computation and programming for y plane.
>
> This patch is a pre-requisite for adding NV12 format support.
> Actual nv12 support is coming in later patches.
>
> Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
Just aside (and not a blocker for this patch really). Do we have nv12
subtest in all the relevant plane tests (rotation, scaling, ...) to
exercise this code? Not sure whether we can redo the yuv->rgb conversion
correctly in software to match hw, might need to pick special colors that
convert accurately.
Anyway given how often we've broken the sprite code I really think we need
full functional tests (i.e. including crc checks).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-04 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 22:47 [PATCH] drm/i915: Adding dbuf support for skl nv12 format Chandra Konduru
2015-04-28 12:12 ` shuang.he
2015-05-04 15:01 ` Daniel Vetter [this message]
2015-05-04 23:40 ` Konduru, Chandra
2015-05-06 9:27 ` Daniel Vetter
2015-05-08 14:31 ` Damien Lespiau
2015-05-08 17:23 ` Damien Lespiau
2015-05-11 9:46 ` Daniel Vetter
2015-05-11 9:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504150121.GR30184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chandra.konduru@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox