From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms
Date: Wed, 6 May 2015 13:11:32 +0200 [thread overview]
Message-ID: <20150506111132.GW30184@phenom.ffwll.local> (raw)
In-Reply-To: <87mw1j6tgj.fsf@intel.com>
On Tue, May 05, 2015 at 04:32:12PM +0300, Jani Nikula wrote:
> On Tue, 05 May 2015, Sivakumar Thulasimani <sivakumar.thulasimani@intel.com> wrote:
> > two points
> > 1) The eDP spec says Audio is optional so it is allowed to have audio,
> > but i am yet to come across any eDP panel that supports Audio.
> > 2) Also, there is no support for audio in DDI A port as well :)
> >
> > So please change the check to
> >
> > if (!is_edp(encoder))
>
> Because the actual limitation we have is "no audio on port A" instead of
> "no audio on eDP", I insist we check for port A. Patch below.
Yes this is the correct check. On desktop all-in-ones edp is usually on
port D, which does support audio.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-05-06 11:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 14:20 [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms Jani Nikula
2015-05-04 14:20 ` [PATCH 2/2] drm/i915/audio: do not mess with audio registers if port is invalid Jani Nikula
2015-05-04 20:45 ` shuang.he
2015-05-05 5:33 ` Sivakumar Thulasimani
2015-05-06 11:11 ` Daniel Vetter
2015-05-05 5:31 ` [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms Sivakumar Thulasimani
2015-05-05 9:09 ` Jani Nikula
2015-05-05 12:18 ` Sivakumar Thulasimani
2015-05-05 13:32 ` Jani Nikula
2015-05-05 13:38 ` Sivakumar Thulasimani
2015-05-05 13:43 ` Sivakumar Thulasimani
2015-05-06 9:30 ` Jani Nikula
2015-05-06 11:11 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506111132.GW30184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox