Re: [PATCH 06/11] drm/i915: Add NV12 as supported format for primary plane

From: Daniel Vetter <daniel@ffwll.ch>
To: "Konduru, Chandra" <chandra.konduru@intel.com>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Syrjala, Ville" <ville.syrjala@intel.com>
Subject: Re: [PATCH 06/11] drm/i915: Add NV12 as supported format for primary plane
Date: Fri, 8 May 2015 09:13:42 +0200	[thread overview]
Message-ID: <20150508071342.GI30184@phenom.ffwll.local> (raw)
In-Reply-To: <76A9B330A4D78C4D99CB292C4CC06C0E36FC8B64@fmsmsx101.amr.corp.intel.com>

On Fri, May 08, 2015 at 02:29:30AM +0000, Konduru, Chandra wrote:
> > > +/* Primary plane formats for gen >= 9 */
> > > +static const uint32_t intel_primary_formats_gen9[] = {
> > > +	COMMON_PRIMARY_FORMATS, \
> > > +	DRM_FORMAT_XBGR8888,
> > > +	DRM_FORMAT_ABGR8888,
> > > +	DRM_FORMAT_XRGB2101010,
> > > +	DRM_FORMAT_ARGB2101010,
> > > +	DRM_FORMAT_XBGR2101010,
> > > +	DRM_FORMAT_ABGR2101010,
> > > +};
> > > +
> > > +static const uint32_t intel_primary_formats_with_nv12_gen9[] = {
> > > +	COMMON_PRIMARY_FORMATS, \
> > > +	DRM_FORMAT_XBGR8888,
> > > +	DRM_FORMAT_ABGR8888,
> > > +	DRM_FORMAT_XRGB2101010,
> > > +	DRM_FORMAT_ARGB2101010,
> > > +	DRM_FORMAT_XBGR2101010,
> > > +	DRM_FORMAT_ABGR2101010,
> > > +	DRM_FORMAT_NV12,
> > > +};
> > 
> > This duplication is a bit unpretty, and we already started to share code
> > with skl sprites to prep for the great unification of plane code for
> > gen9+. Can you please do the same with these tables? I also like the names
> > in intel_sprite.c more. Follow-up patch or squashed in both ok.
> > -Daniel
> Hi Daniel,
> I planned to have single list with nv12 at the end of the list.
> And in plane_init report the list as is for nv12 capable planes and
> index-1 for non-nv12 planes.
> But the earlier (a while ago) feedback from you is, duplication is
> cheaper so duplicated them instead of playing trick with array index.
>  
> Regarding unification, currently skl_plane_formats[] has different formats 
> than intel_primary_formats_gen9[]. To have a unified table for both primary
> and sprite planes requires testing delta formats on both primary and sprite
> planes respectively with respective i-g-t tests. This is not being planned as 
> part of nv12 feature.

Well someone eventually needs to do it, I hoped I could sign you up for
that ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx