From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
Peter Antoine <peter.antoine@intel.com>,
daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Warn when execlists changes context without IRQs
Date: Tue, 12 May 2015 10:42:41 +0200 [thread overview]
Message-ID: <20150512084241.GD15256@phenom.ffwll.local> (raw)
In-Reply-To: <20150512081800.GG19022@nuc-i3427.alporthouse.com>
On Tue, May 12, 2015 at 09:18:00AM +0100, Chris Wilson wrote:
> On Tue, May 12, 2015 at 08:42:58AM +0200, Daniel Vetter wrote:
> > On Mon, May 11, 2015 at 09:26:40PM +0100, Chris Wilson wrote:
> > > On Mon, May 11, 2015 at 06:37:14PM +0200, Daniel Vetter wrote:
> > > > On Mon, May 11, 2015 at 04:03:27PM +0100, Peter Antoine wrote:
> > > > > If an batch ends while the IRQs are not turned on the notification can
> > > > > go missing and the GPU can hang. So generate a warning in this case.
> > > > >
> > > > > Signed-off-by: Peter Antoine <peter.antoine@intel.com>
> > > >
> > > > Queued for -next, thanks for the patch.
> > >
> > > Please drop this. We already have the test inside the irq handler. The
> > > instance where you want the guard is during resume, inside
> > > intel_lr_context_render_state_init() where you can even emit an error
> > > code!
> >
> > _unqueue is also called from intel_logical_ring_advance_and_submit and
> > should cover us I hope. And I don't think we should add error handling for
> > this, that has cost of its own.
>
> Pardon? Your explanation for adding it to the *interrupt* handler after
> an existing check is that it also catches the initial submission?
I wanted to add it as low down as possible to increase changes of the
check surviving refactoring. This way it's as close to possible to the
writes to the submit ports. Yes that means it's also run from interrupt
context when requeueing, but I'm fairly meh about that. What's your
concern?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-12 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 15:03 [PATCH] drm/i915: Warn when execlists changes context without IRQs Peter Antoine
2015-05-11 16:37 ` Daniel Vetter
2015-05-11 20:26 ` Chris Wilson
2015-05-12 6:42 ` Daniel Vetter
2015-05-12 8:18 ` Chris Wilson
2015-05-12 8:42 ` Daniel Vetter [this message]
2015-05-12 8:48 ` Chris Wilson
2015-05-15 3:41 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512084241.GD15256@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=peter.antoine@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox