From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: constify find_section in VBT parsing Date: Tue, 12 May 2015 15:06:13 +0300 Message-ID: <20150512120613.GW18908@intel.com> References: <1429100309-21983-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 955B26E5D3 for ; Tue, 12 May 2015 05:06:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1429100309-21983-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMTUsIDIwMTUgYXQgMDM6MTg6MjhQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTWFrZSBpbnB1dCBhbmQgb3V0cHV0IG9mIGZpbmRfc2VjdGlvbiBjb25zdCwgYW5kIGZp eCB0aGUgZmFsbG91dC4gV2UKPiBzaG91bGRuJ3QgbW9kaWZ5IHRoZSBWQlQsIHNvIG1ha2UgdGhl IGNvbXBpbGVyIGhlbHAgdXMgaGVyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMgfCA2MCArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiBpbmRleCBjMDgzNjhjMDNkYWQuLjRlM2YzZjQyNzE3 OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiBAQCAtMzYsMTAgKzM2LDExIEBA Cj4gIAo+ICBzdGF0aWMgaW50IHBhbmVsX3R5cGU7Cj4gIAo+IC1zdGF0aWMgdm9pZCAqCj4gLWZp bmRfc2VjdGlvbihzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiLCBpbnQgc2VjdGlvbl9pZCkKPiArc3Rh dGljIGNvbnN0IHZvaWQgKgo+ICtmaW5kX3NlY3Rpb24oY29uc3Qgdm9pZCAqX2JkYiwgaW50IHNl Y3Rpb25faWQpCj4gIHsKPiAtCXU4ICpiYXNlID0gKHU4ICopYmRiOwo+ICsJY29uc3Qgc3RydWN0 IGJkYl9oZWFkZXIgKmJkYiA9IF9iZGI7Cj4gKwljb25zdCB1OCAqYmFzZSA9IF9iZGI7Cj4gIAlp bnQgaW5kZXggPSAwOwo+ICAJdTE2IHRvdGFsLCBjdXJyZW50X3NpemU7Cj4gIAl1OCBjdXJyZW50 X2lkOwo+IEBAIC01Myw3ICs1NCw3IEBAIGZpbmRfc2VjdGlvbihzdHJ1Y3QgYmRiX2hlYWRlciAq YmRiLCBpbnQgc2VjdGlvbl9pZCkKPiAgCQljdXJyZW50X2lkID0gKihiYXNlICsgaW5kZXgpOwo+ ICAJCWluZGV4Kys7Cj4gIAo+IC0JCWN1cnJlbnRfc2l6ZSA9ICooKHUxNiAqKShiYXNlICsgaW5k ZXgpKTsKPiArCQljdXJyZW50X3NpemUgPSAqKChjb25zdCB1MTYgKikoYmFzZSArIGluZGV4KSk7 Cj4gIAkJaW5kZXggKz0gMjsKPiAgCj4gIAkJaWYgKGluZGV4ICsgY3VycmVudF9zaXplID4gdG90 YWwpCj4gQEAgLTY5LDcgKzcwLDcgQEAgZmluZF9zZWN0aW9uKHN0cnVjdCBiZGJfaGVhZGVyICpi ZGIsIGludCBzZWN0aW9uX2lkKQo+ICB9Cj4gIAo+ICBzdGF0aWMgdTE2Cj4gLWdldF9ibG9ja3Np emUodm9pZCAqcCkKPiArZ2V0X2Jsb2Nrc2l6ZShjb25zdCB2b2lkICpwKQo+ICB7Cj4gIAl1MTYg KmJsb2NrX3B0ciwgYmxvY2tfc2l6ZTsKPiAgCj4gQEAgLTM1MCw3ICszNTEsNyBAQCBzdGF0aWMg dm9pZAo+ICBwYXJzZV9zZHZvX3BhbmVsX2RhdGEoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+ICAJCSAgICAgIHN0cnVjdCBiZGJfaGVhZGVyICpiZGIpCj4gIHsKPiAtCXN0cnVj dCBsdmRzX2R2b190aW1pbmcgKmR2b190aW1pbmc7Cj4gKwljb25zdCBzdHJ1Y3QgbHZkc19kdm9f dGltaW5nICpkdm9fdGltaW5nOwo+ICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKnBhbmVsX2Zp eGVkX21vZGU7Cj4gIAlpbnQgaW5kZXg7Cj4gIAo+IEBAIC0zNjEsNyArMzYyLDcgQEAgcGFyc2Vf c2R2b19wYW5lbF9kYXRhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCX0K PiAgCj4gIAlpZiAoaW5kZXggPT0gLTEpIHsKPiAtCQlzdHJ1Y3QgYmRiX3Nkdm9fbHZkc19vcHRp b25zICpzZHZvX2x2ZHNfb3B0aW9uczsKPiArCQljb25zdCBzdHJ1Y3QgYmRiX3Nkdm9fbHZkc19v cHRpb25zICpzZHZvX2x2ZHNfb3B0aW9uczsKPiAgCj4gIAkJc2R2b19sdmRzX29wdGlvbnMgPSBm aW5kX3NlY3Rpb24oYmRiLCBCREJfU0RWT19MVkRTX09QVElPTlMpOwo+ICAJCWlmICghc2R2b19s dmRzX29wdGlvbnMpCj4gQEAgLTQwNSw3ICs0MDYsNyBAQCBwYXJzZV9nZW5lcmFsX2ZlYXR1cmVz KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkgICAgICAgc3RydWN0IGJk Yl9oZWFkZXIgKmJkYikKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRldl9wcml2 LT5kZXY7Cj4gLQlzdHJ1Y3QgYmRiX2dlbmVyYWxfZmVhdHVyZXMgKmdlbmVyYWw7Cj4gKwljb25z dCBzdHJ1Y3QgYmRiX2dlbmVyYWxfZmVhdHVyZXMgKmdlbmVyYWw7Cj4gIAo+ICAJZ2VuZXJhbCA9 IGZpbmRfc2VjdGlvbihiZGIsIEJEQl9HRU5FUkFMX0ZFQVRVUkVTKTsKPiAgCWlmIChnZW5lcmFs KSB7Cj4gQEAgLTQzMCw3ICs0MzEsNyBAQCBzdGF0aWMgdm9pZAo+ICBwYXJzZV9nZW5lcmFsX2Rl ZmluaXRpb25zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICBzdHJ1 Y3QgYmRiX2hlYWRlciAqYmRiKQo+ICB7Cj4gLQlzdHJ1Y3QgYmRiX2dlbmVyYWxfZGVmaW5pdGlv bnMgKmdlbmVyYWw7Cj4gKwljb25zdCBzdHJ1Y3QgYmRiX2dlbmVyYWxfZGVmaW5pdGlvbnMgKmdl bmVyYWw7Cj4gIAo+ICAJZ2VuZXJhbCA9IGZpbmRfc2VjdGlvbihiZGIsIEJEQl9HRU5FUkFMX0RF RklOSVRJT05TKTsKPiAgCWlmIChnZW5lcmFsKSB7Cj4gQEAgLTQ0NywxMCArNDQ4LDEwIEBAIHBh cnNlX2dlbmVyYWxfZGVmaW5pdGlvbnMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqCj4g LWNoaWxkX2RldmljZV9wdHIoc3RydWN0IGJkYl9nZW5lcmFsX2RlZmluaXRpb25zICpwX2RlZnMs IGludCBpKQo+ICtzdGF0aWMgY29uc3QgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqCj4gK2No aWxkX2RldmljZV9wdHIoY29uc3Qgc3RydWN0IGJkYl9nZW5lcmFsX2RlZmluaXRpb25zICpwX2Rl ZnMsIGludCBpKQo+ICB7Cj4gLQlyZXR1cm4gKHZvaWQgKikgJnBfZGVmcy0+ZGV2aWNlc1tpICog cF9kZWZzLT5jaGlsZF9kZXZfc2l6ZV07Cj4gKwlyZXR1cm4gKGNvbnN0IHZvaWQgKikgJnBfZGVm cy0+ZGV2aWNlc1tpICogcF9kZWZzLT5jaGlsZF9kZXZfc2l6ZV07Cj4gIH0KPiAgCj4gIHN0YXRp YyB2b2lkCj4gQEAgLTQ1OCw4ICs0NTksOCBAQCBwYXJzZV9zZHZvX2RldmljZV9tYXBwaW5nKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICBzdHJ1Y3QgYmRiX2hlYWRl ciAqYmRiKQo+ICB7Cj4gIAlzdHJ1Y3Qgc2R2b19kZXZpY2VfbWFwcGluZyAqcF9tYXBwaW5nOwo+ IC0Jc3RydWN0IGJkYl9nZW5lcmFsX2RlZmluaXRpb25zICpwX2RlZnM7Cj4gLQl1bmlvbiBjaGls ZF9kZXZpY2VfY29uZmlnICpwX2NoaWxkOwo+ICsJY29uc3Qgc3RydWN0IGJkYl9nZW5lcmFsX2Rl ZmluaXRpb25zICpwX2RlZnM7Cj4gKwljb25zdCB1bmlvbiBjaGlsZF9kZXZpY2VfY29uZmlnICpw X2NoaWxkOwo+ICAJaW50IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+ICAJdTE2CWJsb2Nr X3NpemU7Cj4gIAo+IEBAIC01NDcsNyArNTQ4LDcgQEAgc3RhdGljIHZvaWQKPiAgcGFyc2VfZHJp dmVyX2ZlYXR1cmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkgICAg ICAgc3RydWN0IGJkYl9oZWFkZXIgKmJkYikKPiAgewo+IC0Jc3RydWN0IGJkYl9kcml2ZXJfZmVh dHVyZXMgKmRyaXZlcjsKPiArCWNvbnN0IHN0cnVjdCBiZGJfZHJpdmVyX2ZlYXR1cmVzICpkcml2 ZXI7Cj4gIAo+ICAJZHJpdmVyID0gZmluZF9zZWN0aW9uKGJkYiwgQkRCX0RSSVZFUl9GRUFUVVJF Uyk7Cj4gIAlpZiAoIWRyaXZlcikKPiBAQCAtNTczLDkgKzU3NCw5IEBAIHBhcnNlX2RyaXZlcl9m ZWF0dXJlcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHN0YXRpYyB2b2lk Cj4gIHBhcnNlX2VkcChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHN0cnVjdCBi ZGJfaGVhZGVyICpiZGIpCj4gIHsKPiAtCXN0cnVjdCBiZGJfZWRwICplZHA7Cj4gLQlzdHJ1Y3Qg ZWRwX3Bvd2VyX3NlcSAqZWRwX3BwczsKPiAtCXN0cnVjdCBlZHBfbGlua19wYXJhbXMgKmVkcF9s aW5rX3BhcmFtczsKPiArCWNvbnN0IHN0cnVjdCBiZGJfZWRwICplZHA7Cj4gKwljb25zdCBzdHJ1 Y3QgZWRwX3Bvd2VyX3NlcSAqZWRwX3BwczsKPiArCWNvbnN0IHN0cnVjdCBlZHBfbGlua19wYXJh bXMgKmVkcF9saW5rX3BhcmFtczsKPiAgCj4gIAllZHAgPSBmaW5kX3NlY3Rpb24oYmRiLCBCREJf RURQKTsKPiAgCWlmICghZWRwKSB7Cj4gQEAgLTY4MCw4ICs2ODEsOCBAQCBwYXJzZV9lZHAoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+ ICBzdGF0aWMgdm9pZAo+ICBwYXJzZV9wc3Ioc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LCBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+ICB7Cj4gLQlzdHJ1Y3QgYmRiX3BzciAqcHNy Owo+IC0Jc3RydWN0IHBzcl90YWJsZSAqcHNyX3RhYmxlOwo+ICsJY29uc3Qgc3RydWN0IGJkYl9w c3IgKnBzcjsKPiArCWNvbnN0IHN0cnVjdCBwc3JfdGFibGUgKnBzcl90YWJsZTsKPiAgCj4gIAlw c3IgPSBmaW5kX3NlY3Rpb24oYmRiLCBCREJfUFNSKTsKPiAgCWlmICghcHNyKSB7Cj4gQEAgLTc5 MSwxMSArNzkyLDEyIEBAIHN0YXRpYyB1OCAqZ290b19uZXh0X3NlcXVlbmNlKHU4ICpkYXRhLCBp bnQgKnNpemUpCj4gIHN0YXRpYyB2b2lkCj4gIHBhcnNlX21pcGkoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+ICB7Cj4gLQlzdHJ1Y3Qg YmRiX21pcGlfY29uZmlnICpzdGFydDsKPiAtCXN0cnVjdCBiZGJfbWlwaV9zZXF1ZW5jZSAqc2Vx dWVuY2U7Cj4gLQlzdHJ1Y3QgbWlwaV9jb25maWcgKmNvbmZpZzsKPiAtCXN0cnVjdCBtaXBpX3Bw c19kYXRhICpwcHM7Cj4gLQl1OCAqZGF0YSwgKnNlcV9kYXRhOwo+ICsJY29uc3Qgc3RydWN0IGJk Yl9taXBpX2NvbmZpZyAqc3RhcnQ7Cj4gKwljb25zdCBzdHJ1Y3QgYmRiX21pcGlfc2VxdWVuY2Ug KnNlcXVlbmNlOwo+ICsJY29uc3Qgc3RydWN0IG1pcGlfY29uZmlnICpjb25maWc7Cj4gKwljb25z dCBzdHJ1Y3QgbWlwaV9wcHNfZGF0YSAqcHBzOwo+ICsJdTggKmRhdGE7CgpJdCB3b3VsZCBzZWVt IHRoaXMgZ3V5IGNvdWxkIGJlIGNvbnN0aWZpZWQgYXMgd2VsbCwgd2l0aCBhIGJpdCBvZiBleHRy YQplZmZvcnQgdGhhdCBpcy4KCkJ1dCB0aGUgcGF0Y2ggYXMgaXMgbG9va3MgcmVhc29uYWJsZSBz bzoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cgo+ICsJY29uc3QgdTggKnNlcV9kYXRhOwo+ICAJaW50IGksIHBhbmVsX2lkLCBzZXFf c2l6ZTsKPiAgCXUxNiBibG9ja19zaXplOwo+ICAKPiBAQCAtMTA2Myw4ICsxMDY1LDkgQEAgc3Rh dGljIHZvaWQKPiAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ICAJCSAgICAgICBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+ICB7Cj4gLQlz dHJ1Y3QgYmRiX2dlbmVyYWxfZGVmaW5pdGlvbnMgKnBfZGVmczsKPiAtCXVuaW9uIGNoaWxkX2Rl dmljZV9jb25maWcgKnBfY2hpbGQsICpjaGlsZF9kZXZfcHRyOwo+ICsJY29uc3Qgc3RydWN0IGJk Yl9nZW5lcmFsX2RlZmluaXRpb25zICpwX2RlZnM7Cj4gKwljb25zdCB1bmlvbiBjaGlsZF9kZXZp Y2VfY29uZmlnICpwX2NoaWxkOwo+ICsJdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqY2hpbGRf ZGV2X3B0cjsKPiAgCWludCBpLCBjaGlsZF9kZXZpY2VfbnVtLCBjb3VudDsKPiAgCXUxNglibG9j a19zaXplOwo+ICAKPiBAQCAtMTEyMSw4ICsxMTI0LDcgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmco c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAKPiAgCQljaGlsZF9kZXZfcHRy ID0gZGV2X3ByaXYtPnZidC5jaGlsZF9kZXYgKyBjb3VudDsKPiAgCQljb3VudCsrOwo+IC0JCW1l bWNweSgodm9pZCAqKWNoaWxkX2Rldl9wdHIsICh2b2lkICopcF9jaGlsZCwKPiAtCQkJCQlzaXpl b2YoKnBfY2hpbGQpKTsKPiArCQltZW1jcHkoY2hpbGRfZGV2X3B0ciwgcF9jaGlsZCwgc2l6ZW9m KCpwX2NoaWxkKSk7Cj4gIAl9Cj4gIAlyZXR1cm47Cj4gIH0KPiAtLSAKPiAyLjEuNAo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=