From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/10] drm/i915/skl: Don't advertize ARGB2101010 and ABGR2101010
Date: Tue, 12 May 2015 18:48:27 +0200 [thread overview]
Message-ID: <20150512164827.GK15256@phenom.ffwll.local> (raw)
In-Reply-To: <20150512161847.GC15782@strange.ger.corp.intel.com>
On Tue, May 12, 2015 at 05:18:47PM +0100, Damien Lespiau wrote:
> On Tue, May 12, 2015 at 06:13:25PM +0200, Daniel Vetter wrote:
> > On Tue, May 12, 2015 at 04:13:19PM +0100, Damien Lespiau wrote:
> > > While we have been historically exposing those formats, but the hardware
> > > doesn't do anything with the alpha bits. The DDX doesn't seem to
> > > particularly care about those formats either, so just expose the
> > > XRGB/XBGR variants.
> > >
> > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> >
> > We have this problem with all the primary planes. Imo we should remove
> > this everywhere, since the ddx doesn't seem to care.
>
> Well technically that'd be breaking ABI (very unlikely, but still). So
> I'd rather have this SKL-specific patch (because we haven't committed to
> SKL just yet) separate from the patch removing the formats for previous
> platforms in case we need to revert. I'll cook the patch for previous
> platform as a follow up.
It's only breaking ABI if someone notices, which is wiggle room we exploit
a _lot_ to fix up past mistakes. I'm ok with merging the skl and pre-skl
parts as two patches in case of reverting, but I really think we should do
them all in one go.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-12 16:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 15:13 [PATCH 00/10] Expose the same formats for SKL primary/sprite planes Damien Lespiau
2015-05-12 15:13 ` [PATCH 01/10] drm/i915/skl: Leave a new line between variable declarations and code Damien Lespiau
2015-05-14 5:19 ` Konduru, Chandra
2015-05-12 15:13 ` [PATCH 02/10] drm/i915/skl: Add a new line before return Damien Lespiau
2015-05-14 5:20 ` Konduru, Chandra
2015-05-12 15:13 ` [PATCH 03/10] drm/i915/skl: Rename a local variable to fit in 80 chars Damien Lespiau
2015-05-12 16:20 ` Ville Syrjälä
2015-05-14 5:20 ` Konduru, Chandra
2015-05-12 15:13 ` [PATCH 04/10] drm/i915/skl: Replace BUG() by MISSING_CASE() in skl_plane_ctl_format() Damien Lespiau
2015-05-14 5:24 ` Konduru, Chandra
2015-05-12 15:13 ` [PATCH 05/10] drm/i915/skl: Support the advertized index format Damien Lespiau
2015-05-14 5:24 ` Konduru, Chandra
2015-05-12 15:13 ` [PATCH 06/10] drm/i915: Don't use the intel_ prefix for gen-specific data Damien Lespiau
2015-05-12 16:04 ` Daniel Vetter
2015-05-12 16:09 ` Daniel Vetter
2015-05-12 15:13 ` [PATCH 07/10] drm/i915/skl: Don't advertize ARGB2101010 and ABGR2101010 Damien Lespiau
2015-05-12 16:13 ` Daniel Vetter
2015-05-12 16:18 ` Damien Lespiau
2015-05-12 16:48 ` Daniel Vetter [this message]
2015-05-12 16:29 ` Ville Syrjälä
2015-05-12 15:13 ` [PATCH 08/10] drm/i915/skl: Make primary and sprite plane advertize the same formats Damien Lespiau
2015-05-12 16:14 ` Daniel Vetter
2015-05-12 16:33 ` Ville Syrjälä
2015-05-12 15:13 ` [PATCH 09/10] drm/i915/skl: Factor skl_plane_get_formats() Damien Lespiau
2015-05-12 15:13 ` [PATCH 10/10] drm/i915: Make the sprite formats const Damien Lespiau
2015-05-12 16:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512164827.GK15256@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox