From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 37/42] drm/i915: swap state correctly in intel_atomic_commit Date: Tue, 12 May 2015 19:03:00 +0200 Message-ID: <20150512170300.GO15256@phenom.ffwll.local> References: <1431354318-11995-1-git-send-email-maarten.lankhorst@linux.intel.com> <1431354318-11995-38-git-send-email-maarten.lankhorst@linux.intel.com> <20150512130331.GU15256@phenom.ffwll.local> <55520B2D.2020407@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 48BC66E54B for ; Tue, 12 May 2015 10:00:40 -0700 (PDT) Received: by wizk4 with SMTP id k4so163036585wiz.1 for ; Tue, 12 May 2015 10:00:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55520B2D.2020407@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMTIsIDIwMTUgYXQgMDQ6MTY6MTNQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTItMDUtMTUgb20gMTU6MDMgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gTW9uLCBNYXkgMTEsIDIwMTUgYXQgMDQ6MjU6MTNQTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gY3J0Yy0+Y29uZmlnIGlzIGdvbmUsIHN3YXAgc3dhcCBzd2FwLiA6 RAo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFu a2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfYXRvbWljLmMgIHwgMzYgKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8ICA3ICsrKysr LS0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDM2IGRlbGV0aW9ucygt KQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21p Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMKPiA+PiBpbmRleCBhY2U2 YWVlYjEzNTkuLjAzMTVkYzQ0YjE3YSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9hdG9taWMuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2F0b21pYy5jCj4gPj4gQEAgLTEzMCw3ICsxMzAsNiBAQCBpbnQgaW50ZWxfYXRvbWljX2NvbW1p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJCQlib29sIGFzeW5jKQo+ID4+ICB7Cj4g Pj4gIAlpbnQgcmV0Owo+ID4+IC0JaW50IGk7Cj4gPj4gIAo+ID4+ICAJaWYgKGFzeW5jKSB7Cj4g Pj4gIAkJRFJNX0RFQlVHX0tNUygiaTkxNSBkb2VzIG5vdCB5ZXQgc3VwcG9ydCBhc3luYyBjb21t aXRcbiIpOwo+ID4+IEBAIC0xNDIsNDggKzE0MSwxNyBAQCBpbnQgaW50ZWxfYXRvbWljX2NvbW1p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJCXJldHVybiByZXQ7Cj4gPj4gIAo+ID4+ ICAJLyogUG9pbnQgb2Ygbm8gcmV0dXJuICovCj4gPj4gKwlkcm1fYXRvbWljX2hlbHBlcl9zd2Fw X3N0YXRlKGRldiwgc3RhdGUpOwo+ID4+ICAKPiA+PiAgCS8qCj4gPj4gIAkgKiBGSVhNRTogIFRo ZSBwcm9wZXIgc2VxdWVuY2UgaGVyZSB3aWxsIGV2ZW50dWFsbHkgYmU6Cj4gPj4gIAkgKgo+ID4+ IC0JICogZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShkZXYsIHN0YXRlKQo+ID4+ICAJICog ZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X21vZGVzZXRfZGlzYWJsZXMoZGV2LCBzdGF0ZSk7Cj4g Pj4gIAkgKiBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzKGRldiwgc3RhdGUpOwo+ID4+ ICAJICogZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X21vZGVzZXRfZW5hYmxlcyhkZXYsIHN0YXRl KTsKPiA+PiAtCSAqIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX3ZibGFua3MoZGV2LCBzdGF0 ZSk7Cj4gPj4gLQkgKiBkcm1fYXRvbWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyhkZXYsIHN0YXRl KTsKPiA+PiAtCSAqIGRybV9hdG9taWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gPj4gLQkgKgo+ID4+ IC0JICogb25jZSB3ZSBoYXZlIGZ1bGwgYXRvbWljIG1vZGVzZXQuICBGb3Igbm93LCBqdXN0IG1h bnVhbGx5IHVwZGF0ZQo+ID4+IC0JICogcGxhbmUgc3RhdGVzIHRvIGF2b2lkIGNsb2JiZXJpbmcg Z29vZCBzdGF0ZXMgd2l0aCBkdW1teSBzdGF0ZXMKPiA+PiAtCSAqIHdoaWxlIG51Y2xlYXIgcGFn ZWZsaXBwaW5nLgo+ID4+ICAJICovCj4gPj4gLQlmb3IgKGkgPSAwOyBpIDwgZGV2LT5tb2RlX2Nv bmZpZy5udW1fdG90YWxfcGxhbmU7IGkrKykgewo+ID4+IC0JCXN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lID0gc3RhdGUtPnBsYW5lc1tpXTsKPiA+PiAtCj4gPj4gLQkJaWYgKCFwbGFuZSkKPiA+PiAt CQkJY29udGludWU7Cj4gPj4gLQo+ID4+IC0JCXBsYW5lLT5zdGF0ZS0+c3RhdGUgPSBzdGF0ZTsK PiA+PiAtCQlzd2FwKHN0YXRlLT5wbGFuZV9zdGF0ZXNbaV0sIHBsYW5lLT5zdGF0ZSk7Cj4gPj4g LQkJcGxhbmUtPnN0YXRlLT5zdGF0ZSA9IE5VTEw7Cj4gPj4gLQl9Cj4gPj4gLQo+ID4+IC0JLyog c3dhcCBjcnRjX3NjYWxlcl9zdGF0ZSAqLwo+ID4+IC0JZm9yIChpID0gMDsgaSA8IGRldi0+bW9k ZV9jb25maWcubnVtX2NydGM7IGkrKykgewo+ID4+IC0JCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9 IHN0YXRlLT5jcnRjc1tpXTsKPiA+PiAtCQlpZiAoIWNydGMpIHsKPiA+PiAtCQkJY29udGludWU7 Cj4gPj4gLQkJfQo+ID4+IC0KPiA+PiAtCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPnN0YXRl KS0+c2NhbGVyX3N0YXRlID0KPiA+PiAtCQkJdG9faW50ZWxfY3J0Y19zdGF0ZShzdGF0ZS0+Y3J0 Y19zdGF0ZXNbaV0pLT5zY2FsZXJfc3RhdGU7Cj4gPj4gLQo+ID4+IC0JCWlmIChJTlRFTF9JTkZP KGRldiktPmdlbiA+PSA5KQo+ID4+IC0JCQlza2xfZGV0YWNoX3NjYWxlcnModG9faW50ZWxfY3J0 YyhjcnRjKSk7Cj4gPj4gLQl9Cj4gPj4gLQo+ID4+ICAJZHJtX2F0b21pY19oZWxwZXJfY29tbWl0 X3BsYW5lcyhkZXYsIHN0YXRlKTsKPiA+PiArCj4gPj4gIAlkcm1fYXRvbWljX2hlbHBlcl93YWl0 X2Zvcl92YmxhbmtzKGRldiwgc3RhdGUpOwo+ID4+ICAJZHJtX2F0b21pY19oZWxwZXJfY2xlYW51 cF9wbGFuZXMoZGV2LCBzdGF0ZSk7Cj4gPj4gIAlkcm1fYXRvbWljX3N0YXRlX2ZyZWUoc3RhdGUp Owo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBpbmRleCA2NWVlMmNk MDQzN2MuLjEwNWJkZjg0ZTQ2YSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+PiBAQCAtMTMyMDIsMTEgKzEzMjAyLDE0IEBAIHN0YXRpYyB2b2lkIGludGVs X2JlZ2luX2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+PiAgCj4gPj4gIAkv KiBQZXJmb3JtIHZibGFuayBldmFzaW9uIGFyb3VuZCBjb21taXQgb3BlcmF0aW9uICovCj4gPj4g IAlpZiAoaW50ZWxfY3J0Yy0+YXRvbWljLmV2YWRlICYmCj4gPj4gLQkgICAgIWRldl9wcml2LT5w b3dlcl9kb21haW5zLmluaXRfcG93ZXJfb24pCj4gPj4gKwkgICAgIWRldl9wcml2LT5wb3dlcl9k b21haW5zLmluaXRfcG93ZXJfb24pIHsKPiA+PiArCQlpZiAoZGV2X3ByaXYtPmluZm8uZ2VuID49 IDkpCj4gPj4gKwkJCXNrbF9kZXRhY2hfc2NhbGVycyh0b19pbnRlbF9jcnRjKGNydGMpKTsKPiA+ IERvbid0IHdlIG5lZWQgdG8gdXBkYXRlIHNrbF9kZXRhY2hfc2NhbGVycyB0byBsb29rIGF0IHRo ZSBvdGhlciBjb25maWcKPiA+IG5vdz8gT3IgaXMgdGhpcyBhbiBpc3N1ZSB3aXRoIHRoZSBwYXRj aCBzcGxpdHRpbmc/Cj4gPgo+ID4gQWxzbyB3aHkgaXMgdGhpcyBwcm90ZWN0ZWQgYnkgYXRvbWlj LmV2YWRlPwo+IE1vc3RseSB0byBub3QgcnVuIGlmIGEgbW9kZXNldCdzIGRvbmUsIHRoYXQgYWxy ZWFkeSBraWxscyB0aGUgc2NhbGVycy4KCkFzIG1lbnRpb25lZCBpbiBhbm90aGVyIHJlcGx5IHdl IGRvbid0IHJlYWxseSB3YW50IHRvIGRpc2FibGUgdGhlIGV2YWRlCmxvZ2ljIGZvciBtb2Rlc2V0 cy4gQW5kIGlmIHRoaXMgaXMgdG8gYmUgYXZvaWRlZCBmb3IgIW1vZGVzZXQgdGhlbiBpdCdzCmNs ZWFyZXIgdG8gY2hlY2sgZm9yIHRoYXQgZXhwbGljaXRseS4KLURhbmllbAotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK