From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/skl: Remove unnecessary local variables in skl_plane_ctl*() Date: Tue, 12 May 2015 21:00:29 +0300 Message-ID: <20150512180029.GN18908@intel.com> References: <1431453202-9580-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 866F66E66B for ; Tue, 12 May 2015 11:00:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1431453202-9580-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMTIsIDIwMTUgYXQgMDY6NTM6MjJQTSArMDEwMCwgRGFtaWVuIExlc3BpYXUg d3JvdGU6Cj4gVmlsbGUgbm90aWNlZCBpbiBhbm90aGVyIHBhdGNoIHdlIHdlIGRpZG4ndCBuZWVk IHRoZW0gYXQgYWxsLCBzbyByZW1vdmUKPiB0aGVtLiBJdCdzIHdvcnRoIHNheWluZyB0aGF0IGl0 IG1ha2VzIG5vIGRpZmZlcmVuY2UgdG8gY29kZSBnZW5lcmF0ZWQgYXMKPiBnY2MgaXMgY2xldmVy IGVub3VnaCB0byBvcHRpbWl6ZSBpdCBvdXQuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERh bWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlhdUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQ4ICsrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMjcgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDIz NzY1ZDIuLjc1YWIyOTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g QEAgLTI5NTMsMjAgKzI5NTMsMTggQEAgdm9pZCBza2xfZGV0YWNoX3NjYWxlcnMoc3RydWN0IGlu dGVsX2NydGMgKmludGVsX2NydGMpCj4gIAo+ICB1MzIgc2tsX3BsYW5lX2N0bF9mb3JtYXQodWlu dDMyX3QgcGl4ZWxfZm9ybWF0KQo+ICB7Cj4gLQl1MzIgZm9ybWF0ID0gMDsKPiAtCj4gIAlzd2l0 Y2ggKHBpeGVsX2Zvcm1hdCkgewo+ICAJY2FzZSBEUk1fRk9STUFUX0M4Ogo+IC0JCWZvcm1hdCA9 IFBMQU5FX0NUTF9GT1JNQVRfSU5ERVhFRDsKPiArCQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9J TkRFWEVEOwo+ICAJCWJyZWFrOwoKQ2FuIGtpbGwgYWxsIHRoZSBicmVha3MgdG9vICh3aXRoIGEg ZmV3IHJldHVybiAwJ3MgYWRkZWQpCgpXaXRoIHRob3NlIGNoYW5nZXMgdGhpcyBnZXRzClJldmll d2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoK PiAgCWNhc2UgRFJNX0ZPUk1BVF9SR0I1NjU6Cj4gLQkJZm9ybWF0ID0gUExBTkVfQ1RMX0ZPUk1B VF9SR0JfNTY1Owo+ICsJCXJldHVybiBQTEFORV9DVExfRk9STUFUX1JHQl81NjU7Cj4gIAkJYnJl YWs7Cj4gIAljYXNlIERSTV9GT1JNQVRfWEJHUjg4ODg6Cj4gLQkJZm9ybWF0ID0gUExBTkVfQ1RM X0ZPUk1BVF9YUkdCXzg4ODggfCBQTEFORV9DVExfT1JERVJfUkdCWDsKPiArCQlyZXR1cm4gUExB TkVfQ1RMX0ZPUk1BVF9YUkdCXzg4ODggfCBQTEFORV9DVExfT1JERVJfUkdCWDsKPiAgCQlicmVh azsKPiAgCWNhc2UgRFJNX0ZPUk1BVF9YUkdCODg4ODoKPiAtCQlmb3JtYXQgPSBQTEFORV9DVExf Rk9STUFUX1hSR0JfODg4ODsKPiArCQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9YUkdCXzg4ODg7 Cj4gIAkJYnJlYWs7Cj4gIAkvKgo+ICAJICogWFhYOiBGb3IgQVJCRy9BQkdSIGZvcm1hdHMgd2Ug ZGVmYXVsdCB0byBleHBlY3Rpbmcgc2Nhbm91dCBidWZmZXJzCj4gQEAgLTI5NzQsODIgKzI5NzIs NzggQEAgdTMyIHNrbF9wbGFuZV9jdGxfZm9ybWF0KHVpbnQzMl90IHBpeGVsX2Zvcm1hdCkKPiAg CSAqIERSTV9GT1JNQVQpIGZvciB1c2VyLXNwYWNlIHRvIGNvbmZpZ3VyZSB0aGF0Lgo+ICAJICov Cj4gIAljYXNlIERSTV9GT1JNQVRfQUJHUjg4ODg6Cj4gLQkJZm9ybWF0ID0gUExBTkVfQ1RMX0ZP Uk1BVF9YUkdCXzg4ODggfCBQTEFORV9DVExfT1JERVJfUkdCWCB8Cj4gKwkJcmV0dXJuIFBMQU5F X0NUTF9GT1JNQVRfWFJHQl84ODg4IHwgUExBTkVfQ1RMX09SREVSX1JHQlggfAo+ICAJCQlQTEFO RV9DVExfQUxQSEFfU1dfUFJFTVVMVElQTFk7Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIERSTV9GT1JN QVRfQVJHQjg4ODg6Cj4gLQkJZm9ybWF0ID0gUExBTkVfQ1RMX0ZPUk1BVF9YUkdCXzg4ODggfAo+ ICsJCXJldHVybiBQTEFORV9DVExfRk9STUFUX1hSR0JfODg4OCB8Cj4gIAkJCVBMQU5FX0NUTF9B TFBIQV9TV19QUkVNVUxUSVBMWTsKPiAgCQlicmVhazsKPiAgCWNhc2UgRFJNX0ZPUk1BVF9YUkdC MjEwMTAxMDoKPiAtCQlmb3JtYXQgPSBQTEFORV9DVExfRk9STUFUX1hSR0JfMjEwMTAxMDsKPiAr CQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9YUkdCXzIxMDEwMTA7Cj4gIAkJYnJlYWs7Cj4gIAlj YXNlIERSTV9GT1JNQVRfWEJHUjIxMDEwMTA6Cj4gLQkJZm9ybWF0ID0gUExBTkVfQ1RMX09SREVS X1JHQlggfCBQTEFORV9DVExfRk9STUFUX1hSR0JfMjEwMTAxMDsKPiArCQlyZXR1cm4gUExBTkVf Q1RMX09SREVSX1JHQlggfCBQTEFORV9DVExfRk9STUFUX1hSR0JfMjEwMTAxMDsKPiAgCQlicmVh azsKPiAgCWNhc2UgRFJNX0ZPUk1BVF9ZVVlWOgo+IC0JCWZvcm1hdCA9IFBMQU5FX0NUTF9GT1JN QVRfWVVWNDIyIHwgUExBTkVfQ1RMX1lVVjQyMl9ZVVlWOwo+ICsJCXJldHVybiBQTEFORV9DVExf Rk9STUFUX1lVVjQyMiB8IFBMQU5FX0NUTF9ZVVY0MjJfWVVZVjsKPiAgCQlicmVhazsKPiAgCWNh c2UgRFJNX0ZPUk1BVF9ZVllVOgo+IC0JCWZvcm1hdCA9IFBMQU5FX0NUTF9GT1JNQVRfWVVWNDIy IHwgUExBTkVfQ1RMX1lVVjQyMl9ZVllVOwo+ICsJCXJldHVybiBQTEFORV9DVExfRk9STUFUX1lV VjQyMiB8IFBMQU5FX0NUTF9ZVVY0MjJfWVZZVTsKPiAgCQlicmVhazsKPiAgCWNhc2UgRFJNX0ZP Uk1BVF9VWVZZOgo+IC0JCWZvcm1hdCA9IFBMQU5FX0NUTF9GT1JNQVRfWVVWNDIyIHwgUExBTkVf Q1RMX1lVVjQyMl9VWVZZOwo+ICsJCXJldHVybiBQTEFORV9DVExfRk9STUFUX1lVVjQyMiB8IFBM QU5FX0NUTF9ZVVY0MjJfVVlWWTsKPiAgCQlicmVhazsKPiAgCWNhc2UgRFJNX0ZPUk1BVF9WWVVZ Ogo+IC0JCWZvcm1hdCA9IFBMQU5FX0NUTF9GT1JNQVRfWVVWNDIyIHwgUExBTkVfQ1RMX1lVVjQy Ml9WWVVZOwo+ICsJCXJldHVybiBQTEFORV9DVExfRk9STUFUX1lVVjQyMiB8IFBMQU5FX0NUTF9Z VVY0MjJfVllVWTsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gIAkJTUlTU0lOR19DQVNFKHBp eGVsX2Zvcm1hdCk7Cj4gIAl9Cj4gIAo+IC0JcmV0dXJuIGZvcm1hdDsKPiArCXJldHVybiAwOwo+ ICB9Cj4gIAo+ICB1MzIgc2tsX3BsYW5lX2N0bF90aWxpbmcodWludDY0X3QgZmJfbW9kaWZpZXIp Cj4gIHsKPiAtCXUzMiBwbGFuZV9jdGxfdGlsaW5nID0gMDsKPiAtCj4gIAlzd2l0Y2ggKGZiX21v ZGlmaWVyKSB7Cj4gIAljYXNlIERSTV9GT1JNQVRfTU9EX05PTkU6CgpyZXR1cm4gMAoKPiAgCQli cmVhazsKPiAgCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1hfVElMRUQ6Cj4gLQkJcGxhbmVfY3RsX3Rp bGluZyA9IFBMQU5FX0NUTF9USUxFRF9YOwo+ICsJCXJldHVybiBQTEFORV9DVExfVElMRURfWDsK PiAgCQlicmVhazsKPiAgCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1lfVElMRUQ6Cj4gLQkJcGxhbmVf Y3RsX3RpbGluZyA9IFBMQU5FX0NUTF9USUxFRF9ZOwo+ICsJCXJldHVybiBQTEFORV9DVExfVElM RURfWTsKPiAgCQlicmVhazsKPiAgCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEOgo+IC0J CXBsYW5lX2N0bF90aWxpbmcgPSBQTEFORV9DVExfVElMRURfWUY7Cj4gKwkJcmV0dXJuIFBMQU5F X0NUTF9USUxFRF9ZRjsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gIAkJTUlTU0lOR19DQVNF KGZiX21vZGlmaWVyKTsKPiAgCX0KPiAgCj4gLQlyZXR1cm4gcGxhbmVfY3RsX3RpbGluZzsKPiAr CXJldHVybiAwOwo+ICB9Cj4gIAo+ICB1MzIgc2tsX3BsYW5lX2N0bF9yb3RhdGlvbih1bnNpZ25l ZCBpbnQgcm90YXRpb24pCj4gIHsKPiAtCXUzMiBwbGFuZV9jdGxfcm90YXRpb24gPSAwOwo+IC0K PiAgCXN3aXRjaCAocm90YXRpb24pIHsKPiAgCWNhc2UgQklUKERSTV9ST1RBVEVfMCk6CgpyZXR1 cm4gMAoKPiAgCQlicmVhazsKPiAgCWNhc2UgQklUKERSTV9ST1RBVEVfOTApOgo+IC0JCXBsYW5l X2N0bF9yb3RhdGlvbiA9IFBMQU5FX0NUTF9ST1RBVEVfOTA7Cj4gKwkJcmV0dXJuIFBMQU5FX0NU TF9ST1RBVEVfOTA7Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIEJJVChEUk1fUk9UQVRFXzE4MCk6Cj4g LQkJcGxhbmVfY3RsX3JvdGF0aW9uID0gUExBTkVfQ1RMX1JPVEFURV8xODA7Cj4gKwkJcmV0dXJu IFBMQU5FX0NUTF9ST1RBVEVfMTgwOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBCSVQoRFJNX1JPVEFU RV8yNzApOgo+IC0JCXBsYW5lX2N0bF9yb3RhdGlvbiA9IFBMQU5FX0NUTF9ST1RBVEVfMjcwOwo+ ICsJCXJldHVybiBQTEFORV9DVExfUk9UQVRFXzI3MDsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6 Cj4gIAkJTUlTU0lOR19DQVNFKHJvdGF0aW9uKTsKPiAgCX0KPiAgCj4gLQlyZXR1cm4gcGxhbmVf Y3RsX3JvdGF0aW9uOwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIHNreWxh a2VfdXBkYXRlX3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+IC0tIAo+IDIu MS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==