From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 07/17] drm/i915: Use crtc_state->active instead of crtc_state->enable Date: Tue, 19 May 2015 10:09:46 +0200 Message-ID: <20150519080946.GF15256@phenom.ffwll.local> References: <1431548627-2527-1-git-send-email-maarten.lankhorst@linux.intel.com> <1431548627-2527-8-git-send-email-maarten.lankhorst@linux.intel.com> <20150518153047.GW15256@phenom.ffwll.local> <555A14EF.1060509@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 736BC6E600 for ; Tue, 19 May 2015 01:07:21 -0700 (PDT) Received: by wgjc11 with SMTP id c11so8150816wgj.0 for ; Tue, 19 May 2015 01:07:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <555A14EF.1060509@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXkgMTgsIDIwMTUgYXQgMDY6MzU6NTlQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTgtMDUtMTUgb20gMTc6MzAgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gV2VkLCBNYXkgMTMsIDIwMTUgYXQgMTA6MjM6MzdQTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gY3J0Y19zdGF0ZS0+ZW5hYmxlIG1lYW5zIGEgY3J0YyBpcyBjb25m aWd1cmVkLCBidXQgaXQgbWF5IGJlIHR1cm5lZAo+ID4+IG9mZiBmb3IgZHBtcy4gVW50aWwgdGhl IHByZXZpb3VzIGNvbW1pdCBjcnRjX3N0YXRlLT5hY3RpdmUgd2FzIG5vdAo+ID4+IHVwZGF0ZWQg b24gY3J0YyBvZmYsIGJ1dCBub3cgdGhhdCB3ZSBkbyB3ZSBzaG91bGQgdXNlIHRoYXQgZm9yIHRy YWNraW5nCj4gPj4gd2hldGhlciBhIGNydGMgaXMgc2Nhbm5pbmcgb3V0IG9yIG5vdC4KPiA+Pgo+ ID4+IEF0IHRoaXMgcG9pbnQgY3J0Yy0+YWN0aXZlIHNob3VsZCBtaXJyb3IgY3J0Y19zdGF0ZS0+ YWN0aXZlLAo+ID4+IHNvIHNvbWUgcGFyYW5vaWEgZnJvbSB0aGUgY3J0Y19kaXNhYmxlIGZ1bmN0 aW9ucyBjYW4gYmUgcmVtb3ZlZC4KPiA+Pgo+ID4+IE5vdGUgdGhhdCBpbnRlbF9zZXRfbW9kZV9z ZXR1cF9wbGxzIHN0aWxsIGNoZWNrcyBmb3IgLT5lbmFibGUsCj4gPj4gYmVjYXVzZSBhbGwgcmVz b3VyY2VzIHRoYXQgYXJlIG5lZWRlZCBoYXZlIHRvIGJlIGNhbGN1bGF0ZWQsIHNvCj4gPj4gZHBt cyBjaGFuZ2VzIHdpbGwgc3RpbGwgc3VjY2VlZC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBB IGZldyBkZXRhaWwgY29tbWVudHMgYmVsb3cuCj4gPiAtRGFuaWVsCj4gPgo+ID4+IC0tLQo+ID4+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgICAgfCAgMiArLQo+ID4+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0NCArKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCsp LCAyMyBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4+IGlu ZGV4IDU1N2FmODg3N2EyZS4uY2E0NTczMTdhOGFjIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2lycS5jCj4gPj4gQEAgLTc5Niw3ICs3OTYsNyBAQCBzdGF0aWMgaW50IGk5MTVfZ2V0X3Zi bGFua190aW1lc3RhbXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUsCj4gPj4gIAkJ cmV0dXJuIC1FSU5WQUw7Cj4gPj4gIAl9Cj4gPj4gIAo+ID4+IC0JaWYgKCFjcnRjLT5zdGF0ZS0+ ZW5hYmxlKSB7Cj4gPj4gKwlpZiAoIWNydGMtPnN0YXRlLT5hY3RpdmUpIHsKPiA+IFRoaXMgY2hh bmdlIGxvb2tzIHVuanVzdGlmaWVkIEkgdGhpbmsuCj4gV2h5PyBDYW4geW91IGdldCBhIHZibGFu ayBvbiBjcnRjIHRoYXQgaXMgZHBtcyBvZmY/IEkgdGhpbmsgbm90Li4KPiAKPiBFaXRoZXIgd2F5 IGxhdGVyIG9uIEkgdXNlIGh3bW9kZS0+Y3J0Y19jbG9jayB3aGljaCByZW5kZXJzIHRoaXMgbW9v dC4KPiA+PiA8c25pcD4KPiA+PiBAQCAtNTc0Miw3ICs1NzM4LDcgQEAgc3RhdGljIGludCB2YWxs ZXl2aWV3X21vZGVzZXRfZ2xvYmFsX3BpcGVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSkKPiA+PiAgCj4gPj4gIAkvKiBhZGQgYWxsIGFjdGl2ZSBwaXBlcyB0byB0aGUgc3RhdGUgKi8K PiA+PiAgCWZvcl9lYWNoX2NydGMoc3RhdGUtPmRldiwgY3J0Yykgewo+ID4+IC0JCWlmICghY3J0 Yy0+c3RhdGUtPmVuYWJsZSkKPiA+PiArCQlpZiAoIWNydGMtPnN0YXRlLT5hY3RpdmUpCj4gPiBU aGlzIGlzIGEgZnVuY3Rpb25hbCBjaGFuZ2UgdG8gdGhlIGNkY2xrIGNvZGUgYW5kIG1pZ2h0IGJy ZWFrIGl0IGFuZC9vcgo+ID4gY29uZmxpY3Qgd2l0aCB0aGUgb25nb2luZyBjZGNsayB3b3JrIGZy b20gVmlsbGUvTWlrYS4gRGVmaW5pdGVseSBuZWVkcyB0bwo+ID4gYmUgc3BsaXQgb3V0Lgo+IE5v IHRoaXMgZnVuY3Rpb24ganVzdCBzZXRzIG1vZGVfY2hhbmdlZCBvbiBhbGwgYWN0aXZlIGNydGMn cy4KPiAKPiBUaGlzIGlzIGRvbmUgdG8gdHVybiB0aGVtIG9mZiB3aGlsZSBjaGFuZ2luZyB0aGUg Y2xvY2suIEluIGNhc2UgdGhleSdyZSBhbHJlYWR5IHR1cm5lZCBvZmYgeW91IGRvbid0IGhhdmUg dG8gdHVybiB0aGVtIG9mZi4KPiAKPiA+PiAgCQkJY29udGludWU7Cj4gPj4gIAo+ID4+ICAJCWNy dGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPiA+PiBA QCAtNTc1Miw3ICs1NzQ4LDcgQEAgc3RhdGljIGludCB2YWxsZXl2aWV3X21vZGVzZXRfZ2xvYmFs X3BpcGVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+PiAgCj4gPj4gIAkvKiBk aXNhYmxlL2VuYWJsZSBhbGwgY3VycmVudGx5IGFjdGl2ZSBwaXBlcyB3aGlsZSB3ZSBjaGFuZ2Ug Y2RjbGsgKi8KPiA+PiAgCWZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNf c3RhdGUsIGkpCj4gPj4gLQkJaWYgKGNydGNfc3RhdGUtPmVuYWJsZSkKPiA+PiArCQlpZiAoY3J0 Y19zdGF0ZS0+YWN0aXZlKQo+ID4+ICAJCQljcnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVl Owo+ID4gU2FtZSBoZXJlLgo+ID4KPiA+IEhtLCBhc2lkZSBvZiBhbGwgdGhhdCBtYXliZSB3ZSBz aG91bGQgZHJvcCB2bHZfbW9kZXNldF9nbG9iYWxfcGlwZXMgYW5kCj4gPiBpbnN0ZWFkIGp1c3Qg bG9vayBhdCBjcnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQ/IFRoYXQgd2F5IHdlIGRvbid0IG5lZWQg dG8KPiA+IGR1cGxpY2F0ZSB0aGUgc2FtZSBjaGVja3MgdHdpY2UsIG9uY2UgdG8gc2V0IC0+bW9k ZV9jaGFuZ2VkIGFuZCBvbmNlIHRvCj4gPiBmb3IgdGhlIHByZXBhcmVfcGlwZXMgbWFzay4gT3Ig aXMgdGhhdCBkdXBsaWNhdGlvbiBhbHJlYWR5IGdldHRpbmcKPiA+IHJlbW92ZWQ/Cj4gSSB0aGlu ayB3ZSBjb3VsZCBnZXQgcmlkIG9mIGEgbG90IG9mIHRob3NlIGV4dHJhIGxvb3BzIGlmIHdlIHdh bnQgdG8gbGF0ZXIsCj4gYnV0IGZvciBub3cgcmVhZGFiaWxpdHkgaXMgbW9yZSBpbXBvcnRhbnQu CgpIbSBtYWtlcyBzZW5zZSB3aXRoIHlvdXIgcmVwbGllcyAtIHRoZXJlJ3MgYSBmZXcgY2FzZXMg aW5kZWVkIHdoZXJlIHdlCm5lZWQgdG8gc3dpdGNoIGZyb20gY2hlY2tpbmcgLT5lbmFibGUgdG8g LT5hY3RpdmUgaWYgd2Ugc3RhcnQgdXNpbmcgdGhlCm1vZGVfc2V0IG1hY2hpbmVyeSBmb3IgZHBt cy4gSSB0aGluayBpdCdkIGJlIGdvb2QgdG8gZXhwbGFpbiB0aGF0IGEgYml0IGluCnRoZSBjb21t aXQgbWVzc2FnZSBmb3IgYWxsIHRoZSBkaWZmZXJlbnQgY2FzZXMsIHNvIHRoYXQgcmV2aWV3ZXJz IGNhbiBnbwpodW50aW5nIGZvciBtb3JlIGFuZCBtYWtlIHN1cmUgdGhlcmUgYXJlbid0IDstKQot RGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=