From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 11/17] drm/i915: Use global atomic state for staged pll config Date: Tue, 19 May 2015 10:13:50 +0200 Message-ID: <20150519081350.GG15256@phenom.ffwll.local> References: <1431548627-2527-1-git-send-email-maarten.lankhorst@linux.intel.com> <1431548627-2527-12-git-send-email-maarten.lankhorst@linux.intel.com> <20150518154513.GY15256@phenom.ffwll.local> <555A1307.2000004@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 315F6720EE for ; Tue, 19 May 2015 01:11:25 -0700 (PDT) Received: by wicmx19 with SMTP id mx19so107021011wic.0 for ; Tue, 19 May 2015 01:11:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <555A1307.2000004@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXkgMTgsIDIwMTUgYXQgMDY6Mjc6NTFQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTgtMDUtMTUgb20gMTc6NDUgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gV2VkLCBNYXkgMTMsIDIwMTUgYXQgMTA6MjM6NDFQTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gRnJvbTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRl ci5jb25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgo+ID4+Cj4gPj4gTm93IHRoYXQgd2Ug Y2FuIHN1YmNsYXNzIGRybV9hdG9taWNfc3RhdGUgd2UgY2FuIGFsc28gdXNlIGl0IHRvIGtlZXAK PiA+PiB0cmFjayBvZiBhbGwgdGhlIHBsbCBzZXR0aW5ncy4gYXRvbWljX3N0YXRlIGlzIGEgYmV0 dGVyIHBsYWNlIHRvIGhvbGQKPiA+PiBhbGwgc2hhcmVkIHN0YXRlIHRoYW4ga2VlcGluZyBwbGwt Pm5ld19jb25maWcgZXZlcnl3aGVyZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4gLS0tCj4g Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8ICAgMSAtCj4gPj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jICB8ICA0OSArKysrKysrKysrKysrKysr Cj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDExMSArKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaCAgICAgfCAgMTMgKysrKwo+ID4+ICA0IGZpbGVzIGNoYW5nZWQsIDk1IGluc2Vy dGlvbnMoKyksIDc5IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o Cj4gPj4gaW5kZXggYTBlNDg2ODY1M2YyLi4wZTIwMDAxOGM5YWEgMTAwNjQ0Cj4gPj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPiA+PiBAQCAtMzE5LDcgKzMxOSw2IEBAIHN0cnVjdCBpbnRlbF9z aGFyZWRfZHBsbF9jb25maWcgewo+ID4+ICAKPiA+PiAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxs IHsKPiA+PiAgCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbF9jb25maWcgY29uZmlnOwo+ID4+IC0J c3RydWN0IGludGVsX3NoYXJlZF9kcGxsX2NvbmZpZyAqbmV3X2NvbmZpZzsKPiA+PiAgCj4gPj4g IAlpbnQgYWN0aXZlOyAvKiBjb3VudCBvZiBudW1iZXIgb2YgYWN0aXZlIENSVENzIChpLmUuIERQ TVMgb24pICovCj4gPj4gIAlib29sIG9uOyAvKiBpcyB0aGUgUExMIGFjdHVhbGx5IGFjdGl2ZT8g RGlzYWJsZWQgZHVyaW5nIG1vZGVzZXQgKi8KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9t aWMuYwo+ID4+IGluZGV4IDdlZDgwMzNhYWU2MC4uYWZmODcwNTQ0MDZjIDEwMDY0NAo+ID4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4gPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMKPiA+PiBAQCAtNDIxLDMgKzQyMSw1MiBAQCBp bnQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ PiAgCj4gPj4gIAlyZXR1cm4gMDsKPiA+PiAgfQo+ID4+ICsKPiA+PiArc3RhdGljIHZvaWQgaW50 ZWxfYXRvbWljX2R1cGxpY2F0ZV9kcGxsX3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g Pj4gKwkJCQkJICAgICAgc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPj4gK3sK PiA+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsK PiA+PiArCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+ID4+ICsJZW51bSBpbnRlbF9k cGxsX2lkIGk7Cj4gPj4gKwo+ID4+ICsJc3RhdGUtPmRwbGxfc2V0ID0gdHJ1ZTsKPiA+IFRoZSB3 dyBtdXRleCBsb2NraW5nIGRhbmNlIGhlcmUgaXMgbWlzc2luZy4gRm9yIHNpbXBsaWNpdHkgSSB0 aGluayB3ZQo+ID4gY291bGQganVzdCByZXB1cnBvc2UgdGhlIGRldi0+bW9kZV9jb25maWcuY29u bmVjdGlvbl9tdXRleC4gV2UgbmVlZCB0aGF0Cj4gPiBhbnl3YXkgZnVsbCBtb2Rlc2V0cywgYW5k IGRwbGwgY2hhbmdlcyBzaG91bGQgb25seSBiZSByZXF1aXJlZCBpbiB0aG9zZS4KPiA+IFdoaWNo IG1lYW5zIHRoaXMgd29udCBpbnRyb2R1Y2UgYW55IHVuZWNlc3NhcnkgcGFyYWxsZWxpc20uCj4g Pgo+ID4gSXQgbWVhbnMgdGhvdWdoIHRoYXQgd2UgbmVlZCB0byB3aXJlIHVwIGEgcHJvcGVyIGVy cm9yIGNvZGUgdG8gYWxsIGNhbGxlcnMKPiA+IG9mIGR1cGxpY2F0ZS9nZXRfZHBsbF9zdGF0ZSwg bGlrZSB3aXRoIGFsbCB0aGUgb3RoZXIgYXRvbWljIHN0YXRlcy4gTWlnaHQKPiA+IGJlIGJlc3Qg dG8gZm9sbG93IHRoZSBkZXNpZ24gZm9yIGNvbm5lY3Rvci9jcnRjL3BsYW5lcyBhbiBwYXNzIGFy b3VuZAo+ID4gcG9pbnRlcnMgd2l0aCBlcnJvciBjb2RlcyBleHBsaWNpdGx5IChpbnN0ZWFkIG9m IHJldHVybmluZwo+ID4gc3RhdGUtPnNoYXJlZF9kcGxsIGJlbG93IHNpbmNlIHRoYXQgY2FuIG9u bHkgY29wZSB3aXRoIE5VTEwgYW5kIG5vdCB3aXRoCj4gPiAtRURFQURMSykuCj4gPgo+ID4gU29y cnkgdGhhdCBJIGRpZG4ndCBzcG90IHRoaXMgZWFybGllci4KPiA+Cj4gVGhlIGRwbGwgc3RhdGUg c2hvdWxkIG9ubHkgZXZlciBiZSBkb25lIGR1cmluZyBhIG1vZGVzZXQgaW4gd2hpY2ggY2FzZSB0 aGUgY29ubmVjdGlvbl9tdXRleCBpcyBndWFyYW50ZWVkIHRvIGJlIGhlbGQuCj4gSW5zdGVhZCBv ZiBtYWtpbmcgdGhpcyByZXR1cm4gYSB2YWx1ZSBjYW4gd2UgYWRkIGEgbG9ja2RlcF9hc3NlcnRf aGVsZCA/CgpUaGUgcHJvYmxlbSBpcyB0aGF0IHRoZSBhdG9taWMgY29yZSBtaWdodCBvbmx5IGdy YWIgdGhlIGNydGMgc3RhdGUgYW5kCmNydGMgbXV0ZXggaWYgZS5nLiB1c2Vyc3BhY2Ugb25seSBj aGFuZ2VzIHRoZSBtb2RlLiBCdXQgSSd2ZSBmb3Jnb3R0ZW4KdGhhdCB3ZSdyZSB1c2luZyB0aGUg aGVscGVycyB0byBoYW5kbGUgbW9kZXNldHMsIGFuZCB0aG9zZSB3aWxsIGFjcXVpcmUKYWxsIHRo ZSBuZWVkZWQgY29ubmVjdG9yIHN0YXRlcyBhbmQgaGVuY2UgdGhlIGNvbm5lY3Rpb25fbXV0ZXgu CgpBIGxvY2tpbmcgY2hlY2sgaXMgdGhlcmVmb3JlIGluZGVlZCBlbm91Z2guIEJ1dCBwbGVhc2Ug dXNlCldBUk5fT04oIW11dGV4X2lzX2xvY2tlZCkgc2luY2UgaW1vIGEgbG9ja2luZyBjaGVjayB3 aGljaCBjYW4gYmUgY29tcGlsZWQKb3V0IGlzIHVzZWxlc3MuIEFuZCB0aGUgYWRkaXRpb25hbCBj b3JyZWN0bmVzcyBsb2NrZGVwIHByb3ZpZGVzIGlzbid0Cm5lZWRlZCAtIHdlJ2xsIGNhdGNoIHRo ZSBidWcgc2luY2Ugbm8gb25lIGFsd2F5cyBoaXRzIHRoZSByYWNlIGJ5IGRvaW5nCm1vZGVzZXRz IGluIHBhcmFsbGVsIDstKQotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2lu ZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=