From: Daniel Vetter <daniel@ffwll.ch>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Update comment in clear_intel_crtc_state()
Date: Wed, 20 May 2015 09:33:26 +0200 [thread overview]
Message-ID: <20150520073326.GY15256@phenom.ffwll.local> (raw)
In-Reply-To: <1432101807-8921-1-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Wed, May 20, 2015 at 09:03:27AM +0300, Ander Conselvan de Oliveira wrote:
> Explain why a few fields of the new pipe_config have their values
> preserved, while the others are zeroed.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a7732b4..b0cd649 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11460,7 +11460,11 @@ clear_intel_crtc_state(struct intel_crtc_state *crtc_state)
> enum intel_dpll_id shared_dpll;
> uint32_t ddi_pll_sel;
>
> - /* Clear only the intel specific part of the crtc state excluding scalers */
> + /* FIXME: before the switch to atomic started, a new pipe_config was
> + * kzalloc'd. Code that depends on any field being zero should be
> + * fixed, so that the crtc_state can be safely duplicated. For now,
> + * only fields that are know to not cause problems are preserved. */
> +
> tmp_state = crtc_state->base;
> scaler_state = crtc_state->scaler_state;
> shared_dpll = crtc_state->shared_dpll;
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-20 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 8:51 [PATCH] drm/i915: Preserve ddi_pll_sel when allocating new pipe_config Ander Conselvan de Oliveira
2015-05-15 13:28 ` Damien Lespiau
2015-05-20 6:03 ` [PATCH] drm/i915: Update comment in clear_intel_crtc_state() Ander Conselvan de Oliveira
2015-05-20 7:33 ` Daniel Vetter [this message]
2015-05-20 7:37 ` Jani Nikula
2015-05-20 7:43 ` Ander Conselvan De Oliveira
2015-05-20 7:47 ` Daniel Vetter
2015-05-18 5:06 ` [PATCH] drm/i915: Preserve ddi_pll_sel when allocating new pipe_config shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520073326.GY15256@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox