From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chandra Konduru <chandra.konduru@intel.com>
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org,
ville.syrjala@intel.com
Subject: Re: [PATCH 04/12] drm/i915: Update format_is_yuv() to include NV12
Date: Thu, 21 May 2015 14:29:02 +0300 [thread overview]
Message-ID: <20150521112902.GA18908@intel.com> (raw)
In-Reply-To: <1431925865-7637-5-git-send-email-chandra.konduru@intel.com>
On Sun, May 17, 2015 at 10:10:57PM -0700, Chandra Konduru wrote:
> This patch adds NV12 to format_is_yuv() function
> and made it available for both primary and sprite
> planes.
>
> Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
> ---
> drivers/gpu/drm/i915/intel_drv.h | 1 +
> drivers/gpu/drm/i915/intel_sprite.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index b18cfba..754172f 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1388,6 +1388,7 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
> bool intel_pipe_update_start(struct intel_crtc *crtc,
> uint32_t *start_vbl_count);
> void intel_pipe_update_end(struct intel_crtc *crtc, u32 start_vbl_count);
> +bool format_is_yuv(uint32_t format);
It could probably use an intel_ prefix if it's non static.
Or maybe even move it to the drm core somewhere?
>
> /* intel_tv.c */
> void intel_tv_init(struct drm_device *dev);
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 3355d5a..80ae21f 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -39,7 +39,7 @@
> #include <drm/i915_drm.h>
> #include "i915_drv.h"
>
> -static bool
> +bool
> format_is_yuv(uint32_t format)
> {
> switch (format) {
> @@ -47,6 +47,7 @@ format_is_yuv(uint32_t format)
> case DRM_FORMAT_UYVY:
> case DRM_FORMAT_VYUY:
> case DRM_FORMAT_YVYU:
> + case DRM_FORMAT_NV12:
> return true;
> default:
> return false;
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-21 11:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 5:10 [PATCH 00/12] drm/i915: Adding NV12 for skylake display Chandra Konduru
2015-05-18 5:10 ` [PATCH 01/12] drm/i915: Add register definitions for NV12 support Chandra Konduru
2015-05-18 5:10 ` [PATCH 02/12] drm/i915: Set scaler mode for NV12 Chandra Konduru
2015-05-18 5:10 ` [PATCH 03/12] drm/i915: Stage scaler request for NV12 as src format Chandra Konduru
2015-05-21 11:27 ` Ville Syrjälä
2015-05-21 16:24 ` Konduru, Chandra
2015-05-21 16:49 ` Ville Syrjälä
2015-05-18 5:10 ` [PATCH 04/12] drm/i915: Update format_is_yuv() to include NV12 Chandra Konduru
2015-05-21 11:29 ` Ville Syrjälä [this message]
2015-05-18 5:10 ` [PATCH 05/12] drm/i915: Upscale scaler max scale for NV12 Chandra Konduru
2015-05-18 5:10 ` [PATCH 06/12] drm/i915: Add NV12 as supported format for primary plane Chandra Konduru
2015-05-18 5:11 ` [PATCH 07/12] drm/i915: Add NV12 as supported format for sprite plane Chandra Konduru
2015-05-18 5:11 ` [PATCH 08/12] drm/i915: Add NV12 support to intel_framebuffer_init Chandra Konduru
2015-05-19 8:24 ` Daniel Vetter
2015-05-19 16:31 ` Konduru, Chandra
2015-05-20 7:36 ` Daniel Vetter
2015-05-21 0:31 ` Konduru, Chandra
2015-05-21 9:33 ` Daniel Vetter
2015-05-21 16:11 ` Konduru, Chandra
2015-05-21 17:34 ` Runyan, Arthur J
2015-05-22 19:06 ` Runyan, Arthur J
2015-05-18 5:11 ` [PATCH 09/12] drm/i915: Enable NV12 primary plane via crtc set config Chandra Konduru
2015-05-18 5:11 ` [PATCH 10/12] drm/i915: Add NV12 to primary plane programming Chandra Konduru
2015-05-18 5:11 ` [PATCH 11/12] drm/i915: Add NV12 to sprite " Chandra Konduru
2015-05-18 5:11 ` [PATCH 12/12] drm/i915: Add 90/270 rotation for NV12 format Chandra Konduru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521112902.GA18908@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chandra.konduru@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox