From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915/skl: Deinit/init the display at suspend/resume
Date: Thu, 21 May 2015 19:37:31 +0300 [thread overview]
Message-ID: <20150521163731.GO18908@intel.com> (raw)
In-Reply-To: <20150521161156.GI29499@strange.ger.corp.intel.com>
On Thu, May 21, 2015 at 05:11:57PM +0100, Damien Lespiau wrote:
> On Thu, May 21, 2015 at 06:58:48PM +0300, Ville Syrjälä wrote:
> > > > Hmm, actually are we not calling the skl_init_cdclk() on boot at all? I see
> > > > it only in the resume path.
> > >
> > > Yes that's correct, we always have display intialized by the firmware on
> > > big core as far as I know (which may not be true for BXT).
> >
> > What about module reload?
>
> I can see your point, but we're not totally de-initializing display on
> unload today, so we keep the current CDCLK (among other things) across
> module reload.
>
> Just tried tests/drm_module_reload and it works as expected, display
> comes back up.
Fair enough. Good enough for now at least then.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-21 16:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 13:45 [PATCH 0/5] SKL S3, take 2.5 Damien Lespiau
2015-05-20 13:45 ` [PATCH 1/5] drm/i915/bxt: Also add bxt_resume_prepare() to the S3/S4 path Damien Lespiau
2015-05-20 13:45 ` [PATCH 2/5] drm/i915: Add a space after ', ' and don't capitalize mid-sentence Damien Lespiau
2015-05-20 13:45 ` [PATCH 3/5] drm/i915: Kill the dev variable in intel_suspend_complete() Damien Lespiau
2015-05-21 14:43 ` Ville Syrjälä
2015-05-20 13:45 ` [PATCH 4/5] drm/i915: Store boot CDCLK in dev_priv on DDI platforms Damien Lespiau
2015-05-20 15:53 ` Daniel Vetter
2015-05-20 15:56 ` Daniel Vetter
2015-05-21 12:48 ` Ville Syrjälä
2015-05-20 13:45 ` [PATCH 5/5] drm/i915/skl: Deinit/init the display at suspend/resume Damien Lespiau
2015-05-21 14:42 ` Ville Syrjälä
2015-05-21 15:37 ` [PATCH v3] " Damien Lespiau
2015-05-21 15:44 ` Ville Syrjälä
2015-05-21 15:49 ` Damien Lespiau
2015-05-21 15:58 ` Ville Syrjälä
2015-05-21 16:11 ` Damien Lespiau
2015-05-21 16:37 ` Ville Syrjälä [this message]
2015-05-21 15:54 ` Daniel Vetter
2015-05-22 5:52 ` shuang.he
2015-05-21 18:58 ` [PATCH 5/5] " shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521163731.GO18908@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox