Re: [PATCH 08/13] drm/i915/skl: Remove unnecessary () used with abs_diff()

Paulo Zanoni
2015-05-27T18:42:08Z

2015-05-07 14:38 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> abs_diff() properly protects its parameters, so no need for the outer ()
> here.

Patches 3, 4, 5, 6, 7 and 8:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fd90771..b9d5d65 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1235,7 +1235,7 @@ found:
> if (found) {
> dco_central_freq_deviation[dco_count] =
> div64_u64(10000 *
> - abs_diff((candidate_p * afe_clock),
> + abs_diff(candidate_p * afe_clock,
> dco_central_freq[dco_count]),
> dco_central_freq[dco_count]);
>
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni