Re: [PATCH 09/13] drm/i915/skl: Use MISSING_CASE() in skl_wrpll_params_populate()

Paulo Zanoni
2015-05-27T18:40:32Z

2015-05-07 14:38 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> We now have a special macro for those cases.

I'm not sure if this patch is an improvement. Before it, we always
knew which "switch" statement was bad since we used to print either
"PDiv" or "KDiv". After the patch, it will not be possible to know
from which switch statement the error came from. Of course, there's
the advantage of at least knowing the value. I'd vote to either skip
this patch, or improve the MISSING_CASE macro to be able to account
for multiple uses on the same function. But I'm open to arugmentation
:)

>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index b9d5d65..ab327a1 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1145,7 +1145,7 @@ static void skl_wrpll_params_populate(struct skl_wrpll_params *params,
> params->pdiv = 4;
> break;
> default:
> - WARN(1, "Incorrect PDiv\n");
> + MISSING_CASE(p0);
> }
>
> switch (p2) {
> @@ -1162,7 +1162,7 @@ static void skl_wrpll_params_populate(struct skl_wrpll_params *params,
> params->kdiv = 3;
> break;
> default:
> - WARN(1, "Incorrect KDiv\n");
> + MISSING_CASE(p2);
> }
>
> params->qdiv_ratio = p1;
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni