From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH v3 14/22] drm/i915: Move cdclk and pll setup to intel_modeset_compute_config() Date: Thu, 28 May 2015 17:55:22 -0700 Message-ID: <20150529005522.GB15716@intel.com> References: <1432129094-11765-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-5-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BCA76EC9A for ; Thu, 28 May 2015 17:55:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1432137874-20543-5-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: maarten.lankhorst@linux.intel.com Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMjAsIDIwMTUgYXQgMDY6MDQ6MjZQTSArMDIwMCwgbWFhcnRlbi5sYW5raG9y c3RAbGludXguaW50ZWwuY29tIHdyb3RlOgo+IEZyb206IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2 ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiAKPiBJdCBtYWtl cyBtb3JlIHNlbnNlIHRoZXJlLCBzaW5jZSB0aGVzZSBhcmUgY29tcHV0YXRpb24gc3RlcHMgdGhh dCBjYW4KPiBmYWlsLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpJJ3ZlIG5vdGljZWQgdGhhdCBhIGZldyBv ZiB0aGUgcGF0Y2hlcyBpbiB0aGlzIHNlcmllcyB3ZXJlIG9yaWdpbmFsbHkKd3JpdHRlbiBieSBB bmRlciwgYnV0IHNlZW0gdG8gYmUgbWlzc2luZyBoaXMgcy1vLWIgbGluZS4gIEkgdGhpbmsgeW91 CmdlbmVyYWxseSB3YW50IHRvIGp1c3QgYXBwZW5kIHlvdXIgbGluZSBhZnRlciBoaXMgaW4gdGhh dCBjYXNlLgoKT25lIG90aGVyIGNvc21ldGljIG5vdGUgZmFydGhlciBkb3duLgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNzAgKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCsp LCAzNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggODFkNTM1OGVmZGRlLi5lN2FhODYxMGNiZGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyMDg1LDM3ICsxMjA4NSw2IEBAIHN0YXRpYyB2b2lkIHVw ZGF0ZV9zY2FubGluZV9vZmZzZXQoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAkJY3J0Yy0+ c2NhbmxpbmVfb2Zmc2V0ID0gMTsKPiAgfQo+ICAKPiAtc3RhdGljIGludAo+IC1pbnRlbF9tb2Rl c2V0X2NvbXB1dGVfY29uZmlnKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAtewo+ IC0Jc3RydWN0IGRybV9jcnRjICpjcnRjOwo+IC0Jc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRj X3N0YXRlOwo+IC0JaW50IHJldCwgaTsKPiAtCj4gLQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9j aGVja19tb2Rlc2V0KHN0YXRlLT5kZXYsIHN0YXRlKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJu IHJldDsKPiAtCj4gLQlmb3JfZWFjaF9jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBjcnRjX3N0 YXRlLCBpKSB7Cj4gLQkJaWYgKCFjcnRjX3N0YXRlLT5lbmFibGUgJiYKPiAtCQkgICAgV0FSTl9P TihjcnRjX3N0YXRlLT5hY3RpdmUpKQo+IC0JCQljcnRjX3N0YXRlLT5hY3RpdmUgPSBmYWxzZTsK PiAtCj4gLQkJaWYgKCFjcnRjX3N0YXRlLT5lbmFibGUpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAt CQlyZXQgPSBpbnRlbF9tb2Rlc2V0X3BpcGVfY29uZmlnKGNydGMsIHN0YXRlKTsKPiAtCQlpZiAo cmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+IC0KPiAtCQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHRv X2ludGVsX2NydGMoY3J0YyksCj4gLQkJCQkgICAgICAgdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRj X3N0YXRlKSwKPiAtCQkJCSAgICAgICAiW21vZGVzZXRdIik7Cj4gLQl9Cj4gLQo+IC0JcmV0dXJu IGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lcyhzdGF0ZS0+ZGV2LCBzdGF0ZSk7Cj4gLX0K PiAtCj4gIHN0YXRpYyBpbnQgX19pbnRlbF9zZXRfbW9kZV9zZXR1cF9wbGxzKHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHN0 YXRlLT5kZXY7Cj4gQEAgLTEyMTkxLDYgKzEyMTYwLDQxIEBAIHN0YXRpYyBpbnQgX19pbnRlbF9z ZXRfbW9kZV9jaGVja3Moc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJcmV0dXJu IDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQKPiAraW50ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZp ZyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBkcm1fY3J0 YyAqY3J0YzsKPiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCWludCBy ZXQsIGk7Cj4gKwo+ICsJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNldChzdGF0 ZS0+ZGV2LCBzdGF0ZSk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJZm9y X2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+ICsJCWlm ICghY3J0Y19zdGF0ZS0+ZW5hYmxlICYmCj4gKwkJICAgIFdBUk5fT04oY3J0Y19zdGF0ZS0+YWN0 aXZlKSkKPiArCQkJY3J0Y19zdGF0ZS0+YWN0aXZlID0gZmFsc2U7Cj4gKwo+ICsJCWlmICghY3J0 Y19zdGF0ZS0+ZW5hYmxlKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJcmV0ID0gaW50ZWxfbW9k ZXNldF9waXBlX2NvbmZpZyhjcnRjLCBzdGF0ZSk7Cj4gKwkJaWYgKHJldCkKPiArCQkJcmV0dXJu IHJldDsKPiArCj4gKwkJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19pbnRlbF9jcnRjKGNydGMp LAo+ICsJCQkJICAgICAgIHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSksCj4gKwkJCQkg ICAgICAgIlttb2Rlc2V0XSIpOwo+ICsJfQo+ICsKPiArCXJldCA9IGRybV9hdG9taWNfaGVscGVy X2NoZWNrX3BsYW5lcyhzdGF0ZS0+ZGV2LCBzdGF0ZSk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVy biByZXQ7Cj4gKwo+ICsJcmV0dXJuIF9faW50ZWxfc2V0X21vZGVfY2hlY2tzKHN0YXRlKTsKCkp1 c3QgYSBjb3NtZXRpYyBub3RlLCBidXQgbWF5YmUgd2Ugc2hvdWxkIHJlbmFtZSB0aGlzIGZ1bmN0 aW9uIG5vdz8KSXQncyBub3QgY2FsbGVkIGZyb20gX19pbnRlbF9zZXRfbW9kZSBhbnltb3JlIGFu ZCBpdCBpc24ndCByZWFsbHkKJ2NoZWNrcycgKGJ1dCByYXRoZXIgc2V0dXAgdGhhdCB3ZSBpbnRl bmQgdG8gYmUgZG9uZSBkdXJpbmcgdGhlIGNoZWNrCnBoYXNlKSwgc28gdGhlIHdob2xlIG5hbWUg c2VlbXMgYSBiaXQgbWlzbGVhZGluZyBub3cuCgoKTWF0dAoKPiArfQo+ICsKPiAgc3RhdGljIGlu dCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgewo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHN0YXRlLT5kZXY7Cj4gQEAgLTEyMjAwLDEwICsx MjIwNCw2IEBAIHN0YXRpYyBpbnQgX19pbnRlbF9zZXRfbW9kZShzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUpCj4gIAlpbnQgcmV0ID0gMDsKPiAgCWludCBpOwo+ICAKPiAtCXJldCA9IF9f aW50ZWxfc2V0X21vZGVfY2hlY2tzKHN0YXRlKTsKPiAtCWlmIChyZXQgPCAwKQo+IC0JCXJldHVy biByZXQ7Cj4gLQo+ICAJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfcHJlcGFyZV9wbGFuZXMoZGV2 LCBzdGF0ZSk7Cj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiByZXQ7Cj4gLS0gCj4gMi4xLjAKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g Ck1hdHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0Zm9ybSBFbmFi bGluZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==